[Bug c++/56543] New: [4.7.3/4.8 Regression] ICE on valid code in copy_node_stat

[Bug c++/56543] New: [4.7.3/4.8 Regression] ICE on valid code in copy_node_stat

[gcc at abeckmann dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

             Bug #: 56543
           Summary: [4.7.3/4.8 Regression] ICE on valid code in
                    copy_node_stat
    Classification: Unclassified
           Product: gcc
           Version: 4.7.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: gcc@abeckmann.de


The following useless but valid piece of code causes a ICE Segfault in 4.8
(SVN) and 4.7.3 (SVN). It is accepted by 4.6.4 (SVN) and 4.7.2.

===== 8< =====
template < typename > struct S ;
template < typename T > struct U {
        typedef typename S < T > :: template V < > W ;
        S < W > x;
};
===== >8 =====


$ g++-trunk -c -v ice-segfault-copy_node_stat.cpp 
Using built-in specs.
COLLECT_GCC=/opt/software/x86_64/gcc-trunk/bin/g++-trunk
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-trunk/configure --prefix=/opt/software/x86_64/gcc-trunk
--program-suffix=-trunk --enable-languages=c,c++,fortran --enable-checking
Thread model: posix
gcc version 4.8.0 20130302 (experimental) (GCC) 
COLLECT_GCC_OPTIONS='-c' '-v' '-shared-libgcc' '-mtune=generic' '-march=x86-64'

/opt/software/x86_64/gcc-trunk/libexec/gcc/x86_64-unknown-linux-gnu/4.8.0/cc1plus
-quiet -v -imultilib . -imultiarch x86_64-linux-gnu -D_GNU_SOURCE
ice-segfault-copy_node_stat.cpp -quiet -dumpbase
ice-segfault-copy_node_stat.cpp -mtune=generic -march=x86-64 -auxbase
ice-segfault-copy_node_stat -version -o /tmp/ccZwWTct.s
GNU C++ (GCC) version 4.8.0 20130302 (experimental) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.8.0 20130302 (experimental), GMP version
5.0.5, MPFR version 3.1.0-p10, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
ignoring nonexistent directory "/usr/local/include/x86_64-linux-gnu"
ignoring nonexistent directory
"/opt/software/x86_64/gcc-trunk/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/../../../../x86_64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:

/opt/software/x86_64/gcc-trunk/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/../../../../include/c++/4.8.0

/opt/software/x86_64/gcc-trunk/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/../../../../include/c++/4.8.0/x86_64-unknown-linux-gnu/.

/opt/software/x86_64/gcc-trunk/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/../../../../include/c++/4.8.0/backward
 /opt/software/x86_64/gcc-trunk/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/include
 /usr/local/include
 /opt/software/x86_64/gcc-trunk/include

/opt/software/x86_64/gcc-trunk/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/include-fixed
 /usr/include/x86_64-linux-gnu
 /usr/include
End of search list.
GNU C++ (GCC) version 4.8.0 20130302 (experimental) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.8.0 20130302 (experimental), GMP version
5.0.5, MPFR version 3.1.0-p10, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: eedf9bce273f5c2d2f3e6a014c94ec56
ice-segfault-copy_node_stat.cpp:4:8: internal compiler error: Segmentation
fault
  S < W > x;
        ^
0xa7da8f crash_signal
        ../../gcc-trunk/gcc/toplev.c:332
0xc656bd copy_node_stat(tree_node*)
        ../../gcc-trunk/gcc/tree.c:947
0x6a1819 strip_typedefs(tree_node*)
        ../../gcc-trunk/gcc/cp/tree.c:1228
0x54b82c canonicalize_type_argument
        ../../gcc-trunk/gcc/cp/pt.c:6136
0x584e1d coerce_template_parms
        ../../gcc-trunk/gcc/cp/pt.c:6706
0x586dc8 lookup_template_class_1
        ../../gcc-trunk/gcc/cp/pt.c:7265
0x586dc8 lookup_template_class(tree_node*, tree_node*, tree_node*, tree_node*,
int, int)
        ../../gcc-trunk/gcc/cp/pt.c:7562
0x677fb2 finish_template_type(tree_node*, tree_node*, int)
        ../../gcc-trunk/gcc/cp/semantics.c:2806
0x611528 cp_parser_template_id
        ../../gcc-trunk/gcc/cp/parser.c:12710
0x6118c2 cp_parser_class_name
        ../../gcc-trunk/gcc/cp/parser.c:18109
0x606dbb cp_parser_qualifying_entity
        ../../gcc-trunk/gcc/cp/parser.c:5275
0x606dbb cp_parser_nested_name_specifier_opt
        ../../gcc-trunk/gcc/cp/parser.c:5006
0x6077db cp_parser_nested_name_specifier
        ../../gcc-trunk/gcc/cp/parser.c:5199
0x6173bb cp_parser_using_declaration
        ../../gcc-trunk/gcc/cp/parser.c:15174
0x5f9d11 cp_parser_member_declaration
        ../../gcc-trunk/gcc/cp/parser.c:19127
0x5fb036 cp_parser_member_specification_opt
        ../../gcc-trunk/gcc/cp/parser.c:18990
0x5fb036 cp_parser_class_specifier_1
        ../../gcc-trunk/gcc/cp/parser.c:18243
0x5fb036 cp_parser_class_specifier
        ../../gcc-trunk/gcc/cp/parser.c:18459
0x5fb036 cp_parser_type_specifier
        ../../gcc-trunk/gcc/cp/parser.c:13573
0x6121ed cp_parser_decl_specifier_seq
        ../../gcc-trunk/gcc/cp/parser.c:10900
Please submit a full bug report,


$ g++-4.7.x -c -v ice-segfault-copy_node_stat.cpp 
Using built-in specs.
COLLECT_GCC=/opt/software/x86_64/gcc-4.7.x/bin/g++-4.7.x
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-4_7-branch/configure
--prefix=/opt/software/x86_64/gcc-4.7.x --program-suffix=-4.7.x
--enable-languages=c,c++,fortran --enable-checking
Thread model: posix
gcc version 4.7.3 20130304 (prerelease) (GCC) 
COLLECT_GCC_OPTIONS='-c' '-v' '-shared-libgcc' '-mtune=generic' '-march=x86-64'

/opt/software/x86_64/gcc-4.7.x/libexec/gcc/x86_64-unknown-linux-gnu/4.7.3/cc1plus
-quiet -v -imultilib . -imultiarch x86_64-linux-gnu -D_GNU_SOURCE
ice-segfault-copy_node_stat.cpp -quiet -dumpbase
ice-segfault-copy_node_stat.cpp -mtune=generic -march=x86-64 -auxbase
ice-segfault-copy_node_stat -version -o /tmp/ccFlTqAG.s
GNU C++ (GCC) version 4.7.3 20130304 (prerelease) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.7.3 20130304 (prerelease), GMP version
5.0.5, MPFR version 3.1.0-p10, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
ignoring nonexistent directory "/usr/local/include/x86_64-linux-gnu"
ignoring nonexistent directory
"/opt/software/x86_64/gcc-4.7.x/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../x86_64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:

/opt/software/x86_64/gcc-4.7.x/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../include/c++/4.7.3

/opt/software/x86_64/gcc-4.7.x/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../include/c++/4.7.3/x86_64-unknown-linux-gnu/.

/opt/software/x86_64/gcc-4.7.x/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../include/c++/4.7.3/backward
 /opt/software/x86_64/gcc-4.7.x/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/include
 /usr/local/include
 /opt/software/x86_64/gcc-4.7.x/include

/opt/software/x86_64/gcc-4.7.x/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/include-fixed
 /usr/include/x86_64-linux-gnu
 /usr/include
End of search list.
GNU C++ (GCC) version 4.7.3 20130304 (prerelease) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.7.3 20130304 (prerelease), GMP version
5.0.5, MPFR version 3.1.0-p10, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 52ed9e0a10a946085ed136449fb02111
ice-segfault-copy_node_stat.cpp:4:8: internal compiler error: Segmentation
fault
Please submit a full bug report,


$ g++-4.7.2 -v -c ice-segfault-copy_node_stat.cpp
Using built-in specs.
COLLECT_GCC=/opt/software/x86_64/gcc-4.7.2/bin/g++-4.7.2
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-4.7.2/configure --prefix=/opt/software/x86_64/gcc-4.7.2
--program-suffix=-4.7.2 --enable-languages=c,c++,fortran --enable-checking
Thread model: posix
gcc version 4.7.2 (GCC) 
COLLECT_GCC_OPTIONS='-v' '-c' '-shared-libgcc' '-mtune=generic' '-march=x86-64'

/opt/software/x86_64/gcc-4.7.2/libexec/gcc/x86_64-unknown-linux-gnu/4.7.2/cc1plus
-quiet -v -imultilib . -imultiarch x86_64-linux-gnu -D_GNU_SOURCE
ice-segfault-copy_node_stat.cpp -quiet -dumpbase
ice-segfault-copy_node_stat.cpp -mtune=generic -march=x86-64 -auxbase
ice-segfault-copy_node_stat -version -o /tmp/ccgUf6nF.s
GNU C++ (GCC) version 4.7.2 (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.7.2, GMP version 5.0.5, MPFR version
3.1.0-p10, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
ignoring nonexistent directory "/usr/local/include/x86_64-linux-gnu"
ignoring nonexistent directory
"/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../x86_64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:

/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2

/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/x86_64-unknown-linux-gnu/.

/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/backward
 /opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/include
 /usr/local/include
 /opt/software/x86_64/gcc-4.7.2/include

/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/include-fixed
 /usr/include/x86_64-linux-gnu
 /usr/include
End of search list.
GNU C++ (GCC) version 4.7.2 (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.7.2, GMP version 5.0.5, MPFR version
3.1.0-p10, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: cc1c0902ebb852228365f0297d9b51e8
COLLECT_GCC_OPTIONS='-v' '-c' '-shared-libgcc' '-mtune=generic' '-march=x86-64'
 as -v --64 -o ice-segfault-copy_node_stat.o /tmp/ccgUf6nF.s
GNU assembler version 2.22 (x86_64-linux-gnu) using BFD version (GNU Binutils
for Debian) 2.22
COMPILER_PATH=/opt/software/x86_64/gcc-4.7.2/libexec/gcc/x86_64-unknown-linux-gnu/4.7.2/:/opt/software/x86_64/gcc-4.7.2/libexec/gcc/x86_64-unknown-linux-gnu/4.7.2/:/opt/software/x86_64/gcc-4.7.2/libexec/gcc/x86_64-unknown-linux-gnu/:/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/:/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/
LIBRARY_PATH=/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/:/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../lib64/:/lib/x86_64-linux-gnu/:/lib/../lib64/:/usr/lib/x86_64-linux-gnu/:/opt/software/x86_64/gcc-4.7.2/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../:/lib/:/usr/lib/
COLLECT_GCC_OPTIONS='-v' '-c' '-shared-libgcc' '-mtune=generic' '-march=x86-64'
$ echo $?
0


$ g++-4.6.x -W -Wall -c ice-segfault-copy_node_stat.cpp ; echo $?
0

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-03-05
   Target Milestone|---                         |4.7.3
            Summary|[4.7.3/4.8 Regression] ICE  |[4.7/4.8 Regression] ICE on
                   |on valid code in            |valid code in
                   |copy_node_stat              |copy_node_stat
     Ever Confirmed|0                           |1

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-03-05 19:19:26 UTC ---
Confirmed.

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |jason at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-06 07:45:02 UTC ---
Started with http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196228 aka
PR56395.

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> 2013-03-06 08:57:12 UTC ---
Regression on the branch, P1.

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> 2013-03-06 11:06:40 UTC ---
We're calling copy_node on the second argument of
 <template_id_expr 0x7fd794756190
    arg 0 <identifier_node 0x7fd794755c60 V
        bindings <(nil)>
        local bindings <(nil)>>
    d.C:3:48>
but there isn't such an argument at all.  Oops.

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-06 11:13:23 UTC ---
   The second is NULL if there are no explicit arguments, or a
   TREE_VEC of arguments.

Thus, perhaps:

-        if (TREE_CODE (fullname) == TEMPLATE_ID_EXPR)
+        if (TREE_CODE (fullname) == TEMPLATE_ID_EXPR
+            && TREE_OPERAND (fullname, 1))

?

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> 2013-03-06 14:28:15 UTC ---
(In reply to comment #5)
> -        if (TREE_CODE (fullname) == TEMPLATE_ID_EXPR)
> +        if (TREE_CODE (fullname) == TEMPLATE_ID_EXPR
> +            && TREE_OPERAND (fullname, 1))

OK.

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-06 14:31:01 UTC ---
Created attachment 29597
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29597
gcc48-pr56543.patch

Thanks.  This has been already bootstrapped in the mean time, regtest still
pending (but, as it is unconditional ICE before, I don't see how it could
change anything on any testcase that hasn't been ICEing before).

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-06 15:19:17 UTC ---
Author: jakub
Date: Wed Mar  6 15:19:11 2013
New Revision: 196491

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196491
Log:
    PR c++/56543
    * tree.c (strip_typedefs): Don't copy args if they are NULL.

    * g++.dg/template/typename20.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/template/typename20.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/tree.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-06 15:27:25 UTC ---
Author: jakub
Date: Wed Mar  6 15:27:13 2013
New Revision: 196492

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196492
Log:
    PR c++/56543
    * tree.c (strip_typedefs): Don't copy args if they are NULL.

    * g++.dg/template/typename20.C: New test.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/template/typename20.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/ChangeLog
    branches/gcc-4_7-branch/gcc/cp/tree.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug c++/56543] [4.7/4.8 Regression] ICE on valid code in copy_node_stat

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56543

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-06 15:32:50 UTC ---
Fixed.