public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/56556] Wshadow warns for private members in base classes
Date: Fri, 04 Feb 2022 11:08:37 +0000	[thread overview]
Message-ID: <bug-56556-4-D7SCFIPgvp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-56556-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56556

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|RESOLVED                    |NEW
         Resolution|INVALID                     |---
   Last reconfirmed|                            |2022-02-04
           Severity|normal                      |enhancement
           Keywords|                            |diagnostic

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The problem with -Wshadow=local is that it doesn't warn about this either:

class Derived {
        int x;
        Derived(int x) {}
};

And you might want a warning there, just not for the case where 'x' is a
private member in some base.

I think I agree with David that this shouldn't warn in the first place, you
shouldn't need to work around it.

I understand Andrew's explanation, but that's the reason GCC behaves like this
today, not a reason it *should* behave like this.

  parent reply	other threads:[~2022-02-04 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07  0:44 [Bug c++/56556] New: " david at doublewise dot net
2013-03-07  0:46 ` [Bug c++/56556] " pinskia at gcc dot gnu.org
2022-02-04 11:08 ` redi at gcc dot gnu.org [this message]
2024-05-11 14:34 ` trash.paradise at protonmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-56556-4-D7SCFIPgvp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).