public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ebotcazou at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/56560] [4.6/4.7 regression] vzeroupper clobbers argument with AVX
Date: Tue, 12 Mar 2013 11:37:00 -0000	[thread overview]
Message-ID: <bug-56560-4-x50VwOazHM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-56560-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56560

--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2013-03-12 11:37:27 UTC ---
> This patch adds expand_args to track library calls to
> expend arguments.  We add vzeroupper when expand_args == 1,
> which indicates we are expanding the actual function.

This looks complicated.  A simpler approach could be to record the AVX state in
the CUMULATIVE_ARGS structure and transfer it to cfun->machine only at the end
of the argument processing.  Comments and code in calls.c appear to guarantee
that

  targetm.calls.function_arg (&args_so_far, VOIDmode, void_type_node, true)

is invoked immediately before the call instruction is emitted.


  parent reply	other threads:[~2013-03-12 11:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07  9:48 [Bug target/56560] New: [4.7 " ebotcazou at gcc dot gnu.org
2013-03-07 10:10 ` [Bug target/56560] [4.6/4.7 " rguenth at gcc dot gnu.org
2013-03-07 10:18 ` ebotcazou at gcc dot gnu.org
2013-03-08  9:24 ` ubizjak at gmail dot com
2013-03-08 17:23 ` hjl.tools at gmail dot com
2013-03-10 15:51 ` ebotcazou at gcc dot gnu.org
2013-03-11 19:35 ` hjl.tools at gmail dot com
2013-03-12 11:37 ` ebotcazou at gcc dot gnu.org [this message]
2013-03-12 16:49 ` hjl.tools at gmail dot com
2013-03-12 17:08 ` ebotcazou at gcc dot gnu.org
2013-04-03 10:14 ` rguenth at gcc dot gnu.org
2013-04-12 15:18 ` [Bug target/56560] [4.7 " jakub at gcc dot gnu.org
2013-05-06 14:42 ` ebotcazou at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-56560-4-x50VwOazHM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).