[Bug c/56724] sub-optimal location in error

["mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56724

--- Comment #9 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #5)
> I tried this today with a recent-ish gcc trunk build, and
> there's been a regression.
> 
> Now:
> 
> barimba. gcc --syntax-only r.c
> r.c: In function ‘docall’:
> r.c:7:10: warning: passing argument 3 of ‘callf’ from incompatible pointer
> type
>    return callf (23, 72,
>           ^
> r.c:3:5: note: expected ‘int (*)(double *)’ but argument is of type ‘int
> (*)(int *)’
>  int callf (int, int, int (*)(double *));
>      ^
> 
> 
> Note how the first warning now points to "callf", whereas
> in comment #0 it pointed to the actual argument causing the diagnostic.
> 
> The new situation is much worse for me as it prevents automated
> rewriting...

That is not a regression; previously it didn't point to the actual argument,
but it used input_location, so it pointed to the start of the line.  In the
previous testcase it only looks like it's pointing to the last argument.  E.g.
on this
int f (int *);

int callf (int, int, int (*)(double *));

int docall(void)
{
  return callf (23,
  72, f);
}

it will point to "72".

I hope I will have the cycles to look into this this week.
>From gcc-bugs-return-451957-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon May 19 18:52:01 2014
Return-Path: <gcc-bugs-return-451957-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6582 invoked by alias); 19 May 2014 18:52:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6531 invoked by uid 48); 19 May 2014 18:51:56 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/61220] [4.10 Regression] ICE on valid code at -O2 on x86_64-linux-gnu in maybe_record_trace_start, at dwarf2cfi.c:2239
Date: Mon, 19 May 2014 18:52:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc short_desc
Message-ID: <bug-61220-4-Mu6diXChXD@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61220-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61220-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01649.txt.bz2
Content-length: 828

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida220

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |zqchen at gcc dot gnu.org
            Summary|ICE on valid code at -O2 on |[4.10 Regression] ICE on
                   |x86_64-linux-gnu in         |valid code at -O2 on
                   |maybe_record_trace_start,   |x86_64-linux-gnu in
                   |at dwarf2cfi.c:2239         |maybe_record_trace_start,
                   |                            |at dwarf2cfi.c:2239

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Caused by r210457.