[Bug c/56724] sub-optimal location in error

["tromey at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56724

--- Comment #12 from Tom Tromey <tromey at gcc dot gnu.org> ---
I noticed this patch today and tried it out on my current
test case, which uses -Wc++-compat... unfortunately it
still fails.

Test code:

extern void xfer (int, int, unsigned char *);

void call (int x, int y, void *arg)
{
  xfer (x, y, arg);
}


barimba. gcc --syntax-only -Wc++-compat /tmp/r.c
/tmp/r.c: In function ‘call’:
/tmp/r.c:5:3: warning: request for implicit conversion from ‘void *’ to
‘unsigned char *’ not permitted in C++ [-Wc++-compat]
   xfer (x, y, arg);
   ^


I think perhaps the problem is that the warning_at call in
convert_for_assignment that emits this warning should use
expr_loc rather than 'location'.  I haven't tested this theory.
>From gcc-bugs-return-453247-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jun 05 03:32:46 2014
Return-Path: <gcc-bugs-return-453247-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 27348 invoked by alias); 5 Jun 2014 03:32:45 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 27292 invoked by uid 48); 5 Jun 2014 03:32:39 -0000
From: "amker.cheng at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61411] [NEON] ICE in reload_cse_simplify_operands, at postreload.c:411
Date: Thu, 05 Jun 2014 03:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: amker.cheng at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61411-4-dLCWOHBm5K@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61411-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61411-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00329.txt.bz2
Content-length: 912

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida411

bin.cheng <amker.cheng at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amker.cheng at gmail dot com,
                   |                            |mshawcroft at gcc dot gnu.org,
                   |                            |vmakarov at gcc dot gnu.org

--- Comment #1 from bin.cheng <amker.cheng at gmail dot com> ---
The patch can fix the issue, but problem is why GCC/lra generated
register-indexing ([reg+reg]) addressing mode for V8HImode in the first place.
Since without this patch, the address expression is illegal and shouldn't be
generated.  I didn't look into LRA's code and am not very sure whether this
patch is covering the problem.

Also added Marcus and Vlad to the CC list.