public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ktietz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/56742] Optimization bug lead to uncaught throw
Date: Wed, 27 Mar 2013 09:40:00 -0000 [thread overview]
Message-ID: <bug-56742-4-7Sn1sVtLQ5@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-56742-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56742
--- Comment #4 from Kai Tietz <ktietz at gcc dot gnu.org> 2013-03-27 09:40:16 UTC ---
(In reply to comment #3)
> (In reply to comment #2)
> > Hmm, yes indeed it is the -freorder-blocks option. One solution is to
> > disallow after reload for SEH-target to modify jumps.
>
> That's an awfully big hammer. Perhaps it's possible to first analyze
> what is actually happening in bbreorder that causes this bug?
Well, the issue is analyzed. The issue is that SEH is table-based EH, and so
after bb-reorder used labels for describing eh-regions are getting invalid.
If you take a look to the produces assembly for the example, you will notice
that easily.
I admit that the first patch is a bit too invasive, as it disables bb-reorder
in all cases. But in fact we need to disable it just if there is a
catch-region. A more improved variant is:
Index: i386.c
===================================================================
--- i386.c (Revision 197118)
+++ i386.c (Arbeitskopie)
@@ -3941,6 +3941,20 @@
register_pass (&insert_vzeroupper_info);
}
+/* Implement TARGET_CANNOT_MODIFY_JUMPS_P. */
+static bool
+ix86_cannot_modify_jumps_p (void)
+{
+ if (TARGET_SEH && reload_completed
+ && cfun && cfun->eh
+ && cfun->eh->region_tree)
+ return true;
+ return false;
+}
+
+#undef TARGET_CANNOT_MODIFY_JUMPS_P
+#define TARGET_CANNOT_MODIFY_JUMPS_P ix86_cannot_modify_jumps_p
+
/* Update register usage after having seen the compiler flags. */
static void
next prev parent reply other threads:[~2013-03-27 9:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 15:56 [Bug c++/56742] New: " ktietz at gcc dot gnu.org
2013-03-26 15:59 ` [Bug c++/56742] " ktietz at gcc dot gnu.org
2013-03-26 20:11 ` pinskia at gcc dot gnu.org
2013-03-26 21:14 ` ktietz at gcc dot gnu.org
2013-03-26 23:43 ` steven at gcc dot gnu.org
2013-03-27 9:40 ` ktietz at gcc dot gnu.org [this message]
2013-03-27 13:48 ` [Bug rtl-optimization/56742] " jason at gcc dot gnu.org
2013-03-27 14:43 ` ktietz at gcc dot gnu.org
2013-03-27 14:50 ` [Bug rtl-optimization/56742] [4.8 regression] " ktietz at gcc dot gnu.org
2013-04-26 18:16 ` jakub at gcc dot gnu.org
2013-05-22 20:54 ` [Bug rtl-optimization/56742] [4.8/4.9 " rth at gcc dot gnu.org
2013-05-22 20:55 ` rth at gcc dot gnu.org
2013-05-22 20:57 ` rth at gcc dot gnu.org
2013-05-22 23:19 ` rth at gcc dot gnu.org
2013-05-31 23:18 ` rth at gcc dot gnu.org
2014-01-14 21:15 ` g63marty at yahoo dot com
2014-01-14 21:20 ` g63marty at yahoo dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-56742-4-7Sn1sVtLQ5@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).