[Bug rtl-optimization/56847] New: '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[Bug rtl-optimization/56847] New: '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[shenhan at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

             Bug #: 56847
           Summary: '-fpie' triggers - internal compiler error: in
                    gen_add2_insn, at optabs.c:4705
    Classification: Unclassified
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: shenhan@google.com


System - Ubuntu 12.04 64 bit.
GCC configuration - configure --disable-bootstrap --enable-languages='c,c++'
How to reproduce - 
 gcc -fpie -c -O2 case.c

Error message I got -

case.c: In function ‘get_clock’:
case.c:20:1: internal compiler error: in gen_add2_insn, at optabs.c:4705
 }
 ^
0x735e4b gen_add2_insn(rtx_def*, rtx_def*)
        ../../gcc.svn/gcc-4_8-branch/gcc/optabs.c:4705
0x7037f5 lra_emit_add(rtx_def*, rtx_def*, rtx_def*)
        ../../gcc.svn/gcc-4_8-branch/gcc/lra.c:313
0x7119a5 curr_insn_transform
        ../../gcc.svn/gcc-4_8-branch/gcc/lra-constraints.c:3082
0x712224 lra_constraints(bool)
        ../../gcc.svn/gcc-4_8-branch/gcc/lra-constraints.c:3613
0x705a2a lra(_IO_FILE*)
        ../../gcc.svn/gcc-4_8-branch/gcc/lra.c:2278
0x6d0820 do_reload
        ../../gcc.svn/gcc-4_8-branch/gcc/ira.c:4619
0x6d0820 rest_of_handle_reload
        ../../gcc.svn/gcc-4_8-branch/gcc/ira.c:4731
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-419312-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 04 23:31:07 2013
Return-Path: <gcc-bugs-return-419312-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9532 invoked by alias); 4 Apr 2013 23:31:07 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9502 invoked by uid 48); 4 Apr 2013 23:31:02 -0000
From: "shenhan at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/56847] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705
Date: Thu, 04 Apr 2013 23:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: shenhan at google dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-56847-4-Jic1twBwyr@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56847-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56847-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg00457.txt.bz2
Content-length: 237


http://gcc.gnu.org/bugzilla/show_bug.cgi?idV847

--- Comment #1 from Han Shen <shenhan at google dot com> 2013-04-04 23:31:02 UTC ---
Created attachment 29807
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id)807
test case

[Bug rtl-optimization/56847] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug rtl-optimization/56847] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-04-05
                 CC|                            |mpolacek at gcc dot gnu.org
          Component|target                      |rtl-optimization
     Ever Confirmed|0                           |1

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> 2013-04-05 05:07:20 UTC ---
Confirmed.

[Bug target/56847] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> 2013-04-05 05:28:21 UTC ---
Slightly reduced.
struct S { long int a, b; };
extern struct S e;

void
foo (void)
{
  static __thread struct S s = { 0, 0 };
  s = e;
}

[Bug target/56847] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uros at gcc dot gnu.org

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> 2013-04-05 05:54:31 UTC ---
Started with http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=193671

[Bug target/56847] [4.8/4.9 Regression] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |vmakarov at gcc dot gnu.org
   Target Milestone|4.9.0                       |4.8.1
            Summary|'-fpie' triggers - internal |[4.8/4.9 Regression]
                   |compiler error: in          |'-fpie' triggers - internal
                   |gen_add2_insn, at           |compiler error: in
                   |optabs.c:4705               |gen_add2_insn, at
                   |                            |optabs.c:4705

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-05 06:11:37 UTC ---
Even more reduced:
/* PR target/56847 */
/* { dg-do compile { target pie } } */
/* { dg-options "-O2 -fpie" } */

struct S { long int a, b; } e;
__thread struct S s;

void
foo (void)
{
  s = e;
}

[Bug rtl-optimization/56847] [4.8/4.9 Regression] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ra
          Component|target                      |rtl-optimization

--- Comment #6 from Uros Bizjak <ubizjak at gmail dot com> 2013-04-05 06:13:56 UTC ---
The target part exposes underlying LRA problem.

[Bug rtl-optimization/56847] [4.8/4.9 Regression] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[vmakarov at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Vladimir Makarov <vmakarov at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at redhat dot com

--- Comment #7 from Vladimir Makarov <vmakarov at redhat dot com> 2013-04-06 03:43:50 UTC ---
  It seems that reload systematically chooses a different alternative (4) than
LRA (1) for movti_internal.  This is a very tricky part of LRA so I guess
fixing this can take a few days may be a week.

[Bug rtl-optimization/56847] [4.8/4.9 Regression] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[shenhan at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

--- Comment #8 from Han Shen <shenhan at google dot com> 2013-04-17 23:42:22 UTC ---
Hi, any progress on this?

Thanks!

[Bug rtl-optimization/56847] [4.8/4.9 Regression] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[vmakarov at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

--- Comment #9 from Vladimir Makarov <vmakarov at redhat dot com> 2013-04-18 20:10:34 UTC ---
I am still working on this.  I have a patch solving the problem but I'd like to
try other solutions too.

[Bug rtl-optimization/56847] [4.8 Regression] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.8/4.9 Regression]        |[4.8 Regression] '-fpie'
                   |'-fpie' triggers - internal |triggers - internal
                   |compiler error: in          |compiler error: in
                   |gen_add2_insn, at           |gen_add2_insn, at
                   |optabs.c:4705               |optabs.c:4705

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-26 18:08:31 UTC ---
Author: vmakarov
Date: Fri Apr 19 19:55:57 2013
New Revision: 198101

URL: http://gcc.gnu.org/viewcvs?rev=198101&root=gcc&view=rev
Log:
2013-04-19  Vladimir Makarov  <vmakarov@redhat.com>

    PR rtl-optimization/56847
    * lra-constraints.c (process_alt_operands): Discourage alternative
    with non-matche doffsettable memory constraint fro memory with
    known offset.


Added:
    trunk/gcc/testsuite/gcc.dg/pr56847.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lra-constraints.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/56847] [4.8 Regression] '-fpie' triggers - internal compiler error: in gen_add2_insn, at optabs.c:4705

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56847

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-05-02 19:31:50 UTC ---
Author: vmakarov
Date: Thu May  2 17:41:53 2013
New Revision: 198553

URL: http://gcc.gnu.org/viewcvs?rev=198553&root=gcc&view=rev
Log:
2013-05-02  Vladimir Makarov  <vmakarov@redhat.com>

    Backport from mainline
    2013-04-19  Vladimir Makarov  <vmakarov@redhat.com>

        PR rtl-optimization/56847
        * lra-constraints.c (process_alt_operands): Discourage alternative
        with non-matche doffsettable memory constraint fro memory with
        known offset.

2013-05-02  Vladimir Makarov  <vmakarov@redhat.com>

    Backport from mainline
    2013-04-19  Vladimir Makarov  <vmakarov@redhat.com>

        PR rtl-optimization/56847
        * gcc.dg/pr56847.c: New test.


Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/pr56847.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/lra-constraints.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog