From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14654 invoked by alias); 18 Apr 2013 09:18:21 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 14606 invoked by uid 48); 18 Apr 2013 09:18:17 -0000 From: "abel at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/56957] [4.9 regression] ICE in add_insn_after, at emit-rtl.c:3783 Date: Thu, 18 Apr 2013 09:18:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: rtl-optimization X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: abel at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: abel at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.9.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-SW-Source: 2013-04/txt/msg01668.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56957 --- Comment #7 from Andrey Belevantsev 2013-04-18 09:18:17 UTC --- (In reply to comment #6) > (In reply to comment #5) > > Created attachment 29886 [details] > > proposed patch > > You should probably make this a static inline function and add a comment > with a rationale ;-) Actually I've made the full-blown function, the reason being that I forgot that we keep the history vector sorted, so it's not enough to check only the last element, you'd need to check all of them. Took some time from digging this from Itanium slow testing though :-) I will add a comment, sure.