From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-420435-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28883 invoked by alias); 17 Apr 2013 06:52:51 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 28846 invoked by uid 48); 17 Apr 2013 06:52:48 -0000
From: "abel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/56957] [4.9 regression] ICE in add_insn_after, at emit-rtl.c:3783
Date: Wed, 17 Apr 2013 06:52:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: abel at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: abel at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Changed-Fields: Status AssignedTo
Message-ID: <bug-56957-4-upauhbJIUT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56957-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56957-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01580.txt.bz2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56957

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |abel at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #5 from Andrey Belevantsev <abel at gcc dot gnu.org> 2013-04-17 06:52:47 UTC ---
Created attachment 29886
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29886
proposed patch

Easy enough, we can have a speculation transformation that does not change insn
at all (e.g. we're asked to speculate an insn already speculated, so we just
changed the speculation probability, not the pattern itself), but
EXPR_WAS_CHANGED only tests that the transformation history vector is
non-empty, so it would report changes have actually happened.  So checking
additionally that the oldest insn form (last vector element) has the same
INSN_ID as the one of the current expr fixes the test.  I will throw this to
our Itanium for the full testing.

Steven, thanks for your insn emitting patches.  It was not that easy to catch
that kind of issues earlier, AFAIR we noticed it via corruption of our own
structures and we needed to trace that back to the offending move....