[Bug c/56980] Misleading note

[Bug c/56980] Misleading note

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:24:46 UTC ---
Confirmed, but I seriously doubt it has anything to do with my patch. At the
moment of warning we get:

(gdb) p debug_tree(type)
 <pointer_type 0x7ffff7511540
    type <record_type 0x7ffff7511498 B type_0 SI
        size <integer_cst 0x7ffff740f0c0 constant 32>
        unit size <integer_cst 0x7ffff740f0e0 constant 4>
        align 32 symtab 0 alias set -1 canonical type 0x7ffff75113f0
        fields <field_decl 0x7ffff74195f0 i type <integer_type 0x7ffff740c5e8
int>
            SI file /home/manuel/pr56980.c line 1 col 24 size <integer_cst
0x7ffff740f0c0 32> unit size <integer_cst 0x7ffff740f0e0 4>
            align 32 offset_align 128
            offset <integer_cst 0x7ffff73f7d80 constant 0>
            bit offset <integer_cst 0x7ffff73f7e00 constant 0> context
<record_type 0x7ffff75113f0 A>>
        pointer_to_this <pointer_type 0x7ffff7511540> chain <type_decl
0x7ffff752a000 D.1714>>
    unsigned DI
    size <integer_cst 0x7ffff73f7d40 type <integer_type 0x7ffff740c0a8
bitsizetype> constant 64>
    unit size <integer_cst 0x7ffff73f7d60 type <integer_type 0x7ffff740c000
sizetype> constant 8>
    align 64 symtab 0 alias set -1 canonical type 0x7ffff75115e8>
$9 = void
(gdb) p debug_tree(rhstype)
 <pointer_type 0x7ffff75119d8
    type <record_type 0x7ffff7511930 B VOID
        align 8 symtab 0 alias set -1 canonical type 0x7ffff7511930 context
<function_decl 0x7ffff7510a00 bar>
        pointer_to_this <pointer_type 0x7ffff75119d8> chain <type_decl
0x7ffff752a170 D.1722>>
    unsigned DI
    size <integer_cst 0x7ffff73f7d40 type <integer_type 0x7ffff740c0a8
bitsizetype> constant 64>
    unit size <integer_cst 0x7ffff73f7d60 type <integer_type 0x7ffff740c000
sizetype> constant 8>
    align 64 symtab 0 alias set -1 canonical type 0x7ffff75119d8>

which seem correct to me, so the pretty-printer is printing the wrong thing and
not unwrapping the typedef as it should.
>From gcc-bugs-return-420399-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:26:01 2013
Return-Path: <gcc-bugs-return-420399-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21974 invoked by alias); 16 Apr 2013 15:26:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21946 invoked by uid 48); 16 Apr 2013 15:25:58 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/56980] Misleading note
Date: Tue, 16 Apr 2013 15:26:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Status Last reconfirmed Ever Confirmed
Message-ID: <bug-56980-4-GSzBLajgYG@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56980-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56980-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01544.txt.bz2
Content-length: 1130


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-04-16
     Ever Confirmed|0                           |1

--- Comment #2 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:25:58 UTC ---
I think I have seen similar bugs in the pretty-printer with typedefs.

BTW, Clang gets it perfect:

pr56980.c:6:8: warning: incompatible pointer types passing 'struct B *' to
parameter of type 'B *' (aka 'struct A *') [-Wincompatible-pointer-types]
  foo ((struct B *) x);
       ^~~~~~~~~~~~~~
pr56980.c:2:14: note: passing argument to parameter here
void foo (B *);
             ^
pr56980.c:11:7: warning: incompatible pointer types initializing 'B *' (aka
'struct A *') with an expression of type 'struct B *'
[-Wincompatible-pointer-types]
  B * y = (struct B *) x;
      ^   ~~~~~~~~~~~~~~
>From gcc-bugs-return-420400-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:33:19 2013
Return-Path: <gcc-bugs-return-420400-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25454 invoked by alias); 16 Apr 2013 15:33:19 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25423 invoked by uid 48); 16 Apr 2013 15:33:16 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/56980] Misleading note
Date: Tue, 16 Apr 2013 15:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Keywords
Message-ID: <bug-56980-4-xrSoilalrH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56980-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56980-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01545.txt.bz2
Content-length: 724


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic

--- Comment #3 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:33:16 UTC ---
void baz (B *x)
{
  int y = x >> x;
}

/home/manuel/pr56980.c:11:13: error: invalid operands to binary >> (have
‘struct B *’ and ‘struct B *’)
   int y = x >> x;
             ^

The C pretty-printer cannot deal correctly with pointers to typedefs of
structs.
>From gcc-bugs-return-420401-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:34:59 2013
Return-Path: <gcc-bugs-return-420401-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 27140 invoked by alias); 16 Apr 2013 15:34:59 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 27095 invoked by uid 48); 16 Apr 2013 15:34:56 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/56980] Misleading note
Date: Tue, 16 Apr 2013 15:34:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-56980-4-YkKa4Jo4qn@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56980-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56980-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01546.txt.bz2
Content-length: 393


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:34:56 UTC ---
while the C++ pretty-printer can:

pr56980.c:4:16: error: invalid operands of types ‘B* {aka A*}’ and ‘B* {aka
A*}’ to binary ‘operator>>’
   int y = x >> x;
                ^
>From gcc-bugs-return-420404-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:41:54 2013
Return-Path: <gcc-bugs-return-420404-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31744 invoked by alias); 16 Apr 2013 15:41:54 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31692 invoked by uid 48); 16 Apr 2013 15:41:51 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/52825] incorrect message for "incompatible pointer type" with extra "struct" for a typedeffed struct
Date: Tue, 16 Apr 2013 15:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Keywords:
X-Bugzilla-Severity: minor
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Status CC Resolution
Message-ID: <bug-52825-4-Ifzl1dC8IT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-52825-4@http.gcc.gnu.org/bugzilla/>
References: <bug-52825-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01549.txt.bz2
Content-length: 625


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52825

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |manu at gcc dot gnu.org
         Resolution|                            |DUPLICATE

--- Comment #2 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:41:51 UTC ---
Dup

*** This bug has been marked as a duplicate of bug 56980 ***
>From gcc-bugs-return-420403-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:41:41 2013
Return-Path: <gcc-bugs-return-420403-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31064 invoked by alias); 16 Apr 2013 15:41:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31029 invoked by uid 48); 16 Apr 2013 15:41:38 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/48778] gcc 4.6 -Waddress adds unhelpful new warning case when using from a macro
Date: Tue, 16 Apr 2013 15:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: minor
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: CC
Message-ID: <bug-48778-4-xTErLGEZO7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-48778-4@http.gcc.gnu.org/bugzilla/>
References: <bug-48778-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01548.txt.bz2
Content-length: 544


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48778

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #2 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:41:37 UTC ---
We have the capability to do this now since GCC 4.7, but someone needs to
implement it for this case.
>From gcc-bugs-return-420402-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:41:10 2013
Return-Path: <gcc-bugs-return-420402-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30337 invoked by alias); 16 Apr 2013 15:41:10 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30299 invoked by uid 48); 16 Apr 2013 15:41:07 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/56756] [4.9 Regression] ICE: verify_ssa failed (definition in block n follows the use !)
Date: Tue, 16 Apr 2013 15:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Changed-Fields: Status Resolution
Message-ID: <bug-56756-4-M8qGp9f1zS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56756-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56756-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01547.txt.bz2
Content-length: 1178


http://gcc.gnu.org/bugzilla/show_bug.cgi?idV756

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> 2013-04-16 15:41:05 UTC ---
Author: rguenth
Date: Tue Apr 16 15:32:26 2013
New Revision: 198001

URL: http://gcc.gnu.org/viewcvs?rev\x198001&root=gcc&view=rev
Log:
2013-04-16  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/56756
    * tree-ssa-loop-im.c (struct first_mem_ref_loc_1): New functor.
    (first_mem_ref_loc): New.
    (execute_sm): Place the load temporarily before a previous
    access instead of in the latch edge to ensure its SSA dependencies
    are defined at points dominating the load.

    * gcc.dg/torture/pr56756.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr56756.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-loop-im.c

[Bug c/56980] Misleading note

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guest at mailinator dot com

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:41:51 UTC ---
*** Bug 52825 has been marked as a duplicate of this bug. ***
>From gcc-bugs-return-420406-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:46:34 2013
Return-Path: <gcc-bugs-return-420406-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 11085 invoked by alias); 16 Apr 2013 15:46:34 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10863 invoked by uid 48); 16 Apr 2013 15:46:31 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/53822] Diagnostic: spell out type in ambiguous call
Date: Tue, 16 Apr 2013 15:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Status Last reconfirmed CC Ever Confirmed
Message-ID: <bug-53822-4-mLOfkoWEdo@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-53822-4@http.gcc.gnu.org/bugzilla/>
References: <bug-53822-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01551.txt.bz2
Content-length: 692


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53822

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-04-16
                 CC|                            |manu at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #2 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2013-04-16 15:46:30 UTC ---
We could say something like 'f(NT&) with [NT = unsigned]' like we do for
templates.
>From gcc-bugs-return-420407-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 16 15:46:47 2013
Return-Path: <gcc-bugs-return-420407-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12041 invoked by alias); 16 Apr 2013 15:46:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 11819 invoked by uid 48); 16 Apr 2013 15:46:44 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/56982] [4.8/4.9 Regression] Bad optimization with setjmp()
Date: Tue, 16 Apr 2013 15:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.1
X-Bugzilla-Changed-Fields: Status Last reconfirmed CC Target Milestone Summary Ever Confirmed
Message-ID: <bug-56982-4-QlawDkxznk@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56982-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56982-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-SW-Source: 2013-04/txt/msg01552.txt.bz2
Content-length: 1524


http://gcc.gnu.org/bugzilla/show_bug.cgi?idV982

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-04-16
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.8.1
            Summary|Bad optimization with       |[4.8/4.9 Regression] Bad
                   |setjmp()                    |optimization with setjmp()
     Ever Confirmed|0                           |1

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-16 15:46:43 UTC ---
Also happens with -Os.  Started with http://gcc.gnu.org/r190284
Eyeballing the difference between r190283 and r190284 -Os dumps, I see that
*.copyrename4 is still the same appart from losing some SSA_NAME_VARs, but
*.uncprop has one difference:
-  # n_13 = PHI <0(5), 1(6)>
+  # _13 = PHI <_3(5), 1(6)>

The missing n is fine, but _3 instead of 0 there supposedly isn't.
_3 is set before the setjmp call, while this PHI is after the returns-twice
function, and while for non-zero _3 the code before setjmp exits early, so _3
should contain 0, perhaps while extending the lifetime of _3 over the returns
twice function it should have added SSA_NAME_OCCURS_IN_ABNORMAL_PHI or give up
on it.  Richard, can you please have a look?

[Bug c/56980] C pretty-printer does not handle well pointer to typedef of struct

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
This patch seems to fix it, but I haven't tested it.

--- gcc/c-family/c-pretty-print.c
+++ gcc/c-family/c-pretty-print.c
@@ -416,7 +416,9 @@ c_pretty_printer::simple_type_specifier (tree t)
     case UNION_TYPE:
     case RECORD_TYPE:
     case ENUMERAL_TYPE:
-      if (code == UNION_TYPE)
+      if (TYPE_NAME (t) && TREE_CODE (TYPE_NAME (t)) == TYPE_DECL)
+        ;
+      else if (code == UNION_TYPE)
        pp_c_ws_string (this, "union");
       else if (code == RECORD_TYPE)
        pp_c_ws_string (this, "struct");

[Bug c/56980] C pretty-printer does not handle well pointer to typedef of struct

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu.org

--- Comment #8 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
*** Bug 61416 has been marked as a duplicate of this bug. ***

[Bug c/56980] C pretty-printer does not handle well pointer to typedef of struct

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

--- Comment #9 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Fri Oct 24 16:29:56 2014
New Revision: 216674

URL: https://gcc.gnu.org/viewcvs?rev=216674&root=gcc&view=rev
Log:
    PR c/56980
    * c-pretty-print.c (c_pretty_printer::simple_type_specifier): Don't
    print "struct"/"union"/"enum" for typedefed names.

    * gcc.dg/pr56980.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr56980.c
Modified:
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-pretty-print.c
    trunk/gcc/testsuite/ChangeLog

[Bug c/56980] C pretty-printer does not handle well pointer to typedef of struct

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56980

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Should be fixed.