[Bug bootstrap/57028] New: [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[Bug bootstrap/57028] New: [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

             Bug #: 57028
           Summary: [4.9 regression] Fortran bootstrap fails due to
                    missing zlib.h
    Classification: Unclassified
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: mikpe@it.uu.se


Attempting to bootstrap gcc-4.9-20130421 on x86_64-linux (Fedora 17) w/ Fortran
enabled but no zlib-devel package installed results in:

/mnt/scratch/objdir49/./prev-gcc/xg++ -B/mnt/scratch/objdir49/./prev-gcc/
-B/mnt/scratch/install49/x86_64-unknown-linux-gnu/bin/ -nostdinc++
-B/mnt/scratch/objdir49/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs
-B/mnt/scratch/objdir49/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-I/mnt/scratch/objdir49/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu
-I/mnt/scratch/objdir49/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include
-I/mnt/scratch/gcc-4.9-20130421/libstdc++-v3/libsupc++
-L/mnt/scratch/objdir49/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/mnt/scratch/objdir49/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-c  -DIN_GCC_FRONTEND -g -O2 -gtoggle -DIN_GCC   -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Werror   -DHAVE_CONFIG_H -I.
-Ifortran -I/mnt/scratch/gcc-4.9-20130421/gcc
-I/mnt/scratch/gcc-4.9-20130421/gcc/fortran
-I/mnt/scratch/gcc-4.9-20130421/gcc/../include
-I/mnt/scratch/gcc-4.9-20130421/gcc/../libcpp/include
-I/home/mikpe/pkgs/linux-x86_64/gmp-5.1.1/include
-I/home/mikpe/pkgs/linux-x86_64/mpfr-3.1.2/include
-I/home/mikpe/pkgs/linux-x86_64/mpc-1.0.1/include 
-I/mnt/scratch/gcc-4.9-20130421/gcc/../libdecnumber
-I/mnt/scratch/gcc-4.9-20130421/gcc/../libdecnumber/bid -I../libdecnumber
-I/mnt/scratch/gcc-4.9-20130421/gcc/../libbacktrace   
/mnt/scratch/gcc-4.9-20130421/gcc/fortran/module.c -o fortran/module.o
/mnt/scratch/gcc-4.9-20130421/gcc/fortran/module.c:78:18: fatal error: zlib.h:
No such file or directory
 #include <zlib.h>
                  ^
compilation terminated.
make[3]: *** [fortran/module.o] Error 1
make[3]: *** Waiting for unfinished jobs....
rm gcj-dbtool.pod gcj.pod jcf-dump.pod jv-convert.pod grmic.pod gc-analyze.pod
gfortran.pod gfdl.pod gij.pod gcc.pod gcov.pod cpp.pod fsf-funding.pod
make[3]: Leaving directory `/mnt/scratch/objdir49/gcc'
make[2]: *** [all-stage2-gcc] Error 2
make[2]: Leaving directory `/mnt/scratch/objdir49'
make[1]: *** [stage2-bubble] Error 2
make[1]: Leaving directory `/mnt/scratch/objdir49'
make: *** [bootstrap] Error 2

The previous weekly snapshot, 4.9-20130414, bootstrapped fine on the same
system with the same configuration options.

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[gretay at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

gretay at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gretay at gcc dot gnu.org,
                   |                            |jb at gcc dot gnu.org

--- Comment #1 from gretay at gcc dot gnu.org 2013-04-24 15:09:11 UTC ---
Bootstrap fails with a similar error message on arm-linux (ubuntu) without that
package.

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |jb at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #2 from Janne Blomqvist <jb at gcc dot gnu.org> 2013-04-24 15:28:52 UTC ---
Thanks for notifying, this is certainly due to my patch to compress fortran
module files. 

However, I'm a bit lost. I thought zlib was needed in any case as java and lto
already use it. Furthermore,  we have a copy of zlib in-tree already, shouldn't
that be used unless --with-system-zlib is specified to configure (in which the
user assumes responsibility for providing zkib.h)?

Any ideas?

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

--- Comment #3 from Mikael Pettersson <mikpe at it dot uu.se> 2013-04-24 16:54:41 UTC ---
As far as I understand it, there are two issues:

1. zlib isn't built unless some explicitly enabled component demands it; in my
case (on x86_64) zlib was built since I had java enabled, but nothing in
Fortran appears to declare a dependency on zlib.  Maybe
gcc/fortran/config-lang.in is the place to declare that?

2. The in-tree zlib isn't added automatically to include and library paths,
components need to check for with_system_zlib and adjust their paths
accordingly, c.f. libjava/configure.ac.

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2013-04/msg01464.htm
                   |                            |l

--- Comment #4 from Janne Blomqvist <jb at gcc dot gnu.org> 2013-04-24 20:03:17 UTC ---
Patch at http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01464.html .

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

--- Comment #5 from Mikael Pettersson <mikpe at it dot uu.se> 2013-04-25 09:16:12 UTC ---
(In reply to comment #4)
> Patch at http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01464.html .

The patch doesn't work.  With 4.9-20130421 + the patch I get:

/tmp/objdir/./prev-gcc/xg++ -B/tmp/objdir/./prev-gcc/
-B/tmp/install49/x86_64-unknown-linux-gnu/bin/ -nostdinc++
-B/tmp/objdir/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs
-B/tmp/objdir/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-I/tmp/objdir/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu
-I/tmp/objdir/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include
-I/tmp/gcc-4.9-20130421/libstdc++-v3/libsupc++
-L/tmp/objdir/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/tmp/objdir/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -c 
-DIN_GCC_FRONTEND -g -O2 -gtoggle -DIN_GCC   -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Werror   -DHAVE_CONFIG_H -I.
-Ifortran -I/tmp/gcc-4.9-20130421/gcc -I/tmp/gcc-4.9-20130421/gcc/fortran
-I/tmp/gcc-4.9-20130421/gcc/../include
-I/tmp/gcc-4.9-20130421/gcc/../libcpp/include
-I/home/mikpe/pkgs/linux-x86_64/gmp-5.1.1/include
-I/home/mikpe/pkgs/linux-x86_64/mpfr-3.1.2/include
-I/home/mikpe/pkgs/linux-x86_64/mpc-1.0.1/include 
-I/tmp/gcc-4.9-20130421/gcc/../libdecnumber
-I/tmp/gcc-4.9-20130421/gcc/../libdecnumber/bid -I../libdecnumber
-I/tmp/gcc-4.9-20130421/gcc/../libbacktrace   
/tmp/gcc-4.9-20130421/gcc/fortran/module.c -o fortran/module.o
/tmp/gcc-4.9-20130421/gcc/fortran/module.c:78:18: fatal error: zlib.h: No such
file or directory
 #include <zlib.h>

Note the absence of any -I directive to pick up the internal zlib.  Zlib was
built however, and e.g. lto-compress managed to pick it up:

/tmp/objdir/./prev-gcc/xg++ -B/tmp/objdir/./prev-gcc/
...-I/tmp/gcc-4.9-20130421/gcc/../zlib ...
/tmp/gcc-4.9-20130421/gcc/lto-compress.c -o lto-compress.o

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

--- Comment #7 from Mikael Pettersson <mikpe at it dot uu.se> 2013-04-25 13:50:47 UTC ---
(In reply to comment #6)
> Updated patch at http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01517.html

This one works.  Thanks.

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

--- Comment #8 from Janne Blomqvist <jb at gcc dot gnu.org> 2013-04-25 19:19:05 UTC ---
Author: jb
Date: Thu Apr 25 19:16:46 2013
New Revision: 198318

URL: http://gcc.gnu.org/viewcvs?rev=198318&root=gcc&view=rev
Log:
PR 57028 Bootstrap regression wrt zlib.

2013-04-25  Janne Blomqvist  <jb@gcc.gnu.org>

        PR bootstrap/57028
        * Make-lang.in (f951): Link in ZLIB.
        (CFLAGS-fortran/module.o): Add zlib include directory.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/Make-lang.in

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

--- Comment #9 from Janne Blomqvist <jb at gcc dot gnu.org> 2013-04-25 19:19:59 UTC ---
(In reply to comment #7)
> (In reply to comment #6)
> > Updated patch at http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01517.html
> 
> This one works.  Thanks.

Thanks for the confirmation. Committed as obvious.

[Bug bootstrap/57028] [4.9 regression] Fortran bootstrap fails due to missing zlib.h

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57028

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Janne Blomqvist <jb at gcc dot gnu.org> 2013-04-25 19:20:40 UTC ---
Ugh, sorry for the email spam, closing for real this time..