public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/57076] New: @ in the src directory name causes failure while building of gcc.info
@ 2013-04-25 21:16 pinskia at gcc dot gnu.org
  2013-04-26 10:15 ` [Bug bootstrap/57076] " schwab@linux-m68k.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2013-04-25 21:16 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57076

             Bug #: 57076
           Summary: @ in the src directory name causes failure while
                    building of gcc.info
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: pinskia@gcc.gnu.org


While doing a build where the src directory name contains a @, the build fails:
        makeinfo --split-size=5000000 --no-split -I . -I
/var/lib/jenkins/workspace/BuildToolchainMIPS@2/toolchain/scripts/../src/gcc/doc
\
            -I
/var/lib/jenkins/workspace/BuildToolchainMIPS@2/toolchain/scripts/../src/gcc/doc/include
-o doc/gcc.info
/var/lib/jenkins/workspace/BuildToolchainMIPS@2/toolchain/scripts/../src/gcc/doc/gcc.texi;
\
    fi
/var/lib/jenkins/workspace/BuildToolchainMIPS@2/toolchain/scripts/../src/gcc/doc//invoke.texi:1445:
Unknown command `2/toolchain/scripts/../src/gcc'.
/var/lib/jenkins/workspace/BuildToolchainMIPS@2/toolchain/scripts/../src/gcc/doc//invoke.texi:1444:
@include
`/var/lib/jenkins/workspace/BuildToolchainMIPS/../libiberty/at-file.texi': No
such file or directory.


I don't think there is anything that can be done on the GCC side though.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/57076] @ in the src directory name causes failure while building of gcc.info
  2013-04-25 21:16 [Bug bootstrap/57076] New: @ in the src directory name causes failure while building of gcc.info pinskia at gcc dot gnu.org
@ 2013-04-26 10:15 ` schwab@linux-m68k.org
  2020-10-31 14:31 ` fxcoudert at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: schwab@linux-m68k.org @ 2013-04-26 10:15 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57076

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> 2013-04-26 10:15:31 UTC ---
The rule to generate gcc-vers.texi needs to replace @ by @@ when writing out
the definition of srcdir.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/57076] @ in the src directory name causes failure while building of gcc.info
  2013-04-25 21:16 [Bug bootstrap/57076] New: @ in the src directory name causes failure while building of gcc.info pinskia at gcc dot gnu.org
  2013-04-26 10:15 ` [Bug bootstrap/57076] " schwab@linux-m68k.org
@ 2020-10-31 14:31 ` fxcoudert at gcc dot gnu.org
  2020-11-02 10:43 ` fxcoudert at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: fxcoudert at gcc dot gnu.org @ 2020-10-31 14:31 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57076

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu.org

--- Comment #6 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Quoting the @ into @@ in gcc-vers.texi does work:

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 7b94497b6f2..f2f6452c591 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -3286,7 +3286,7 @@ gcc-vers.texi: $(BASEVER) $(DEVPHASE)
         then echo "@set DEVELOPMENT"; \
         else echo "@clear DEVELOPMENT"; \
         fi) > $@T
-       $(build_file_translate) echo @set srcdir $(abs_srcdir) >> $@T
+       $(build_file_translate) echo @set srcdir `echo $(abs_srcdir) | sed -e
's|@|@@|g'` >> $@T
        if [ -n "$(PKGVERSION)" ]; then \
          echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@T; \
        fi

I've tested this in a build with a source directory with @ in it. It fixes the
build, and produce correct documentation.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/57076] @ in the src directory name causes failure while building of gcc.info
  2013-04-25 21:16 [Bug bootstrap/57076] New: @ in the src directory name causes failure while building of gcc.info pinskia at gcc dot gnu.org
  2013-04-26 10:15 ` [Bug bootstrap/57076] " schwab@linux-m68k.org
  2020-10-31 14:31 ` fxcoudert at gcc dot gnu.org
@ 2020-11-02 10:43 ` fxcoudert at gcc dot gnu.org
  2020-11-25  5:55 ` egallager at gcc dot gnu.org
  2020-11-25  8:44 ` fxcoudert at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: fxcoudert at gcc dot gnu.org @ 2020-11-02 10:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57076

--- Comment #7 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Updated patch:
https://gcc.gnu.org/pipermail/gcc-patches/2020-November/557728.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/57076] @ in the src directory name causes failure while building of gcc.info
  2013-04-25 21:16 [Bug bootstrap/57076] New: @ in the src directory name causes failure while building of gcc.info pinskia at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2020-11-02 10:43 ` fxcoudert at gcc dot gnu.org
@ 2020-11-25  5:55 ` egallager at gcc dot gnu.org
  2020-11-25  8:44 ` fxcoudert at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: egallager at gcc dot gnu.org @ 2020-11-25  5:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57076

--- Comment #8 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Francois-Xavier Coudert from comment #7)
> Updated patch:
> https://gcc.gnu.org/pipermail/gcc-patches/2020-November/557728.html

...and it got committed:
https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559336.html
So, ok to close this?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug bootstrap/57076] @ in the src directory name causes failure while building of gcc.info
  2013-04-25 21:16 [Bug bootstrap/57076] New: @ in the src directory name causes failure while building of gcc.info pinskia at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2020-11-25  5:55 ` egallager at gcc dot gnu.org
@ 2020-11-25  8:44 ` fxcoudert at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: fxcoudert at gcc dot gnu.org @ 2020-11-25  8:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57076

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |11.0

--- Comment #9 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Fixed indeed

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-11-25  8:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-25 21:16 [Bug bootstrap/57076] New: @ in the src directory name causes failure while building of gcc.info pinskia at gcc dot gnu.org
2013-04-26 10:15 ` [Bug bootstrap/57076] " schwab@linux-m68k.org
2020-10-31 14:31 ` fxcoudert at gcc dot gnu.org
2020-11-02 10:43 ` fxcoudert at gcc dot gnu.org
2020-11-25  5:55 ` egallager at gcc dot gnu.org
2020-11-25  8:44 ` fxcoudert at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).