public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/57084] 483. xalancbmk run fails with -O2 -flto for i686
Date: Fri, 03 May 2013 13:45:00 -0000	[thread overview]
Message-ID: <bug-57084-4-ptq5vO3URi@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57084-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57084

--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> 2013-05-03 13:45:28 UTC ---
(In reply to comment #3)
> > @@ -1993,6 +1994,18 @@ ipa_intraprocedural_devirtualization (gi
> >    token = OBJ_TYPE_REF_TOKEN (otr);
> >    fndecl = gimple_get_virt_method_for_binfo (tree_low_cst (token, 1),
> >                           binfo);
> > +  if (!fndecl)
> > +    return NULL_TREE;
> > +
> > +  callee = cgraph_get_node (fndecl);
> > +  if (!callee || callee->global.inlined_to)
> > +    {
> > +      if (!canonicalize_constructor_val (fndecl, NULL)
> fndecl = canonicalize_constructor_val (fndecl, NULL) 
> Why do you need TREE_PUBLIC check?

Well, as I wrote in the comment above, I basically copied the code
what you added to ipa_make_edge_direct_to_target in February this
year.  The comment there says that "In the case of static functions we
are out of luck, since we already removed its body."  BTW, we also
only check canonicalize_constructor_val return value for non-NULL-ness
in that function.

Anyway, this was just a proof of concept patch.  I suppose that we'll
want to put this functionality to a separate function and call it from
both ipa_make_edge_direct_to_target and eliminate_bb (in
tree-ssa-pre.c).  I wonder what name to give it to it though,
especially given that cgraph_get_create_real_symbol_node already exits
(but unlike what is required IIUC cannot return NULL).
cgraph_make_fndecl_callable?


  parent reply	other threads:[~2013-05-03 13:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 15:07 [Bug lto/57084] New: " izamyatin at gmail dot com
2013-04-29 16:34 ` [Bug lto/57084] " jamborm at gcc dot gnu.org
2013-05-02 15:46 ` jamborm at gcc dot gnu.org
2013-05-03 13:45 ` jamborm at gcc dot gnu.org [this message]
2013-05-07 17:56 ` jamborm at gcc dot gnu.org
2013-05-10 13:41 ` jamborm at gcc dot gnu.org
2013-10-29 14:32 ` jamborm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57084-4-ptq5vO3URi@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).