public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/57149] [4.8/4.9 Regression] wrong -Wmaybe-uninitialized warning with -Os
Date: Tue, 07 May 2013 07:01:00 -0000	[thread overview]
Message-ID: <bug-57149-4-ilpH977Vgs@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57149-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57149

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-05-07 07:00:58 UTC ---
The difference in *.uninit before/after that commit is small, just:
@@ -78,7 +79,7 @@ fn4 (struct F * x, unsigned int k)
     goto <bb 7>;

   <bb 7>:
-  # retval_25 = PHI <0(3), retval_26(6)>
+  # err_25 = PHI <0(3), retval_26(6)>
   _12 = y_9->f;
   if (_12 == 0)
     goto <bb 9>;
@@ -89,17 +90,17 @@ fn4 (struct F * x, unsigned int k)
   goto <bb 13>;

   <bb 9>:
-  if (retval_25 > 0)
+  if (err_25 > 0)
     goto <bb 10>;
   else
     goto <bb 11>;

   <bb 10>:
-  retval_14 = fn0 ();
+  err_14 = fn0 ();

   <bb 11>:
-  # retval_2 = PHI <retval_25(9), retval_14(10)>
-  if (retval_2 < 0)
+  # err_2 = PHI <err_25(9), err_14(10)>
+  if (err_2 < 0)
     goto <bb 12>;
   else
     goto <bb 8>;

and in both cases there is
   # retval_26 = PHI <retval_27(D)(4), retval_21(5)>
that is the reason for the warning.  The important thing is that the retval
decl has TREE_NO_WARNING set  (because of the retval = retval uninit warning
suppression), while err doesn't.

Trying a patch not to consider TREE_NO_WARNING SSA_NAME_VARs
ssa_undefined_value_p when inside of tree-ssa-uninit.c now.


  parent reply	other threads:[~2013-05-07  7:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 19:33 [Bug tree-optimization/57149] New: [4.8 " doko at gcc dot gnu.org
2013-05-03  8:58 ` [Bug tree-optimization/57149] " rguenth at gcc dot gnu.org
2013-05-03  8:58 ` rguenth at gcc dot gnu.org
2013-05-03  8:59 ` rguenth at gcc dot gnu.org
2013-05-07  7:01 ` jakub at gcc dot gnu.org [this message]
2013-05-07 10:40 ` [Bug tree-optimization/57149] [4.8/4.9 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57149-4-ilpH977Vgs@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).