public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/57188] [4.9 regression] Ada bootstrap broken on Solaris/x64: No_Implicit_Dynamic_Code violation
Date: Tue, 07 May 2013 14:57:00 -0000	[thread overview]
Message-ID: <bug-57188-4-TwJAMlDrRy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57188-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57188

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2013-05-07 14:57:20 UTC ---
> --- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2013-05-06 16:55:04 UTC ---
>> This doesn't happen in sparcv9-sun-solaris2* or i386-pc-solaris2*
>> configurations.
>
> gcc-interface/Makefile.in was a little changed so you probably need to adjust
> the relevant regexp here:
>
> # x86 and x86-64 solaris
> ifeq ($(strip $(filter-out %86 %x86_64 solaris2%,$(arch) $(osys))),)
>   LIBGNAT_TARGET_PAIRS_COMMON = \

That was it indeed.  The following patch restored amd64-pc-solaris2.10
bootstrap for, and also survived i386-pc-solaris2.11 bootstrap:

diff --git a/gcc/ada/gcc-interface/Makefile.in
b/gcc/ada/gcc-interface/Makefile.in
--- a/gcc/ada/gcc-interface/Makefile.in
+++ b/gcc/ada/gcc-interface/Makefile.in
@@ -1098,7 +1098,7 @@ ifeq ($(strip $(filter-out sparc% sun so
 endif

 # x86 and x86-64 solaris
-ifeq ($(strip $(filter-out %86 %x86_64 solaris2%,$(arch) $(osys))),)
+ifeq ($(strip $(filter-out %86 %x86_64 %amd64 solaris2%,$(arch) $(osys))),)
   LIBGNAT_TARGET_PAIRS_COMMON = \
   a-intnam.ads<a-intnam-solaris.ads \
   s-inmaop.adb<s-inmaop-posix.adb \

But what's the justification for the relevant change, which wasn't
posted to gcc-patches AFAICS?

2013-04-23  Eric Botcazou  <ebotcazou@adacore.com>
            Pascal Obry    <obry@adacore.com>

        * gcc-interface/Makefile.in (targ): Fix target name check.

Having to deal with the target_alias instead of the canonical form found
in target seems rather counterintuitive and fragile to me.

    Rainer


  parent reply	other threads:[~2013-05-07 14:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 15:37 [Bug ada/57188] New: " ro at gcc dot gnu.org
2013-05-06 16:55 ` [Bug ada/57188] " ebotcazou at gcc dot gnu.org
2013-05-07  8:52 ` rguenth at gcc dot gnu.org
2013-05-07 14:57 ` ro at CeBiTec dot Uni-Bielefeld.DE [this message]
2013-05-07 15:06 ` ebotcazou at gcc dot gnu.org
2013-05-07 15:09 ` ro at CeBiTec dot Uni-Bielefeld.DE
2013-05-13  7:15   ` Arnaud Charlet
2013-05-07 16:04 ` ebotcazou at gcc dot gnu.org
2013-05-08  9:29 ` ro at gcc dot gnu.org
2013-05-13  7:15 ` charlet at adacore dot com
2013-05-13 11:08 ` ro at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57188-4-TwJAMlDrRy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).