[Bug lto/57267] New: [4.9 regression] -flto-partition=none : symbol is already defined

[Bug lto/57267] New: [4.9 regression] -flto-partition=none : symbol is already defined

[dimhen at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57267

            Bug ID: 57267
           Summary: [4.9 regression] -flto-partition=none : symbol is
                    already defined
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dimhen at gmail dot com

198366 PASS
198828 FAIL

$ g++ -fpreprocessed -flto -c a.ii -o a.o
$ g++ -fpreprocessed -flto -c b.ii -o b.o
$ g++ -shared a.o b.o -O -flto -flto-partition=none -o x.so
/tmp/ccozW37q.s: Assembler messages:
/tmp/ccozW37q.s:16: Error: symbol `_ZL28__gthrw___pthread_key_createPjPFvPvE'
is already defined
lto-wrapper: g++ returned 1 exit status
/usr/bin/ld: fatal error: lto-wrapper failed
collect2: error: ld returned 1 exit status

$ cat a.ii
void pthread_key_create (unsigned *, void (void *));
static __typeof pthread_key_create __gthrw___pthread_key_create
__attribute__ ((__weakref__ ("__pthread_key_create")));
void *a = (void *) &__gthrw___pthread_key_create;

$ cat b.ii
void pthread_key_create (unsigned *, void (void *));
static __typeof pthread_key_create __gthrw___pthread_key_create
__attribute__ ((__weakref__ ("__pthread_key_create")));
void *__exchange_and_add_dispatch___gthread_active_ptr =
    (void *) &__gthrw___pthread_key_create;

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/gcc_current/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /home/dimhen/src/gcc-current/configure
--prefix=/usr/local/gcc_current --with-multilib-list=m64 --enable-__cxa_atexit
--enable-shared --enable-checking=yes,df,fold,rtl,tree
--enable-gnu-unique-object --enable-linker-build-id
--enable-languages=c,c++,lto --enable-plugin --with-tune=native
--with-march=native --enable-version-specific-runtime-libs
Thread model: posix
gcc version 4.9.0 20130513 (experimental) [trunk revision 198828] (GCC)

[Bug lto/57267] [4.9 regression] -flto-partition=none : symbol is already defined

[dimhen at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57267

--- Comment #1 from Dmitry G. Dyachenko <dimhen at gmail dot com> ---
198815 FAIL

[Bug lto/57267] [4.9 regression] -flto-partition=none : symbol is already defined

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57267

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |4.9.0

[Bug lto/57267] [4.9 regression] -flto-partition=none : symbol is already defined

[dimhen at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57267

--- Comment #3 from Dmitry G. Dyachenko <dimhen at gmail dot com> ---
testcase fixed in 198917

is this PR duplicate of lto/57038 ?

and how it's related to lto/47375 ? Sounds like PR number mismatch...

[Bug lto/57267] [4.9 regression] -flto-partition=none : symbol is already defined

[hubicka at ucw dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57267

--- Comment #4 from Jan Hubicka <hubicka at ucw dot cz> ---
> is this PR duplicate of lto/57038 ?
You are right, I meant lto/57038.
This PR is not exactly dup of lto/57038, but while fixing lto/57038 I
constructed artificial testcase similar to yours
and thus the problem should be fixed by
2013-05-15  Jan Hubicka  <jh@suse.cz>

        PR lto/57038
        PR lto/47375
        * lto-symtab.c (lto_symtab_symbol_p): Add external symbol;
        weakrefs are not external.
        (lto_symtab_merge_decls): Fix thinko when dealing with
        non-lto_symtab decls.
        (lto_symtab_merge_cgraph_nodes): Use lto_symtab_symbol_p.
        (lto_symtab_prevailing_decl): Get int sync with lto_symtab_symbol_p.
        * varpool.c (dump_varpool_node): Dump more flags.

        * lto-partition.c (get_symbol_class): Fix weakrefs.
        (lto_balanced_map): Fix weakrefs.
        (privatize_symbol_name): Remove unnecesary label.
        (rename_statics): Handle weakrefs as statics.

[Bug lto/57267] [4.9 regression] -flto-partition=none : symbol is already defined

[dimhen at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57267

Dmitry G. Dyachenko <dimhen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Dmitry G. Dyachenko <dimhen at gmail dot com> ---
fixed in r198917

*** This bug has been marked as a duplicate of bug 57038 ***