[Bug fortran/57285] New: ICe on invalid: "gfc_array_dimen_size(): Bad dimension" due to size() intrinsic with invalid dim on class() dummy argument

[Bug fortran/57285] New: ICe on invalid: "gfc_array_dimen_size(): Bad dimension" due to size() intrinsic with invalid dim on class() dummy argument

[bugs at stellardeath dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57285

            Bug ID: 57285
           Summary: ICe on invalid: "gfc_array_dimen_size(): Bad
                    dimension" due to size() intrinsic with invalid dim on
                    class() dummy argument
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bugs at stellardeath dot org

The following invalid code produces an internal error. It is invalid as it uses
size() with a dim argument of 2 that is larger than the number of dimensions of
the referred array.

> cat minimal.f90
module testmod
  type type_t
    integer :: dummy
  end type type_t
  contains
  subroutine foo(a)
    class(type_t), intent(in) :: a(:)
    type(type_t) :: c(size(a,dim=2))
  end subroutine
end module testmod
> 
> ~/sys/bin/gfortran minimal.f90 
minimal.f90:10.18:

end module testmod
                  1
Internal Error at (1):
gfc_array_dimen_size(): Bad dimension
>
> ~/sys/bin/gfortran --version
GNU Fortran (GCC) 4.9.0 20130514 (experimental)
Copyright (C) 2013 Free Software Foundation, Inc.

GNU Fortran comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of GNU Fortran
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING


Here, ~/sys/bin/gfortran is a self-compiled gfortran from yesterday's trunk,
the ICE also happens with the gfortran 4.7.2 supplied with openSUSE:


> gfortran --version
GNU Fortran (SUSE Linux) 4.7.2 20130108 [gcc-4_7-branch revision 195012]
Copyright (C) 2012 Free Software Foundation, Inc.

GNU Fortran comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of GNU Fortran
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING

> gfortran minimal.f90 
minimal.f90:10.18:

end module testmod
                  1
Internal Error at (1):
gfc_array_dimen_size(): Bad dimension



This might be related to Bug #57284.

[Bug fortran/57285] ICe on invalid: "gfc_array_dimen_size(): Bad dimension" due to size() intrinsic with invalid dim on class() dummy argument

[bugs at stellardeath dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57285

--- Comment #1 from Lorenz Hüdepohl <bugs at stellardeath dot org> ---
Created attachment 30120
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30120&action=edit
Minimal test case
>From gcc-bugs-return-422310-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 15 10:19:23 2013
Return-Path: <gcc-bugs-return-422310-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 20326 invoked by alias); 15 May 2013 10:19:23 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 20307 invoked by uid 48); 15 May 2013 10:19:20 -0000
From: "bugs at stellardeath dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/57284] ICE with "find_array_spec: unused as (1)" in conjunction with size() intrinsic on class dummy parameter shape
Date: Wed, 15 May 2013 10:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: bugs at stellardeath dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-57284-4-pNxTGrl7BE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-57284-4@http.gcc.gnu.org/bugzilla/>
References: <bug-57284-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-05/txt/msg00983.txt.bz2
Content-length: 160

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57284

--- Comment #1 from Lorenz Hüdepohl <bugs at stellardeath dot org> ---
Might be related to Bug #57285
>From gcc-bugs-return-422311-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 15 10:33:18 2013
Return-Path: <gcc-bugs-return-422311-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 28674 invoked by alias); 15 May 2013 10:33:18 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 28655 invoked by uid 48); 15 May 2013 10:33:15 -0000
From: "record.nctu.cis91 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/57283] missing typedefs in specialized std::mem_fn for member variables
Date: Wed, 15 May 2013 10:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.7.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: record.nctu.cis91 at gmail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-57283-4-u42RwCMTJV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-57283-4@http.gcc.gnu.org/bugzilla/>
References: <bug-57283-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-05/txt/msg00984.txt.bz2
Content-length: 487

http://gcc.gnu.org/bugzilla/show_bug.cgi?idW283

--- Comment #2 from Lin Yi-Li <record.nctu.cis91 at gmail dot com> ---
Sorry I missed that 'pm is a pointer to member function...'.

I know that C++11 has lambda, but using std::mem_fn is sometimes much clear.
But according to standard, value from std::mem_fn for variable will not be able
to work with std::not1. Even if the usage is similiar to the one for member
function takes no argument.

So is it possible to be an enhancement?

[Bug fortran/57285] [OOP] ICE on invalid: "gfc_array_dimen_size(): Bad dimension" due to SIZE intrinsic with invalid dim on CLASS dummy

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57285

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-05-15
                 CC|                            |janus at gcc dot gnu.org
            Summary|ICe on invalid:             |[OOP] ICE on invalid:
                   |"gfc_array_dimen_size():    |"gfc_array_dimen_size():
                   |Bad dimension" due to       |Bad dimension" due to SIZE
                   |size() intrinsic with       |intrinsic with invalid dim
                   |invalid dim on class()      |on CLASS dummy
                   |dummy argument              |
     Ever confirmed|0                           |1

--- Comment #2 from janus at gcc dot gnu.org ---
Confirmed. Changing "a" from CLASS to TYPE ...

  type type_t
  end type
contains
  subroutine foo(a)
    type(type_t), intent(in) :: a(:)
    type(type_t) :: c(size(a,dim=2))
  end subroutine
end  

... one gets the correct error message:

    type(type_t) :: c(size(a,dim=2))
                                 1
Error: 'dim' argument of 'size' intrinsic at (1) is not a valid dimension index

(unfortunately twice!)

[Bug fortran/57285] [OOP] ICE on invalid: "gfc_array_dimen_size(): Bad dimension" due to SIZE intrinsic with invalid dim on CLASS dummy

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57285

--- Comment #3 from janus at gcc dot gnu.org ---
Why the hell do we disable the dimension check for CLASS variables?


Index: gcc/fortran/check.c
===================================================================
--- gcc/fortran/check.c    (revision 201253)
+++ gcc/fortran/check.c    (working copy)
@@ -608,9 +608,6 @@ dim_rank_check (gfc_expr *dim, gfc_expr *array, in
   if (dim->expr_type != EXPR_CONSTANT)
     return true;

-  if (array->ts.type == BT_CLASS)
-    return true;
-
   if (array->expr_type == EXPR_FUNCTION && array->value.function.isym
       && array->value.function.isym->id == GFC_ISYM_SPREAD)
     rank = array->rank + 1;

[Bug fortran/57285] [OOP] ICE on invalid: "gfc_array_dimen_size(): Bad dimension" due to SIZE intrinsic with invalid dim on CLASS dummy

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57285

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org

--- Comment #4 from janus at gcc dot gnu.org ---
(In reply to janus from comment #3)
> Why the hell do we disable the dimension check for CLASS variables?

Seems to be some sort of artifact from the early class-array implementation:

http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=182210


> Index: gcc/fortran/check.c
> ===================================================================
> --- gcc/fortran/check.c	(revision 201253)
> +++ gcc/fortran/check.c	(working copy)
> @@ -608,9 +608,6 @@ dim_rank_check (gfc_expr *dim, gfc_expr *array, in
>    if (dim->expr_type != EXPR_CONSTANT)
>      return true;
>  
> -  if (array->ts.type == BT_CLASS)
> -    return true;
> -
>    if (array->expr_type == EXPR_FUNCTION && array->value.function.isym
>        && array->value.function.isym->id == GFC_ISYM_SPREAD)
>      rank = array->rank + 1;

In any case, this patch regtests cleanly. Will commit as obvious ...
>From gcc-bugs-return-426806-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jul 27 10:29:37 2013
Return-Path: <gcc-bugs-return-426806-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21231 invoked by alias); 27 Jul 2013 10:29:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21145 invoked by uid 48); 27 Jul 2013 10:29:33 -0000
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/58000] New: Accept OPEN( ... NAME=) with -std=legacy
Date: Sat, 27 Jul 2013 10:29:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: burnus at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status keywords bug_severity priority component assigned_to reporter
Message-ID: <bug-58000-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-07/txt/msg01313.txt.bz2
Content-length: 1188

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX000

            Bug ID: 58000
           Summary: Accept OPEN( ... NAME=) with -std=legacy
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org

Some Fortran compilers supported:
   OPEN(99, NAME='filename')
while the Fortran standard only permits
   OPEN(99, FILE='filename')

I think it would be useful to also permit 'NAME=' with -std=legacy. And to
print a nice error message with -std=f*/gnu, which tells the user that the
proper specifier is "FILE=".

NAME is accepted by default by Absoft, Intel and PGI. (Intel warns with -stand
f95/f03 but still accepts it.) Sun/Oracle have "WARNING: NAME= will be ignored,
because -f77=input/output option is absent" - and accept it silently with
either suboption.

Note: It should be still rejected with -std=gnu as that's only part of legacy
code and given that many compiler do not support it. For instance: g95,
pathf95, gfortran, NAG f95 and crayftn don't.

[Bug fortran/57285] [OOP] ICE on invalid: "gfc_array_dimen_size(): Bad dimension" due to SIZE intrinsic with invalid dim on CLASS dummy

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57285

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from janus at gcc dot gnu.org ---
Fixed with the commit below. Closing. Thanks for the report!


Author: janus
Date: Sat Jul 27 12:55:59 2013
New Revision: 201284

URL: http://gcc.gnu.org/viewcvs?rev=201284&root=gcc&view=rev
Log:
2013-07-27  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/57285
    * check.c (dim_rank_check): Re-enable this check for CLASS arrays.

2013-07-27  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/57285
    * gfortran.dg/class_array_19.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/class_array_19.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/check.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/57285] [OOP] ICE on invalid: "gfc_array_dimen_size(): Bad dimension" due to SIZE intrinsic with invalid dim on CLASS dummy

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57285

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #6 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to janus from comment #4)
> (In reply to janus from comment #3)
> > Why the hell do we disable the dimension check for CLASS variables?
> 
> Seems to be some sort of artifact from the early class-array implementation:
> 
> http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=182210
> 
Maybe there are other "sort of artifact" to remove?