public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/57300] [4.8/4.9 Regression] statement in expression miscompiled at -O3 in 32-bit mode
Date: Thu, 16 May 2013 10:08:00 -0000	[thread overview]
Message-ID: <bug-57300-4-93eaTgeJ0J@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57300-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57300

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Re: Eric's question, not easily, because if we implement that define_split as
define_peephole2, then it won't trigger at all, because the next define_split
";; Extend to memory case when source register does not die.", will then split
the insn already during split2 pass rather than waiting for peephole2 pass.

So we'd need to protect that second splitter with peephole2_completed predicate
which we don't have yet, or so.  Is that the way to go?  If so, I can try a
patch.  Note, s390 will still be broken, but we don't have testcases for it
right now.

Re: Steven, we need some solution for 4.8.1 too.  While it is true that
generally df_note doesn't mean the problem is up2date, doesn't df_finish_pass
always kill that problem and thus at least the current pass should have called
df_add_note_problem?  Given the passes that split insns right now (see previous
comments), having df_note non-NULL means either it is a combine pass where it
is fine, or split* pass in which split_dead_or_set_p has been called already.


  parent reply	other threads:[~2013-05-16 10:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 19:41 [Bug rtl-optimization/57300] New: " dhazeghi at yahoo dot com
2013-05-16  7:53 ` [Bug rtl-optimization/57300] [4.8/4.9 Regression] " jakub at gcc dot gnu.org
2013-05-16  8:11 ` jakub at gcc dot gnu.org
2013-05-16  8:16 ` jakub at gcc dot gnu.org
2013-05-16  8:35 ` jakub at gcc dot gnu.org
2013-05-16  8:51 ` steven at gcc dot gnu.org
2013-05-16  9:02 ` jakub at gcc dot gnu.org
2013-05-16  9:29 ` ebotcazou at gcc dot gnu.org
2013-05-16  9:43 ` jakub at gcc dot gnu.org
2013-05-16  9:50 ` steven at gcc dot gnu.org
2013-05-16 10:08 ` jakub at gcc dot gnu.org [this message]
2013-05-16 10:13 ` jakub at gcc dot gnu.org
2013-05-16 11:26 ` rguenth at gcc dot gnu.org
2013-05-16 14:48 ` ebotcazou at gcc dot gnu.org
2013-05-20  7:13 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57300-4-93eaTgeJ0J@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).