[Bug fortran/57307] New: ICE with sourced allocation with array constructor

[Bug fortran/57307] New: ICE with sourced allocation with array constructor

[vladimir.fuka at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57307

            Bug ID: 57307
           Summary: ICE with sourced allocation with array constructor
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vladimir.fuka at gmail dot com

integer,allocatable :: a(:)
      integer :: e

        allocate(a,source=[e])
end


produces:

gfortran -c ice8.f90
f951: internal compiler error: NeoprĂĄvnÄĂ˝ pĹĂ­stup do pamÄi (SIGSEGV)
0x8ba79f crash_signal
        ../../gcc-4.8-20130509/gcc/toplev.c:332
0x5bab06 conformable_arrays
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:7077
0x5bab06 resolve_allocate_expr
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:7247
0x5bab06 resolve_allocate_deallocate
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:7670
0x5bcf56 resolve_code
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:10335
0x5bec4e resolve_codes
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:14975
0x5afb22 gfc_resolve
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:15003
0x5a4662 resolve_all_program_units
        ../../gcc-4.8-20130509/gcc/fortran/parse.c:4406
0x5a4662 gfc_parse_file()
        ../../gcc-4.8-20130509/gcc/fortran/parse.c:4673
0x5dfd15 gfc_be_parse_file
        ../../gcc-4.8-20130509/gcc/fortran/f95-lang.c:189
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
lada@meop37:~/f/testy/errors>
lada@meop37:~/f/testy/errors>
lada@meop37:~/f/testy/errors> gfortran -c ice8.f90
f951: internal compiler error: NeoprĂĄvnÄĂ˝ pĹĂ­stup do pamÄi (SIGSEGV)
0x8ba79f crash_signal
        ../../gcc-4.8-20130509/gcc/toplev.c:332
0x5bab06 conformable_arrays
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:7077
0x5bab06 resolve_allocate_expr
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:7247
0x5bab06 resolve_allocate_deallocate
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:7670
0x5bcf56 resolve_code
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:10335
0x5bec4e resolve_codes
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:14975
0x5afb22 gfc_resolve
        ../../gcc-4.8-20130509/gcc/fortran/resolve.c:15003
0x5a4662 resolve_all_program_units
        ../../gcc-4.8-20130509/gcc/fortran/parse.c:4406
0x5a4662 gfc_parse_file()
        ../../gcc-4.8-20130509/gcc/fortran/parse.c:4673
0x5dfd15 gfc_be_parse_file
        ../../gcc-4.8-20130509/gcc/fortran/f95-lang.c:189
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-422475-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 16 20:09:01 2013
Return-Path: <gcc-bugs-return-422475-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18788 invoked by alias); 16 May 2013 20:09:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18678 invoked by uid 48); 16 May 2013 20:08:50 -0000
From: "jason at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/17314] Error message wrongly shows declared rather than inherited access
Date: Thu, 16 May 2013 20:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 3.4.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jason at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: gdr at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-17314-4-niRjrHNFpr@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-17314-4@http.gcc.gnu.org/bugzilla/>
References: <bug-17314-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-05/txt/msg01148.txt.bz2
Content-length: 350

http://gcc.gnu.org/bugzilla/show_bug.cgi?id\x17314

--- Comment #17 from Jason Merrill <jason at gcc dot gnu.org> ---
Actually, this seems to be issue 7:

  http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_closed.html#7

So we should reject the variant with a public constructor as well.  It would be
good to get the same diagnostic as in comment #4.

[Bug fortran/57307] ICE with sourced allocation with array constructor

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57307

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-06-20
                 CC|                            |burnus@net-b.de
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Confirmed with 4.8.1. For the test in comment #0, the trunk gives the error

pr57307.f90:4.17:

        allocate(a,source=[e])
                 1
Error: Array specification required in ALLOCATE statement at (1)

which seems right. The ICE has been fixed between revisions 198550 (2013-05-02)
and 198624 (2013-05-06).

[Bug fortran/57307] ICE with sourced allocation with array constructor

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57307

vehre at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |vehre at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |vehre at gcc dot gnu.org

--- Comment #2 from vehre at gcc dot gnu.org ---
Taking this pr, because my patch at
https://gcc.gnu.org/ml/fortran/2015-03/msg00168.html fixes the issue as
reported by Dominique.

[Bug fortran/57307] ICE with sourced allocation with array constructor

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57307

--- Comment #3 from vehre at gcc dot gnu.org ---
Author: vehre
Date: Mon Jun 15 10:08:04 2015
New Revision: 224477

URL: https://gcc.gnu.org/viewcvs?rev=224477&root=gcc&view=rev
Log:
gcc/testsuite/ChangeLog:

2015-06-15  Andre Vehreschild  <vehre@gmx.de>

        PR fortran/44672
        PR fortran/45440
        PR fortran/57307
        * gfortran.dg/allocate_with_source_3.f90: Removed check for
        unimplemented error.
        * gfortran.dg/allocate_with_source_7.f08: New test.
        * gfortran.dg/allocate_with_source_8.f08: New test.

gcc/fortran/ChangeLog:

2015-06-15  Andre Vehreschild  <vehre@gmx.de>

        PR fortran/44672
        PR fortran/45440
        PR fortran/57307
        * gfortran.h: Extend gfc_code.ext.alloc to carry a
        flag indicating that the array specification has to be
        taken from expr3.
        * resolve.c (resolve_allocate_expr): Add F2008 notify
        and flag indicating source driven array spec.
        (resolve_allocate_deallocate): Check for source driven
        array spec, when array to allocate has no explicit
        array spec.
        * trans-array.c (gfc_array_init_size): Get lower and
        upper bound from a tree array descriptor, except when
        the source expression is an array-constructor which is
        fixed to be one-based.
        (retrieve_last_ref): Extracted from gfc_array_allocate().
        (gfc_array_allocate): Enable allocate(array, source= 
        array_expression) as specified by F2008:C633.
        (gfc_conv_expr_descriptor): Add class tree expression
        into the saved descriptor for class arrays.
        * trans-array.h: Add temporary array descriptor to
        gfc_array_allocate ().
        * trans-expr.c (gfc_conv_procedure_call): Special handling
        for _copy() routine translation, that comes without an
        interface. Third and fourth argument are now passed by value.
        * trans-stmt.c (gfc_trans_allocate): Get expr3 array
        descriptor for temporary arrays to allow allocate(array,
        source = array_expression) for array without array
        specification.


Added:
    trunk/gcc/testsuite/gfortran.dg/allocate_with_source_7.f08
    trunk/gcc/testsuite/gfortran.dg/allocate_with_source_8.f08
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-array.h
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/allocate_with_source_3.f90

[Bug fortran/57307] ICE with sourced allocation with array constructor

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57307

vehre at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from vehre at gcc dot gnu.org ---
Fixed with r224477.