From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 1537B385800E; Sat, 20 Jan 2024 22:16:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1537B385800E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1705788965; bh=Okk1PGcojLqIRwaFQPErSgqtSooL3ILa8iSTuPn5oFA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=H3FCO1KgQeEoAvTu5PiTB7kj2VmX20zCy6KlJhlrt0/+R6Sxf5iblI4NzDqepDrim gUMojkXL5lnEmtpsD7R5haAWAvou2OChZ+q89UTfMsZ7DOjG5PMISDXNAhj29+1h4C Tu+RYssarHcfr3RUkAbjL/wM0RRWoOfLQ6SHr7co= From: "kargl at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/57360] Implement a warning for implied save Date: Sat, 20 Jan 2024 22:16:03 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: enhancement X-Bugzilla-Who: kargl at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D57360 kargl at gcc dot gnu.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kargl at gcc dot gnu.org --- Comment #6 from kargl at gcc dot gnu.org --- With this patch,=20 diff --git a/gcc/fortran/decl.cc b/gcc/fortran/decl.cc index 503ecb8d9b5..abb3579893f 100644 --- a/gcc/fortran/decl.cc +++ b/gcc/fortran/decl.cc @@ -2278,7 +2278,12 @@ add_init_expr_to_sym (const char *name, gfc_expr **initp, locus *var_locus) sym->value =3D init; if (sym->attr.save =3D=3D SAVE_NONE) - sym->attr.save =3D SAVE_IMPLICIT; + { + sym->attr.save =3D SAVE_IMPLICIT; + if (warn_surprising) + gfc_warning (OPT_Wsurprising, "Entity %qs at %L has an implicit= " + "SAVE attribute", sym->name, &sym->declared_at); + } *initp =3D NULL; } I see % gfcx -o z a.f90 -Wsurprising && ./z a.f90:2:13: 2 | integer :: i=3D1 | 1 Warning: Entity =E2=80=98i=E2=80=99 at (1) has an implicit SAVE attribute [= -Wsurprising] 1=