public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tmsriram at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/57362] [4.8/4.9 Regression] unsupported __attribute__((target())) values appear to cause loop and/or pathological behavior
Date: Wed, 22 May 2013 23:46:00 -0000	[thread overview]
Message-ID: <bug-57362-4-cPLevGoaqR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57362-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57362

--- Comment #3 from Sriraman Tallam <tmsriram at google dot com> ---
Patch proposed to fix this problem,

This happens when a subset of versions are invalid because of unrecognized
target string name or if a dispatcher for that is not available.  When
constructing the versions array to dispatch, the index used here is wrong.


       PR 57362
        * config/i386/i386.c (dispatch_function_versions):  Use actual_versions 
        to index into function_version_info.

Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c  (revision 199219)
+++ config/i386/i386.c  (working copy)
@@ -29061,10 +29061,10 @@ dispatch_function_versions (tree dispatch_decl,
       if (predicate_chain == NULL_TREE)
        continue;

+      function_version_info [actual_versions].version_decl = version_decl;
+      function_version_info [actual_versions].predicate_chain =
predicate_chain;
+      function_version_info [actual_versions].dispatch_priority = priority;
       actual_versions++;
-      function_version_info [ix - 1].version_decl = version_decl;
-      function_version_info [ix - 1].predicate_chain = predicate_chain;
-      function_version_info [ix - 1].dispatch_priority = priority;
     }

   /* Sort the versions according to descending order of dispatch priority. 
The


  parent reply	other threads:[~2013-05-22 23:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 19:16 [Bug c++/57362] New: " mib.bugzilla at gmail dot com
2013-05-21 19:18 ` [Bug c++/57362] " mib.bugzilla at gmail dot com
2013-05-22  8:17 ` [Bug c++/57362] [4.8/4.9 Regression] " rguenth at gcc dot gnu.org
2013-05-22 23:46 ` tmsriram at google dot com [this message]
2013-05-31 10:58 ` jakub at gcc dot gnu.org
2013-07-11 23:07 ` tmsriram at google dot com
2013-07-11 23:31 ` paolo.carlini at oracle dot com
2013-07-31 20:12 ` jason at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57362-4-cPLevGoaqR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).