[Bug fortran/57364] New: [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[Bug fortran/57364] New: [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

            Bug ID: 57364
           Summary: [4.8/4.9 Regression][OOP] ICE
                    gfc_enforce_clean_symbol_state
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org

Created attachment 30159
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30159&action=edit
Test case

The attached program compiles with GCC 4.5, 4.6 and 4.7 - but with GCC 4.8 and
GCC 4.9, it fails with:

f951: internal compiler error: in gfc_enforce_clean_symbol_state, at
fortran/symbol.c:3674
0x5f2307 gfc_enforce_clean_symbol_state()
        ../../gcc/fortran/symbol.c:3674

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |4.8.1

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Good: 3caa5c539819385bd6bcfc5947b51bf8559f8ce0 2012-11-30  Rev. 193988
Bad:  4d228ee6fa4a287bae84024820e847bf95905162 2012-12-01  Rev. 194018

Hence, the following patch is the culprit:

http://gcc.gnu.org/r194016
2012-12-01   Alessandro Fanfarillo <alessandro.fanfarillo@gmail.com>
             Paul Thomas  <pault@gcc.gnu.org>    
        PR fortran/46897

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Draft patch:

--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -9299,4 +9299,5 @@ get_temp_from_expr (gfc_expr *e, gfc_namespace *ns)
     tmp->n.sym->attr.dimension = 0;

+  gfc_commit_symbol (tmp->n.sym);
   gfc_set_sym_referenced (tmp->n.sym);
   gfc_add_flavor (&tmp->n.sym->attr, FL_VARIABLE, name, NULL);

Re: [Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[Mikael Morin]

Le 22/05/2013 11:22, burnus at gcc dot gnu.org a écrit :
> --- a/gcc/fortran/resolve.c
> +++ b/gcc/fortran/resolve.c
> @@ -9299,4 +9299,5 @@ get_temp_from_expr (gfc_expr *e, gfc_namespace *ns)
>      tmp->n.sym->attr.dimension = 0;
> 
> +  gfc_commit_symbol (tmp->n.sym);
>    gfc_set_sym_referenced (tmp->n.sym);
>    gfc_add_flavor (&tmp->n.sym->attr, FL_VARIABLE, name, NULL);
> 
Without looking at the code, gfc_commit_symbol should come after the
gfc_set_sym_referenced, gfc_add_flavor, etc, and any modification made
to tmp->n.sym.

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[mikael.morin at sfr dot fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

--- Comment #3 from mikael.morin at sfr dot fr ---
Le 22/05/2013 11:22, burnus at gcc dot gnu.org a écrit :
> --- a/gcc/fortran/resolve.c
> +++ b/gcc/fortran/resolve.c
> @@ -9299,4 +9299,5 @@ get_temp_from_expr (gfc_expr *e, gfc_namespace *ns)
>      tmp->n.sym->attr.dimension = 0;
> 
> +  gfc_commit_symbol (tmp->n.sym);
>    gfc_set_sym_referenced (tmp->n.sym);
>    gfc_add_flavor (&tmp->n.sym->attr, FL_VARIABLE, name, NULL);
> 
Without looking at the code, gfc_commit_symbol should come after the
gfc_set_sym_referenced, gfc_add_flavor, etc, and any modification made
to tmp->n.sym.
>From gcc-bugs-return-422858-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 22 11:13:43 2013
Return-Path: <gcc-bugs-return-422858-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32669 invoked by alias); 22 May 2013 11:13:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32597 invoked by uid 48); 22 May 2013 11:13:39 -0000
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/57338] ICE with assumed rank
Date: Wed, 22 May 2013 11:13:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: burnus at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-57338-4-UeZ1puwik8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-57338-4@http.gcc.gnu.org/bugzilla/>
References: <bug-57338-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-05/txt/msg01531.txt.bz2
Content-length: 1087

http://gcc.gnu.org/bugzilla/show_bug.cgi?idW338

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Wed May 22 11:13:17 2013
New Revision: 199192

URL: http://gcc.gnu.org/viewcvs?rev\x199192&root=gcc&view=rev
Log:
2013-05-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57338
        * intrinsic.c (do_check): Move some checks to ...
        (do_ts29113_check): ... this new function.
        (check_specific, gfc_intrinsic_sub_interface): Call it.

2013-05-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57338
        * gfortran.dg/assumed_type_6.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/assumed_type_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/intrinsic.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Wed May 22 12:43:55 2013
New Revision: 199196

URL: http://gcc.gnu.org/viewcvs?rev=199196&root=gcc&view=rev
Log:
2013-05-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57364
        * resolve.c (get_temp_from_expr): Commit created sym.

2013-05-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57364
        * gfortran.dg/defined_assignment_6.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/defined_assignment_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-05-28
                 CC|                            |janus at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.1                       |4.8.2

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.1 has been released.

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Tue Jun  4 07:11:12 2013
New Revision: 199635

URL: http://gcc.gnu.org/viewcvs?rev=199635&root=gcc&view=rev
Log:
2013-06-04  Tobias Burnus  <burnus@net-b.de>

        Backport from mainline
        2013-05-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57364
        * resolve.c (get_temp_from_expr): Commit created sym.

2013-06-04  Tobias Burnus  <burnus@net-b.de>

        Backport from mainline
        2013-05-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57364
        * gfortran.dg/defined_assignment_6.f90: New.


Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/defined_assignment_6.f90
Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/resolve.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug fortran/57364] [4.8/4.9 Regression][OOP] ICE gfc_enforce_clean_symbol_state

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57364

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED on the trunk (for 4.9) and on the 4.8 branch.