public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ccoutant at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/57451] Incorrect debug ranges emitted for -freorder-blocks-and-partition -g
Date: Mon, 12 Aug 2013 16:17:00 -0000	[thread overview]
Message-ID: <bug-57451-4-hXuQB5wzzn@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57451-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57451

--- Comment #9 from ccoutant at google dot com ---
>>> +      if (!active_insn_p (insn))
>>> +        continue;
>>
>> I'm not clear on why this is needed. Is it because after the
>> change_scope, insn will now be a NOTE? If that's it, just put the
>> continue in the previous if clause.
>
> Because the notes were being skipped by the iteration over
> instructions, which previously only walked active instructions (notes
> are not active instructions). So to see the switch section note I had
> to walk all instructions, and just skip non-active instructions after
> I am done checking for the note of interest.

Oh, right. I didn't notice the change in the for loop.

-cary


  parent reply	other threads:[~2013-08-12 16:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 14:55 [Bug rtl-optimization/57451] New: " tejohnson at google dot com
2013-06-12 15:54 ` [Bug rtl-optimization/57451] " tejohnson at google dot com
2013-06-12 17:08 ` ccoutant at gcc dot gnu.org
2013-06-13  2:07 ` tejohnson at google dot com
2013-06-15 14:03 ` tejohnson at google dot com
2013-08-09 23:01 ` tejohnson at google dot com
2013-08-09 23:23 ` ccoutant at google dot com
2013-08-09 23:30 ` tejohnson at google dot com
2013-08-12 16:17 ` ccoutant at google dot com [this message]
2013-11-23  4:30 ` tejohnson at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57451-4-hXuQB5wzzn@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).