[Bug fortran/57553] New: Valid use of STORAGE_SIZE rejected, bad error message for invalid use

[Bug fortran/57553] New: Valid use of STORAGE_SIZE rejected, bad error message for invalid use

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57553

            Bug ID: 57553
           Summary: Valid use of STORAGE_SIZE rejected, bad error message
                    for invalid use
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Keywords: diagnostic, rejects-valid
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org

Found at http://mailman.j3-fortran.org/pipermail/j3/2013-June/006442.html
(please read also follow up email).


* The following looks valid to me and it is rejected with a bogus error
message:
  integer, parameter :: ESize = storage_size('a')
                                              1
  Error: Invalid character in name at (1)

integer, parameter :: ESize = storage_size('a')
end


* The following is invalid, but the error message location is bad:
    integer, parameter :: ESize = ( storage_size(a) + 7 ) / 8
    1
  Error: Unclassifiable statement at (1)

subroutine S ( A )
  character(len=*), intent(in) :: A
  integer, parameter :: ESize = ( storage_size(a) + 7 ) / 8
end

[Bug fortran/57553] Valid use of STORAGE_SIZE rejected, bad error message for invalid use

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57553

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
"13.7.160 STORAGE SIZE (A [, KIND])
 Description. Storage size in bits.
 Class. Inquiry function.
 Arguments.
 A     shall be a scalar or array of any type. If it is polymorphic it shall
       not be an undefined pointer. If it has any deferred type parameters
       it shall not be an unallocated allocatable variable or a disassociated
       or undefined pointer."

My impression is that the current code assumes that the argument is a variable
and not an expression (including literal constants).

[Bug fortran/57553] Valid use of STORAGE_SIZE rejected, bad error message for invalid use

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57553

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Sat Jun  8 12:21:58 2013
New Revision: 199850

URL: http://gcc.gnu.org/viewcvs?rev=199850&root=gcc&view=rev
Log:
2013-06-08  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57553
        * simplify.c (gfc_simplify_storage_size): Handle literal
        strings.
        * trans-intrinsic.c (gfc_conv_intrinsic_storage_size):
        Add missing fold_convert.

2013-06-08  Tobias Burnus  <burnus@net-b.de>

        PR fortran/57553
        * gfortran.dg/storage_size_4.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/storage_size_4.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/simplify.c
    trunk/gcc/fortran/trans-intrinsic.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/57553] Valid use of STORAGE_SIZE rejected, bad error message for invalid use

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57553

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The rejects-valid and the ICE-on-valid-code issue has been solved.


TODO: The following message for invalid code should be improved. [The problem
is that storage_size cannot handle "a", which is required for a constant
expression.]

    integer, parameter :: ESize = ( storage_size(a) + 7 ) / 8
    1
  Error: Unclassifiable statement at (1)

[Bug fortran/57553] Valid use of STORAGE_SIZE rejected, bad error message for invalid use

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57553

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-06-29
     Ever confirmed|0                           |1

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> TODO: The following message for invalid code should be improved. ...

Confirmed.