public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/57602] [4.9 Regression] Runfails for several C/C++ benchmarks from spec2000 for i686 with -flto after r199422
Date: Mon, 05 Aug 2013 13:10:00 -0000	[thread overview]
Message-ID: <bug-57602-4-HtUmoST6Sz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57602-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57602

--- Comment #13 from Jan Hubicka <hubicka at ucw dot cz> ---
> Please, let me know if more info is needed.
Actually I got the same ICE in meantime.  Here is improved patch (it is still
testing for me)

Index: cgraph.c
===================================================================
*** cgraph.c    (revision 201483)
--- cgraph.c    (working copy)
*************** verify_cgraph_node (struct cgraph_node *
*** 2363,2369 ****
        error ("inline clone in same comdat group list");
        error_found = true;
      }
!   if (!node->symbol.definition && node->local.local)
      {
        error ("local symbols must be defined");
        error_found = true;
--- 2363,2369 ----
        error ("inline clone in same comdat group list");
        error_found = true;
      }
!   if (!node->symbol.definition && !node->symbol.in_other_partition &&
node->local.local)
      {
        error ("local symbols must be defined");
        error_found = true;
Index: ipa.c
===================================================================
*** ipa.c    (revision 201483)
--- ipa.c    (working copy)
*************** symtab_remove_unreachable_nodes (bool be
*** 376,382 ****
          {
            if (file)
          fprintf (file, " %s", cgraph_node_name (node));
!           cgraph_reset_node (node);
            changed = true;
          }
      }
--- 376,390 ----
          {
            if (file)
          fprintf (file, " %s", cgraph_node_name (node));
!           node->symbol.analyzed = false;
!           node->symbol.definition = false;
!           node->symbol.cpp_implicit_alias = false;
!           node->symbol.alias = false;
!           node->symbol.weakref = false;
!           if (!node->symbol.in_other_partition)
!         node->local.local = false;
!           cgraph_node_remove_callees (node);
!           ipa_remove_all_references (&node->symbol.ref_list);
            changed = true;
          }
      }
*************** function_and_variable_visibility (bool w
*** 888,894 ****
      }
    FOR_EACH_DEFINED_FUNCTION (node)
      {
!       node->local.local = cgraph_local_node_p (node);

        /* If we know that function can not be overwritten by a different
semantics
       and moreover its section can not be discarded, replace all direct calls
--- 896,902 ----
      }
    FOR_EACH_DEFINED_FUNCTION (node)
      {
!       node->local.local |= cgraph_local_node_p (node);

        /* If we know that function can not be overwritten by a different
semantics
       and moreover its section can not be discarded, replace all direct calls


  parent reply	other threads:[~2013-08-05 13:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  7:21 [Bug lto/57602] New: " izamyatin at gmail dot com
2013-06-13 13:57 ` [Bug lto/57602] " ysrumyan at gmail dot com
2013-06-26 13:59 ` izamyatin at gmail dot com
2013-06-26 13:59 ` izamyatin at gmail dot com
2013-06-28 21:40 ` jh at suse dot cz
2013-07-09  9:10 ` izamyatin at gmail dot com
2013-07-22 10:23 ` [Bug lto/57602] [4.9 Regression] " ubizjak at gmail dot com
2013-07-22 14:22 ` d.g.gorbachev at gmail dot com
2013-07-22 14:23 ` d.g.gorbachev at gmail dot com
2013-08-04  8:38 ` hubicka at gcc dot gnu.org
2013-08-05  9:35 ` hubicka at gcc dot gnu.org
2013-08-05 13:05 ` ysrumyan at gmail dot com
2013-08-05 13:10 ` hubicka at ucw dot cz [this message]
2013-08-05 15:22 ` ysrumyan at gmail dot com
2013-08-06 16:28 ` hubicka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57602-4-HtUmoST6Sz@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).