public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/57670] New: Member-pointer calls should not be redirected to builtin_unreachable
@ 2013-06-21 13:48 jamborm at gcc dot gnu.org
2013-06-21 13:49 ` [Bug middle-end/57670] " jamborm at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-06-21 13:48 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57670
Bug ID: 57670
Summary: Member-pointer calls should not be redirected to
builtin_unreachable
Product: gcc
Version: 4.9.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: middle-end
Assignee: unassigned at gcc dot gnu.org
Reporter: jamborm at gcc dot gnu.org
Created attachment 30335
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30335&action=edit
Testcase
We redirect calls to non-functions to builtin_unreachable. However,
we should not do that for member-pointer calls because there we
pattern-match IL which can use integers to do a VMT lookup.
I'm about to test a simple patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug middle-end/57670] Member-pointer calls should not be redirected to builtin_unreachable
2013-06-21 13:48 [Bug middle-end/57670] New: Member-pointer calls should not be redirected to builtin_unreachable jamborm at gcc dot gnu.org
@ 2013-06-21 13:49 ` jamborm at gcc dot gnu.org
2013-06-24 22:11 ` jamborm at gcc dot gnu.org
2013-06-27 13:16 ` jamborm at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-06-21 13:49 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57670
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2013-06-21
Assignee|unassigned at gcc dot gnu.org |jamborm at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #1 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Mine.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug middle-end/57670] Member-pointer calls should not be redirected to builtin_unreachable
2013-06-21 13:48 [Bug middle-end/57670] New: Member-pointer calls should not be redirected to builtin_unreachable jamborm at gcc dot gnu.org
2013-06-21 13:49 ` [Bug middle-end/57670] " jamborm at gcc dot gnu.org
@ 2013-06-24 22:11 ` jamborm at gcc dot gnu.org
2013-06-27 13:16 ` jamborm at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-06-24 22:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57670
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/gcc-p
| |atches/2013-06/msg01403.htm
| |l
--- Comment #2 from Martin Jambor <jamborm at gcc dot gnu.org> ---
The subject of the email should have been "Do not turn member pointer
CALLS to builtin_unreachable" but nevertheless I have submitted a fix
to the mailing list:
http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01403.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug middle-end/57670] Member-pointer calls should not be redirected to builtin_unreachable
2013-06-21 13:48 [Bug middle-end/57670] New: Member-pointer calls should not be redirected to builtin_unreachable jamborm at gcc dot gnu.org
2013-06-21 13:49 ` [Bug middle-end/57670] " jamborm at gcc dot gnu.org
2013-06-24 22:11 ` jamborm at gcc dot gnu.org
@ 2013-06-27 13:16 ` jamborm at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-06-27 13:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57670
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Author: jamborm
Date: Tue Jun 25 11:09:21 2013
New Revision: 200393
URL: http://gcc.gnu.org/viewcvs?rev=200393&root=gcc&view=rev
Log:
2013-06-25 Martin Jambor <mjambor@suse.cz>
PR middle-end/57670
* cgraph.h (cgraph_indirect_call_info): New flag member_ptr.
* ipa-prop.c (ipa_print_node_jump_functions): Mark member pointer
calls in the dump.
(ipa_note_param_call): Initialize member_ptr flag.
(ipa_analyze_indirect_call_uses): Set member_ptr flag.
(ipa_make_edge_direct_to_target): Bail out if member_ptr is set.
(ipa_write_indirect_edge_info): Stream member_ptr flag.
(ipa_read_indirect_edge_info): Likewise.
testsuite/
* g++.dg/ipa/pr57670.C (H): New test.
Added:
trunk/gcc/testsuite/g++.dg/ipa/pr57670.C
Modified:
trunk/gcc/ChangeLog
trunk/gcc/cgraph.h
trunk/gcc/ipa-prop.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-27 13:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-21 13:48 [Bug middle-end/57670] New: Member-pointer calls should not be redirected to builtin_unreachable jamborm at gcc dot gnu.org
2013-06-21 13:49 ` [Bug middle-end/57670] " jamborm at gcc dot gnu.org
2013-06-24 22:11 ` jamborm at gcc dot gnu.org
2013-06-27 13:16 ` jamborm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).