[Bug c/57692] New: FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[Bug c/57692] New: FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

            Bug ID: 57692
           Summary: FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: bviyer at gcc dot gnu.org

The test c-c++-common/cilk-plus/AN/gather_scatter.c fails for both C and C++
(see http://gcc.gnu.org/ml/gcc-testresults/2013-06/msg02301.html ).

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

Steve Ellcey <sje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sje at gcc dot gnu.org

--- Comment #1 from Steve Ellcey <sje at gcc dot gnu.org> ---
I see this on my MIPS targets as well, I think it is on all platforms.

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-06-24
     Ever confirmed|0                           |1

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I see this on my MIPS targets as well, I think it is on all platforms.

I think so, or at least most of them. This is why I did not fill the Target
field.

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[bviyer at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

--- Comment #3 from Balaji V. Iyer <bviyer at gmail dot com> ---
[sorry, I accidentally hit the send...let's try this again...]

Hello Dominique & Steve,
    From what I can tell, this looks like a stack overflow issue. When I
try this change below, it seem to work fine. This testcase works as-is in
my SUSE x86_64 machine.

Alternatively, if I change the #define NUMBER to like 10 or 20 from 100, it
seem to work fine without the change below.

Please let me know if either of the two changes is OK and I will submit a
patch and check the change in.

Thanks,

Balaji V. Iyer.


diff --git a/gcc/testsuite/c-c++-common/cilk-plus/AN/gather_scatter.c
b/gcc/test
index 9cb16e1..ad05030 100644
--- a/gcc/testsuite/c-c++-common/cilk-plus/AN/gather_scatter.c
+++ b/gcc/testsuite/c-c++-common/cilk-plus/AN/gather_scatter.c
@@ -6,11 +6,11 @@
 #include <stdio.h>
 #endif

+float array4[NUMBER][NUMBER][NUMBER][NUMBER];
 int main(void)
 {
   int array[NUMBER][NUMBER], array2[NUMBER], array3[NUMBER], x = 0, y;
-  int x_correct, y_correct, ii, jj = 0;
-  float array4[NUMBER][NUMBER][NUMBER][NUMBER];
+  int x_correct, y_correct, ii, jj = 0, kk = 0, ll = 0;
   for (ii = 0; ii < NUMBER; ii++)
     {
       for (jj = 0; jj < NUMBER; jj++)
@@ -20,7 +20,10 @@ int main(void)
          array3[ii]= 3;
        }
     }





On Mon, Jun 24, 2013 at 11:07 PM, Balaji V. Iyer <bviyer@gmail.com> wrote:

> Hello Dominique and Steve,
>
>
>
> On Mon, Jun 24, 2013 at 7:24 PM, dominiq at lps dot ens.fr <
> gcc-bugzilla@gcc.gnu.org> wrote:
>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692
>>
>> Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
>>
>>            What    |Removed                     |Added
>>
>> ----------------------------------------------------------------------------
>>              Status|UNCONFIRMED                 |NEW
>>    Last reconfirmed|                            |2013-06-24
>>      Ever confirmed|0                           |1
>>
>> --- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
>> > I see this on my MIPS targets as well, I think it is on all platforms.
>>
>> I think so, or at least most of them. This is why I did not fill the
>> Target
>> field.
>>
>> --
>> You are receiving this mail because:
>> You are on the CC list for the bug.
>>
>
>

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[bviyer at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

--- Comment #4 from Balaji V. Iyer <bviyer at gmail dot com> ---
Hello Dominique and Steve,



On Mon, Jun 24, 2013 at 7:24 PM, dominiq at lps dot ens.fr <
gcc-bugzilla@gcc.gnu.org> wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692
>
> Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|UNCONFIRMED                 |NEW
>    Last reconfirmed|                            |2013-06-24
>      Ever confirmed|0                           |1
>
> --- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > I see this on my MIPS targets as well, I think it is on all platforms.
>
> I think so, or at least most of them. This is why I did not fill the Target
> field.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
This change fixed the failures for me:

--- a/gcc/testsuite/c-c++-common/cilk-plus/AN/gather_scatter.c
+++ b/gcc/testsuite/c-c++-common/cilk-plus/AN/gather_scatter.c
@@ -6,11 +6,11 @@
 #include <stdio.h>
 #endif

+float array4[NUMBER][NUMBER][NUMBER][NUMBER];
 int main(void)
 {
   int array[NUMBER][NUMBER], array2[NUMBER], array3[NUMBER], x = 0, y;
-  int x_correct, y_correct, ii, jj = 0;
-  float array4[NUMBER][NUMBER][NUMBER][NUMBER];
+  int x_correct, y_correct, ii, jj = 0, kk = 0, ll = 0;
   for (ii = 0; ii < NUMBER; ii++)
     {
       for (jj = 0; jj < NUMBER; jj++)

Thanks for the fix.

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

--- Comment #6 from Steve Ellcey <sje at gcc dot gnu.org> ---
The patch in comment #3 worked for me as well.

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Let's fix this testcase, please.

[Bug c/57692] FAIL: c-c++-common/cilk-plus/AN/gather_scatter.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57692

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Fixed by revision 200414

Author:    bviyer
Date:    Wed Jun 26 02:31:27 2013 UTC (3 days, 10 hours ago)
Changed paths:    2
Log Message:    
+2013-06-25  Balaji V. Iyer  <balaji.v.iyer@intel.com>
+    
+       * c-c++-common/cilk-plus/AN/gather_scatter.c: Fixed a bug of stack
+       overflow due to size of arrays.
+