public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/57698] rev.200179 causes many errors (inlining failures) when building Firefox
Date: Tue, 25 Jun 2013 10:20:00 -0000	[thread overview]
Message-ID: <bug-57698-4-ebxzkBREoh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57698-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57698

--- Comment #3 from Jan Hubicka <hubicka at ucw dot cz> ---
Hmm,
the problem here is that we output errors after early inlining always now,
while previously we did
only when some other inlining happened in the function (adding extra early
inlinable function
to the testcase should reproduce the error message on early GCC releases).
We can fix by outputting always inline errors only after real inliner was run
(when optimizing)
but then such testcases won't compile at -O0 that is uncol too.

Other alternatives include declaring such testcases invalid, always not
outputting diagnostic on
previously indirect calls, teaching always inliner to do indirect inlining
(that will need to
do analysis at -O0), adding disregard_inline_limits attribute...

Each of these has pros and cons...


  parent reply	other threads:[~2013-06-25 10:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 11:25 [Bug tree-optimization/57698] New: " markus at trippelsdorf dot de
2013-06-24 18:03 ` [Bug tree-optimization/57698] " hubicka at gcc dot gnu.org
2013-06-25  9:19 ` markus at trippelsdorf dot de
2013-06-25 10:20 ` hubicka at ucw dot cz [this message]
2013-06-26 15:27 ` marxin.liska at gmail dot com
2013-07-08 12:26 ` kpet at free dot fr
2013-07-08 13:16 ` markus at trippelsdorf dot de
2013-07-12  1:57 ` tmsriram at google dot com
2013-07-12  2:10 ` tmsriram at google dot com
2013-07-18 17:21 ` hubicka at gcc dot gnu.org
2013-07-18 22:07 ` tmsriram at google dot com
2013-07-19  4:57 ` markus at trippelsdorf dot de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-57698-4-ebxzkBREoh@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).