public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tmsriram at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/57698] rev.200179 causes many errors (inlining failures) when building Firefox
Date: Fri, 12 Jul 2013 02:10:00 -0000 [thread overview]
Message-ID: <bug-57698-4-lpP2rFNGca@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-57698-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57698
--- Comment #8 from Sriraman Tallam <tmsriram at google dot com> ---
One other alternative to the patch proposed earlier. The reported bug happens
only when optimization is turned on as the early inliner pass invokes
incremental inlining which calls optimize_inline_calls and triggers the above
failure. So, the fix is then as simple as:
Index: tree-inline.c
===================================================================
--- tree-inline.c (revision 200912)
+++ tree-inline.c (working copy)
@@ -3905,6 +3905,10 @@ expand_call_inline (basic_block bb, gimple stmt, c
for inlining, but we can't do that because frontends overwrite
the body. */
&& !cg_edge->callee->local.redefined_extern_inline
+ /* During early inline pass, report only when optimization is
+ not turned on. */
+ && (cgraph_global_info_ready
+ || !optimize)
/* PR 20090218-1_0.c. Body can be provided by another module. */
&& (reason != CIF_BODY_NOT_AVAILABLE || !flag_generate_lto))
{
Seems like the right fix to me. Ok?
next prev parent reply other threads:[~2013-07-12 2:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 11:25 [Bug tree-optimization/57698] New: " markus at trippelsdorf dot de
2013-06-24 18:03 ` [Bug tree-optimization/57698] " hubicka at gcc dot gnu.org
2013-06-25 9:19 ` markus at trippelsdorf dot de
2013-06-25 10:20 ` hubicka at ucw dot cz
2013-06-26 15:27 ` marxin.liska at gmail dot com
2013-07-08 12:26 ` kpet at free dot fr
2013-07-08 13:16 ` markus at trippelsdorf dot de
2013-07-12 1:57 ` tmsriram at google dot com
2013-07-12 2:10 ` tmsriram at google dot com [this message]
2013-07-18 17:21 ` hubicka at gcc dot gnu.org
2013-07-18 22:07 ` tmsriram at google dot com
2013-07-19 4:57 ` markus at trippelsdorf dot de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-57698-4-lpP2rFNGca@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).