From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30644 invoked by alias); 25 Jun 2014 07:41:59 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 30593 invoked by uid 48); 25 Jun 2014 07:41:53 -0000 From: "Joost.VandeVondele at mat dot ethz.ch" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/57742] memset(malloc(n),0,n) -> calloc(n,1) Date: Wed, 25 Jun 2014 07:41:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: Joost.VandeVondele at mat dot ethz.ch X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.10.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-06/txt/msg01925.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D57742 Joost VandeVondele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #18 from Joost VandeVondele --- The following now fails, so'll reopen this PR. It is at least related to zeroing pvec twice in a row, and doesn seem to happen if I manually inline = the routine get_pseudo_param . > cat bug.f90 MODULE atom_fit INTEGER, PARAMETER :: dp=3D8 CONTAINS SUBROUTINE atom_fit_pseudo () REAL(KIND=3Ddp), ALLOCATABLE, DIMENSION(:) :: x, xi LOGICAL :: lsdpot ALLOCATE(xi(200),STAT=3Dierr) CALL get_pseudo_param(xi,lsdpot) CALL foo(xi) END SUBROUTINE atom_fit_pseudo SUBROUTINE get_pseudo_param (pvec,lsdpot) REAL(KIND=3Ddp), DIMENSION(:), INTENT(out) :: pvec LOGICAL :: lsdpot IF(lsdpot) THEN pvec =3D 0 pvec =3D 0 END IF END SUBROUTINE get_pseudo_param END MODULE atom_fit > gfortran -c -O3 bug.f90 bug.f90: In function =E2=80=98atom_fit_pseudo=E2=80=99: bug.f90:4:0: internal compiler error: Segmentation fault SUBROUTINE atom_fit_pseudo () ^ 0xa63a0f crash_signal ../../gcc/gcc/toplev.c:337 0x871f76 bb_seq_addr ../../gcc/gcc/gimple.h:1389 0x871f76 gsi_start_bb ../../gcc/gcc/gimple-iterator.h:118 0x871f76 gsi_for_stmt(gimple_statement_base*) ../../gcc/gcc/gimple-iterator.c:620 0xbfe1c1 handle_builtin_memset ../../gcc/gcc/tree-ssa-strlen.c:1653 0xbfe1c1 strlen_optimize_stmt ../../gcc/gcc/tree-ssa-strlen.c:1917 0xbfe1c1 strlen_dom_walker::before_dom_children(basic_block_def*) ../../gcc/gcc/tree-ssa-strlen.c:2096 0xfa483a dom_walker::walk(basic_block_def*) ../../gcc/gcc/domwalk.c:177 0xbf963d execute ../../gcc/gcc/tree-ssa-strlen.c:2170 Please submit a full bug report, >>From gcc-bugs-return-454844-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jun 25 07:44:04 2014 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 31898 invoked by alias); 25 Jun 2014 07:44:04 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 31860 invoked by uid 48); 25 Jun 2014 07:44:00 -0000 From: "glisse at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/57742] memset(malloc(n),0,n) -> calloc(n,1) Date: Wed, 25 Jun 2014 07:44:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: glisse at gcc dot gnu.org X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.10.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-06/txt/msg01926.txt.bz2 Content-length: 1486 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57742 --- Comment #19 from Marc Glisse --- (In reply to Joost VandeVondele from comment #17) > Thanks Marc, I don't have write access, but I can try to dg-ify the testcase > from comment #3.. however, first test, it still seems to contain a call to > builtin_malloc at -O2, seems to work at -O3... expected ? Yes, at -O2 you don't have a call to memset, so my patch does nothing. It is the same as my C++ testcase basically, so we don't really need the extra testcase. > Also, my nightly CP2K tester fails with : > > 0xa63a0f crash_signal > ../../gcc/gcc/toplev.c:337 > 0x871f76 bb_seq_addr > ../../gcc/gcc/gimple.h:1389 > 0x871f76 gsi_start_bb > ../../gcc/gcc/gimple-iterator.h:118 > 0x871f76 gsi_for_stmt(gimple_statement_base*) > ../../gcc/gcc/gimple-iterator.c:620 > 0xbfe1c1 handle_builtin_memset > ../../gcc/gcc/tree-ssa-strlen.c:1653 > 0xbfe1c1 strlen_optimize_stmt > ../../gcc/gcc/tree-ssa-strlen.c:1917 > 0xbfe1c1 strlen_dom_walker::before_dom_children(basic_block_def*) > ../../gcc/gcc/tree-ssa-strlen.c:2096 > 0xfa483a dom_walker::walk(basic_block_def*) > ../../gcc/gcc/domwalk.c:177 > 0xbf963d execute > ../../gcc/gcc/tree-ssa-strlen.c:2170 > Please submit a full bug report, > > which I suppose is related to this patch... I'll see if I can get a testcase. Yes, please open a new PR with the testcase and Cc: me, thanks.