From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11243 invoked by alias); 3 Jul 2013 06:56:58 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 10931 invoked by uid 48); 3 Jul 2013 06:56:52 -0000 From: "burnus at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/57791] Waste work in gfc_check_pointer_assign() Date: Wed, 03 Jul 2013 06:56:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: patch X-Bugzilla-Severity: normal X-Bugzilla-Who: burnus at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-07/txt/msg00142.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57791 Tobias Burnus changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |burnus at gcc dot gnu.org --- Comment #1 from Tobias Burnus --- (In reply to Po-Chun Chang from comment #0) > Suggested patch > > In method "gfc_check_pointer_assign()" in expr.c, the loop on line 3763 > should break immediately after "warn" is set to "true". All the iterations > after "warn" set to "true" do not perform any useful work, at best they just > set "warn" again to "true". I concur. (Note that the nesting depth is rather shallow [one or two, rarely three and essentially never four or more] and only pointer comparisons are done, which is computationally cheap. Thus, the current version doesn't waste many cycles.)