* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
@ 2013-07-11 9:23 ` paolo.carlini at oracle dot com
2013-07-22 9:46 ` paolo.carlini at oracle dot com
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-11 9:23 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |emsr at gcc dot gnu.org
Component|c |c++
--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Indeed something seems wrong. CC-ing Ed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
2013-07-11 9:23 ` [Bug c++/57880] " paolo.carlini at oracle dot com
@ 2013-07-22 9:46 ` paolo.carlini at oracle dot com
2013-07-22 15:42 ` dcb314 at hotmail dot com
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-22 9:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Ed?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
2013-07-11 9:23 ` [Bug c++/57880] " paolo.carlini at oracle dot com
2013-07-22 9:46 ` paolo.carlini at oracle dot com
@ 2013-07-22 15:42 ` dcb314 at hotmail dot com
2013-07-22 15:51 ` paolo.carlini at oracle dot com
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dcb314 at hotmail dot com @ 2013-07-22 15:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Paolo Carlini from comment #2)
> Ed?
He's had eleven days to think about it and said nothing.
I'd be happy to supply the obvious patch.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (2 preceding siblings ...)
2013-07-22 15:42 ` dcb314 at hotmail dot com
@ 2013-07-22 15:51 ` paolo.carlini at oracle dot com
2013-07-24 14:06 ` dcb314 at hotmail dot com
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-22 15:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Maybe he is simply traveling or unable to read email, don't you think?
Still, if you want to send a patch to the mailing list, of course it's fine.
For a quicker review, I would recommend CC-ing Jason and adding [C++ Patch] to
the subject line. Thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (3 preceding siblings ...)
2013-07-22 15:51 ` paolo.carlini at oracle dot com
@ 2013-07-24 14:06 ` dcb314 at hotmail dot com
2013-07-24 14:09 ` dcb314 at hotmail dot com
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dcb314 at hotmail dot com @ 2013-07-24 14:06 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #5 from David Binderman <dcb314 at hotmail dot com> ---
Created attachment 30545
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30545&action=edit
source code patch
This patch seems to shut up cppcheck.
I did a bootstrap and that seemed ok.
It seems good to go to me.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (4 preceding siblings ...)
2013-07-24 14:06 ` dcb314 at hotmail dot com
@ 2013-07-24 14:09 ` dcb314 at hotmail dot com
2013-07-24 14:47 ` redi at gcc dot gnu.org
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dcb314 at hotmail dot com @ 2013-07-24 14:09 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #6 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Paolo Carlini from comment #4)
> For a quicker review, I would recommend CC-ing Jason and adding [C++ Patch]
> to the subject line.
I'm not on the inner wheel for C++ patches, so I am guessing that
you mean Jason Merrill.
If so, is jason at redhat dot com a good email address for him ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (5 preceding siblings ...)
2013-07-24 14:09 ` dcb314 at hotmail dot com
@ 2013-07-24 14:47 ` redi at gcc dot gnu.org
2013-07-24 15:36 ` paolo.carlini at oracle dot com
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: redi at gcc dot gnu.org @ 2013-07-24 14:47 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes, or at gcc.gnu.org
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (6 preceding siblings ...)
2013-07-24 14:47 ` redi at gcc dot gnu.org
@ 2013-07-24 15:36 ` paolo.carlini at oracle dot com
2013-07-24 15:36 ` paolo.carlini at oracle dot com
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-24 15:36 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> ---
If we have a straightforward explanation for why the very weird code isn't
causing problems, I think the fix almost qualifies as obvious, if properly
tested. Do we? Does it only amount to a small memory leak or a small buffer
overrun, something similar? In any case, yes, gcc-patches@ CC Jason Merrill
(there aren't *that* many C++ maintainers on gcc-patches named Jason ;)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (7 preceding siblings ...)
2013-07-24 15:36 ` paolo.carlini at oracle dot com
@ 2013-07-24 15:36 ` paolo.carlini at oracle dot com
2013-07-24 19:02 ` paolo.carlini at oracle dot com
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-24 15:36 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2013-07-24
Ever confirmed|0 |1
--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> ---
If we have a straightforward explanation for why the very weird code isn't
causing problems, I think the fix almost qualifies as obvious, if properly
tested. Do we? Does it only amount to a small memory leak or a small buffer
overrun, something similar? In any case, yes, gcc-patches@ CC Jason Merrill
(there aren't *that* many C++ maintainers on gcc-patches named Jason ;)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (8 preceding siblings ...)
2013-07-24 15:36 ` paolo.carlini at oracle dot com
@ 2013-07-24 19:02 ` paolo.carlini at oracle dot com
2013-07-25 15:05 ` paolo.carlini at oracle dot com
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-24 19:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |paolo.carlini at oracle dot com
--- Comment #10 from Paolo Carlini <paolo.carlini at oracle dot com> ---
I had a closer look and I don't think the proposed patchlet is correct: for,
eg, case CPP_WSTRING we want string_len = 3 and then fall through to the
checks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (9 preceding siblings ...)
2013-07-24 19:02 ` paolo.carlini at oracle dot com
@ 2013-07-25 15:05 ` paolo.carlini at oracle dot com
2013-07-25 18:21 ` dcb314 at hotmail dot com
2013-07-25 18:32 ` paolo.carlini at oracle dot com
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-25 15:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.9.0
--- Comment #11 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Fixed for 4.9.0.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (10 preceding siblings ...)
2013-07-25 15:05 ` paolo.carlini at oracle dot com
@ 2013-07-25 18:21 ` dcb314 at hotmail dot com
2013-07-25 18:32 ` paolo.carlini at oracle dot com
12 siblings, 0 replies; 14+ messages in thread
From: dcb314 at hotmail dot com @ 2013-07-25 18:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #12 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Paolo Carlini from comment #11)
> Fixed for 4.9.0.
Good news. Worth referencing the patch that fixed it ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/57880] cp/parser.c: 6 * missing break ?
2013-07-11 7:39 [Bug c/57880] New: cp/parser.c: 6 * missing break ? dcb314 at hotmail dot com
` (11 preceding siblings ...)
2013-07-25 18:21 ` dcb314 at hotmail dot com
@ 2013-07-25 18:32 ` paolo.carlini at oracle dot com
12 siblings, 0 replies; 14+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-07-25 18:32 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57880
--- Comment #13 from Paolo Carlini <paolo.carlini at oracle dot com> ---
I added c++/57880 to the svn CL. Sorry, I'm not going to reference by hand each
and every patch I commit (svn should do it automatically, send a message to
Bugzilla, as it used to).
^ permalink raw reply [flat|nested] 14+ messages in thread