public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/57904] [4.9 Regression] Bogus(?) "invokes undefined behavior" warning with Fortran's finalization wrapper (gfortran.dg/class_48.f90) Date: Fri, 20 Dec 2013 19:22:00 -0000 [thread overview] Message-ID: <bug-57904-4-3jslwe1lf2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-57904-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57904 --- Comment #14 from Jeffrey A. Law <law at redhat dot com> --- So a quick prototype which reuses the infrastructure from the phi-only-propagator cleans things up quite nicely. Given this block after substitute_and_fold does its thing: <bb 2>: ubound.0_3 = 0; size.1_4 = ubound.0_3 + 1; size.1_5 = MAX_EXPR <size.1_4, 0>; _6 = size.1_5 * 4; _7 = (character(kind=4)) _6; _8 = MAX_EXPR <_7, 1>; sizes_9 = __builtin_malloc (_8); size.3_10 = MAX_EXPR <ubound.0_3, 0>; _11 = size.3_10 * 4; _12 = (character(kind=4)) _11; _13 = MAX_EXPR <_12, 1>; strides_14 = __builtin_malloc (_13); MEM[(integer(kind=4)[0:D.1917] *)sizes_9][0] = 1; if (ubound.0_3 > 0) goto <bb 3>; else goto <bb 6>; I (manually) seed the phi-only propagator's 2nd step with _3 as being a newly exposed destination of a copy/constant initialization and let that trivial propagator do its thing... Resulting in: <bb 2>: sizes_9 = __builtin_malloc (4); strides_14 = __builtin_malloc (1); MEM[(integer(kind=4)[0:D.1917] *)sizes_9][0] = 1; goto <bb 6>; Which is exactly what we want. Also note that we collapse the conditional at the end of the block. That in turn makes the problematic loop unreachable and it goes away as one would expect. The problem I see is I'd prefer not to expose this in substitute_and_fold directly. That routine is used by multiple propagators. I'm thinking that instead we can have a callback to the pass utilizing substitute_and_fold that gets called when something has folded.
next prev parent reply other threads:[~2013-12-20 19:22 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-16 9:05 [Bug fortran/57904] New: " burnus at gcc dot gnu.org 2013-07-23 19:53 ` [Bug fortran/57904] " jamborm at gcc dot gnu.org 2013-08-09 12:53 ` ro at gcc dot gnu.org 2013-08-19 23:03 ` [Bug fortran/57904] [4.9 Regression] " hp at gcc dot gnu.org 2013-08-20 17:40 ` bernd.edlinger at hotmail dot de 2013-10-30 13:13 ` [Bug middle-end/57904] " rguenth at gcc dot gnu.org 2013-11-27 15:55 ` jakub at gcc dot gnu.org 2013-11-27 15:59 ` Joost.VandeVondele at mat dot ethz.ch 2013-12-19 21:32 ` law at redhat dot com 2013-12-20 5:51 ` bernd.edlinger at hotmail dot de 2013-12-20 6:26 ` law at redhat dot com 2013-12-20 7:21 ` dominiq at lps dot ens.fr 2013-12-20 8:36 ` jakub at gcc dot gnu.org 2013-12-20 9:54 ` bernd.edlinger at hotmail dot de 2013-12-20 19:22 ` law at redhat dot com [this message] 2013-12-20 21:56 ` dominiq at lps dot ens.fr 2013-12-20 21:58 ` dominiq at lps dot ens.fr 2013-12-20 22:27 ` law at redhat dot com 2013-12-20 22:28 ` law at redhat dot com 2014-01-17 17:50 ` law at gcc dot gnu.org 2014-01-17 17:51 ` law at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-57904-4-3jslwe1lf2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).