[Bug rtl-optimization/57921] New: Alias change causes perl from SPEC 2006 to abort on MIPS

[Bug rtl-optimization/57921] New: Alias change causes perl from SPEC 2006 to abort on MIPS

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57921

            Bug ID: 57921
           Summary: Alias change causes perl from SPEC 2006 to abort on
                    MIPS
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sje at gcc dot gnu.org

Created attachment 30517
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30517&action=edit
What the CSE phase generated prior to checkin r200133

With the latest GCC (as of version r200133) the perl benchmark in SPEC 2006 is
failing for me on the mips-linux-gnu target.  The patch that caused it to start
failing is to the alias analysis phase of GCC and it affects the rtl CSE phase
of GCC.  Before this change CSE was generating this RTL:

r234 = address of PL_curpad
r211 = mem[r234]
.
.
r215 = $2 (return pointer from a function)
r237 = mem[r211]
mem[r237+4] = r215
r220 = mem[r237]

The important bit is the last statement where r220 is loaded using the
address in r237.

After the change we have:

r234 = address of PL_curpad
r211 = mem[r234]
.
.
r215 = $2 (return pointer from a function)
r237 = mem[r211]
mem[r237+4] = r215
r238 = mem[r211]
r220 = mem[238]

Instead of reusing r237, we load r238 and use that to load r220.  I believe
that PL_curpad (address in r234) is set up to have the value of its own
address minus 4.  That would mean that when we store to 'mem[r237+4]' we
changed what r238 has vs. what r237 has.  Now this actually seems like it
is more correct then the first version, but the first version worked (I could
compile and run perl) and the second version does not (perl allocate aborts
and goes into an infinite loop).

I can see this change in x86 RTL but the change in code on x86 does not seem
to cause an outward change in the behaviour of perl.  I don't know if GCC
is doing something wrong or if the code in perl is wrong.  I have attached
a cutdown test case from Perl_pp_entersub (pp_hot.c) with this bug report.
The code cannot be run but if compiled it shows the RTL differences I describe
above.

[Bug rtl-optimization/57921] Alias change causes perl from SPEC 2006 to abort on MIPS

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57921

--- Comment #1 from Steve Ellcey <sje at gcc dot gnu.org> ---
Created attachment 30518
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30518&action=edit
What the CSE phase generated after checkin r200133

[Bug rtl-optimization/57921] Alias change causes perl from SPEC 2006 to abort on MIPS

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57921

--- Comment #2 from Steve Ellcey <sje at gcc dot gnu.org> ---
Created attachment 30519
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30519&action=edit
Test case cut down from perl benchmark in SPEC 2006

[Bug rtl-optimization/57921] Alias change causes perl from SPEC 2006 to abort on MIPS

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57921

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |alias

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This does look like an alias bug in the source code of perl?

[Bug rtl-optimization/57921] Alias change causes perl from SPEC 2006 to abort on MIPS

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57921

--- Comment #4 from Steve Ellcey <sje at gcc dot gnu.org> ---
Digging around on the SPEC web page led me to this:

http://www.spec.org/cpu2006/Docs/400.perlbench.html

Known portability issues

There are some known aliasing issues. The internal data structures that
represent Perl's variables are accessed in such as a way as to violate ANSI
aliasing rules. Compilation with optimizations that rely on strict compliance
to ANSI C aliasing rules will most likely produce binaries that will not
validate.

[Bug rtl-optimization/57921] Alias change causes perl from SPEC 2006 to abort on MIPS

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57921

Steve Ellcey <sje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #5 from Steve Ellcey <sje at gcc dot gnu.org> ---
Given the SPEC comments about perl not obeying aliasing rules and the fact that
I can compile this correctly with -fno-strict-aliasing I am going to close this
out as 'invalid'  I.e. it is not a GCC bug.

[Bug rtl-optimization/57921] Alias change causes perl from SPEC 2006 to abort on MIPS

[dgilmore at mips dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57921

Doug Gilmore <dgilmore at mips dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dgilmore at mips dot com

--- Comment #6 from Doug Gilmore <dgilmore at mips dot com> ---
I wonder if this should be marked as a duplicate of bug 33383?