From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-426611-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 16180 invoked by alias); 24 Jul 2013 12:17:56 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 16082 invoked by uid 48); 24 Jul 2013 12:17:52 -0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/57966] [OOP] Using a TBP to specify the shape of a dummy argument
Date: Wed, 24 Jul 2013 12:17:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: janus at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status assigned_to
Message-ID: <bug-57966-4-Udko5PIyNX@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-57966-4@http.gcc.gnu.org/bugzilla/>
References: <bug-57966-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-07/txt/msg01118.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57966

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org

--- Comment #2 from janus at gcc dot gnu.org ---
Draft patch (not regtested yet):


Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c    (revision 201038)
+++ gcc/fortran/resolve.c    (working copy)
@@ -5638,14 +5638,6 @@ resolve_compcall (gfc_expr* e, const char **name)
   gfc_actual_arglist* newactual;
   gfc_symtree* target;

-  /* Check that's really a FUNCTION.  */
-  if (!e->value.compcall.tbp->function)
-    {
-      gfc_error ("'%s' at %L should be a FUNCTION",
-         e->value.compcall.name, &e->where);
-      return false;
-    }
-
   /* These must not be assign-calls!  */
   gcc_assert (!e->value.compcall.assign);

@@ -5661,6 +5653,15 @@ resolve_compcall (gfc_expr* e, const char **name)
     return false;
   gcc_assert (!e->value.compcall.tbp->is_generic);

+  /* Check that it's really a FUNCTION.  */
+  if (!e->value.compcall.tbp->function
+      && !e->value.compcall.tbp->u.specific->n.sym->attr.function)
+    {
+      gfc_error ("'%s' at %L should be a FUNCTION",
+         e->value.compcall.name, &e->where);
+      return false;
+    }
+
   /* Take the rank from the function's symbol.  */
   if (e->value.compcall.tbp->u.specific->n.sym->as)
     e->rank = e->value.compcall.tbp->u.specific->n.sym->as->rank;