[Bug fortran/58026] New: internal compiler error: in generate_finalization_wrapper, at fortran/class.c:1521

[Bug fortran/58026] New: internal compiler error: in generate_finalization_wrapper, at fortran/class.c:1521

[Joost.VandeVondele at mat dot ethz.ch]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

            Bug ID: 58026
           Summary: internal compiler error: in
                    generate_finalization_wrapper, at fortran/class.c:1521
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Joost.VandeVondele at mat dot ethz.ch

Following invalid testcase yields and ICE with current trunk.

> cat small.f90
  type sysmtx_t
     type(ext_complex_t), allocatable :: S(:)       ! Block scales
  end type sysmtx_t
contains
  subroutine init (this, n, n_e, n_i, n_o)
    class(sysmtx_t), intent(out) :: this

> gfortran small.f90
small.f90:2.40:

     type(ext_complex_t), allocatable :: S(:)       ! Block scales
                                        1
Error: Derived type at (1) has not been previously defined and so cannot appear
in a derived type definition
f951: internal compiler error: in generate_finalization_wrapper, at
fortran/class.c:1521
0x54f091 generate_finalization_wrapper
    ../../gcc/gcc/fortran/class.c:1520
0x54f091 gfc_find_derived_vtab(gfc_symbol*)
    ../../gcc/gcc/fortran/class.c:2394
0x54fc82 gfc_build_class_symbol(gfc_typespec*, symbol_attribute*,
gfc_array_spec**, bool)

[Bug fortran/58026] [4.9 Regression] internal compiler error: in generate_finalization_wrapper, at fortran/class.c:1521

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-07-30
                 CC|                            |burnus@net-b.de
            Summary|internal compiler error: in |[4.9 Regression] internal
                   |generate_finalization_wrapp |compiler error: in
                   |er, at fortran/class.c:1521 |generate_finalization_wrapp
                   |                            |er, at fortran/class.c:1521
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The ICE has been introduced between revisions 198750 (2013-05-09) and 199418
(2013-05-29): r199409?

[Bug fortran/58026] [4.9 Regression] internal compiler error: in generate_finalization_wrapper, at fortran/class.c:1521

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |error-recovery,
                   |                            |ice-on-invalid-code
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Failing is the following assert in generate_finalization_wrapper:

  /* If there is no new finalizer and no new allocatable, return with
     an expr to the ancestor's one.  */
  if (!expr_null_wrapper && !finalizable_comp
      && (!derived->f2k_derived || !derived->f2k_derived->finalizers))
    {
      gcc_assert (ancestor_wrapper && ancestor_wrapper->ref == NULL
                  && ancestor_wrapper->expr_type == EXPR_VARIABLE);

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janus at gcc dot gnu.org
            Summary|[4.9 Regression] internal   |[4.9 Regression] [OOP] ICE
                   |compiler error: in          |in
                   |generate_finalization_wrapp |generate_finalization_wrapp
                   |er, at fortran/class.c:1521 |er, at fortran/class.c:1521

--- Comment #3 from janus at gcc dot gnu.org ---
Slightly modified test case:


  type sysmtx_t
     type(ext_complex_t), allocatable :: S(:)
  end type
contains
  subroutine init (this)
    class(sysmtx_t) :: this 
  end subroutine
end

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

--- Comment #4 from janus at gcc dot gnu.org ---
Draft patch:

Index: gcc/fortran/decl.c
===================================================================
--- gcc/fortran/decl.c    (revision 201331)
+++ gcc/fortran/decl.c    (working copy)
@@ -4286,12 +4286,10 @@ gfc_match_data_decl (void)
           || current_ts.u.derived->attr.zero_comp))
     goto ok;

-      /* Now we have an error, which we signal, and then fix up
-     because the knock-on is plain and simple confusing.  */
       gfc_error_now ("Derived type at %C has not been previously defined "
              "and so cannot appear in a derived type definition");
-      current_attr.pointer = 1;
-      goto ok;
+      m = MATCH_ERROR;
+      goto cleanup;
     }

 ok:

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

--- Comment #5 from janus at gcc dot gnu.org ---
(In reply to janus from comment #4)
> Draft patch:

... seems to regtest cleanly.

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org

--- Comment #6 from janus at gcc dot gnu.org ---
For the record: The code that I'm proposing to remove in comment 4 has been
added by Paul in r105913:

http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=105913

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to janus from comment #6)
> For the record: The code that I'm proposing to remove in comment 4 has been
> added by Paul in r105913:

For PR24158 (ice-on-invalid-code), which was on 2005-10-26.

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org

--- Comment #8 from janus at gcc dot gnu.org ---
At r206460, I don't see the ICE any more. Possibly is has been fixed by r206379
(for PR59589)? Can someone confirm that it's gone?


The output I now get for comment 3 (with 4.8 and trunk) is as follows:

$ gfortran-4.9 c3.f90 
c3.f90:3.40:

     type(ext_complex_t), allocatable :: S(:)
                                        1
Error: Derived type at (1) has not been previously defined and so cannot appear
in a derived type definition
c3.f90:3.45:

     type(ext_complex_t), allocatable :: S(:)
                                             1
Error: The pointer component 's' of 'sysmtx_t' at (1) is a type that has not
been declared
c3.f90:3.45:

     type(ext_complex_t), allocatable :: S(:)
                                             1
Error: The pointer component 's' of 'sysmtx_t' at (1) is a type that has not
been declared
c3.f90:3.45:

     type(ext_complex_t), allocatable :: S(:)
                                             1
Error: The pointer component 's' of 'sysmtx_t' at (1) is a type that has not
been declared


The first error is perfectly ok, but the following three (about a 'pointer
component') are bogus. They are indeed removed by the patch in comment 4, so I
think applying that patch still makes sense.

[Bug fortran/58026] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper, at fortran/class.c:1521

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

--- Comment #9 from janus at gcc dot gnu.org ---
(In reply to Tobias Burnus from comment #7)
> > For the record: The code that I'm proposing to remove in comment 4 has been
> > added by Paul in r105913:
> 
> For PR24158 (ice-on-invalid-code), which was on 2005-10-26.

Btw: The corresponding test cases are

derived_recursion.f90
implicit_actual.f90

The patch does not change the diagnostics for these cases (in particular there
is no 'confusing knock-on).

[Bug fortran/58026] [OOP] Bad error recovery for allocatable component of undeclared type

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |
            Summary|[4.9 Regression] [OOP] ICE  |[OOP] Bad error recovery
                   |in                          |for allocatable component
                   |generate_finalization_wrapp |of undeclared type
                   |er, at fortran/class.c:1521 |

--- Comment #10 from janus at gcc dot gnu.org ---
(In reply to janus from comment #8)
> At r206460, I don't see the ICE any more. Possibly is has been fixed by
> r206379 (for PR59589)? Can someone confirm that it's gone?

Reverting r206379 brings back the ICE, so indeed this revision has fixed it
apparently.

So: The ICE regression is fixed and only the error-recovery problem of comment
8 persists.

[Bug fortran/58026] [OOP] Bad error recovery for allocatable component of undeclared type

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

--- Comment #11 from janus at gcc dot gnu.org ---
Further reduced test case for the error recovery:

type sysmtx_t
   type(ext_complex_t), allocatable :: S(:)
end type
end


Trunk (and 4.4 - 4.8) yield:


c3.f90:3.40:

     type(ext_complex_t), allocatable :: S(:)
                                        1
Error: Derived type at (1) has not been previously defined and so cannot appear
in a derived type definition
c3.f90:3.45:

     type(ext_complex_t), allocatable :: S(:)
                                             1
Error: The pointer component 's' of 'sysmtx_t' at (1) is a type that has not
been declared



With the patch in comment 4 the second error, which is bogus, is removed.

[Bug fortran/58026] [F03] Bad error recovery for allocatable component of undeclared type

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

--- Comment #12 from janus at gcc dot gnu.org ---
Author: janus
Date: Sun Jan 12 11:08:31 2014
New Revision: 206564

URL: http://gcc.gnu.org/viewcvs?rev=206564&root=gcc&view=rev
Log:
2014-01-12  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/58026
    * decl.c (gfc_match_data_decl): Improve error recovery.


2014-01-12  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/58026
    * gfortran.dg/alloc_comp_basics_6.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_basics_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/58026] [F03] Bad error recovery for allocatable component of undeclared type

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58026

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from janus at gcc dot gnu.org ---
(In reply to janus from comment #10)
> So: The ICE regression is fixed and only the error-recovery problem of
> comment 8 persists.

... which is fixed on 4.9 trunk by r206564. Closing.