public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "grosser at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/58028] [4.9 Regression] Several failures in libgomp.graphite after revision 200946 Date: Wed, 29 Jan 2014 12:52:00 -0000 [thread overview] Message-ID: <bug-58028-4-Ev143Bpdws@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-58028-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58028 --- Comment #9 from Tobias Grosser <grosser at gcc dot gnu.org> --- (In reply to rguenther@suse.de from comment #8) > On Wed, 29 Jan 2014, dominiq at lps dot ens.fr wrote: > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58028 > > > > --- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> --- > > > The testsuite failures are. We have to do sth about them. > > > > Revert r200946? > > Probably - the > > + * graphite-dependences.c (carries_deps): Do not assume the > schedule is > + in 2D + 1 form. > > part looks wrong. > > - idx = 2 * depth + 1; > - for (i = 0; i < idx; i++) > + for (i = 0; i < depth - 1; i++) > > we now iterate over less dimensions than before. Only in cases where the schedule is not in 2D + 1 form. In case the schedule is in 2D + 1 form int scheduling_dim = isl_set_n_dim (domain); will be equal to 2 * depth + 1. > I'd say we should simply check whether the loop _is_ in 2D + 1 form > at > > + isl_set *domain = isl_set_from_cloog_domain (stmt->domain); > + int scheduling_dim = isl_set_n_dim (domain); > + > if (flag_loop_parallelize_all > - && loop_is_parallel_p (loop, bb_pbb_mapping, level)) > + && loop_is_parallel_p (loop, bb_pbb_mapping, scheduling_dim)) > loop->can_be_parallel = true; > > thus > > if (flag_loop_parallelize_all > && scheduling_dim == 2 * level + 1 > && loop_is_parallel_p (loop, bb_pbb_mapping, level) > loop->can_be_parallel = true; The change you propose seems conservatively correct, as in that loops that are not in 2D + 1 form are not detected to be parallel. This change may hide the bug, but I don't see any bug it solves. > no time to check whether reverting the other hunk plus this will > resolve the bug the revision fixed and restores the testcases. I assume it will fix the crash, but it will not detect parallellism in none 2D+1 loops, something the isl scheduler happily creates.
next prev parent reply other threads:[~2014-01-29 12:52 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-30 13:20 [Bug tree-optimization/58028] New: " dominiq at lps dot ens.fr 2013-08-09 13:02 ` [Bug tree-optimization/58028] " ro at gcc dot gnu.org 2013-10-30 13:18 ` rguenth at gcc dot gnu.org 2013-11-10 20:42 ` dominiq at lps dot ens.fr 2013-11-11 9:15 ` rguenth at gcc dot gnu.org 2013-11-20 11:58 ` graham at opengamma dot com 2014-01-29 11:59 ` jakub at gcc dot gnu.org 2014-01-29 12:03 ` rguenth at gcc dot gnu.org 2014-01-29 12:09 ` dominiq at lps dot ens.fr 2014-01-29 12:40 ` rguenther at suse dot de 2014-01-29 12:52 ` grosser at gcc dot gnu.org [this message] 2014-01-29 14:03 ` rguenther at suse dot de 2014-02-03 15:33 ` grosser at gcc dot gnu.org 2014-02-04 9:49 ` rguenth at gcc dot gnu.org 2014-03-03 11:40 ` rguenth at gcc dot gnu.org 2014-03-03 11:40 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-58028-4-Ev143Bpdws@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).