public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wschmidt at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/58041] Unaligned access to arrays in packed structure
Date: Thu, 01 Aug 2013 18:32:00 -0000	[thread overview]
Message-ID: <bug-58041-4-GGotIeQa4N@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58041-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58041

--- Comment #15 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Bernd, Mikael, Martin:  Could you please test this on your respective targets?

Index: gcc/gimple-ssa-strength-reduction.c
===================================================================
--- gcc/gimple-ssa-strength-reduction.c    (revision 201413)
+++ gcc/gimple-ssa-strength-reduction.c    (working copy)
@@ -845,6 +845,8 @@ slsr_process_ref (gimple gs)
   int unsignedp, volatilep;
   double_int index;
   slsr_cand_t c;
+  unsigned HOST_WIDE_INT misalign;
+  unsigned align;

   if (gimple_vdef (gs))
     ref_expr = gimple_assign_lhs (gs);
@@ -857,6 +859,16 @@ slsr_process_ref (gimple gs)
       && DECL_BIT_FIELD (TREE_OPERAND (ref_expr, 1))))
     return;

+  /* If this reference doesn't meet alignment restrictions, don't
+     make it a candidate.  */
+  get_object_alignment_1 (ref_expr, &align, &misalign);
+
+  if (misalign != 0)
+    align = (misalign & -misalign);
+
+  if (align < TYPE_ALIGN (TREE_TYPE (ref_expr)))
+    return;
+
   base = get_inner_reference (ref_expr, &bitsize, &bitpos, &offset, &mode,
                   &unsignedp, &volatilep, false);
   index = double_int::from_uhwi (bitpos);

Thanks,
Bill


  parent reply	other threads:[~2013-08-01 18:32 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01  7:26 [Bug middle-end/58041] New: " bernd.edlinger at hotmail dot de
2013-08-01  7:31 ` [Bug middle-end/58041] " bernd.edlinger at hotmail dot de
2013-08-01  9:09 ` mikpe at it dot uu.se
2013-08-01 11:36 ` mikpe at it dot uu.se
2013-08-01 11:51 ` mikpe at it dot uu.se
2013-08-01 13:26 ` wschmidt at gcc dot gnu.org
2013-08-01 16:18 ` wschmidt at gcc dot gnu.org
2013-08-01 16:23 ` jamborm at gcc dot gnu.org
2013-08-01 16:48 ` jamborm at gcc dot gnu.org
2013-08-01 17:27 ` jamborm at gcc dot gnu.org
2013-08-01 17:49 ` wschmidt at gcc dot gnu.org
2013-08-01 17:54 ` wschmidt at gcc dot gnu.org
2013-08-01 18:17 ` bernd.edlinger at hotmail dot de
2013-08-01 18:29 ` wschmidt at gcc dot gnu.org
2013-08-01 18:32 ` wschmidt at gcc dot gnu.org [this message]
2013-08-01 19:09 ` bernd.edlinger at hotmail dot de
2013-08-01 19:20 ` wschmidt at gcc dot gnu.org
2013-08-01 19:36 ` mikpe at it dot uu.se
2013-08-01 23:06 ` jamborm at gcc dot gnu.org
2013-08-02 15:22 ` wschmidt at gcc dot gnu.org
2013-08-02 15:28 ` wschmidt at gcc dot gnu.org
2013-08-02 15:54 ` ebotcazou at gcc dot gnu.org
2013-08-02 16:06 ` wschmidt at gcc dot gnu.org
2013-08-02 16:58 ` jamborm at gcc dot gnu.org
2013-08-02 17:12 ` wschmidt at gcc dot gnu.org
2013-08-02 18:07 ` wschmidt at gcc dot gnu.org
2013-08-03  8:31 ` bernd.edlinger at hotmail dot de
2013-08-05 17:43 ` jamborm at gcc dot gnu.org
2013-08-06 11:59 ` jamborm at gcc dot gnu.org
2013-08-06 14:24 ` bernd.edlinger at hotmail dot de
2013-08-06 15:18 ` jamborm at gcc dot gnu.org
2013-08-06 15:19 ` jamborm at gcc dot gnu.org
2013-08-06 15:33 ` bernd.edlinger at hotmail dot de
2013-08-06 15:56 ` bernd.edlinger at hotmail dot de
2013-08-06 16:06 ` jamborm at gcc dot gnu.org
2013-08-06 16:12 ` bernd.edlinger at hotmail dot de
2013-08-06 16:36 ` bernd.edlinger at hotmail dot de
2013-08-06 16:59 ` jamborm at gcc dot gnu.org
2013-08-06 17:07 ` bernd.edlinger at hotmail dot de
2013-08-06 17:37 ` jamborm at gcc dot gnu.org
2013-08-06 18:19 ` wschmidt at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-58041-4-GGotIeQa4N@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).