From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8852 invoked by alias); 1 Aug 2013 18:32:26 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 8771 invoked by uid 48); 1 Aug 2013 18:32:24 -0000 From: "wschmidt at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/58041] Unaligned access to arrays in packed structure Date: Thu, 01 Aug 2013 18:32:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wschmidt at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: wschmidt at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-08/txt/msg00046.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58041 --- Comment #15 from Bill Schmidt --- Bernd, Mikael, Martin: Could you please test this on your respective targets? Index: gcc/gimple-ssa-strength-reduction.c =================================================================== --- gcc/gimple-ssa-strength-reduction.c (revision 201413) +++ gcc/gimple-ssa-strength-reduction.c (working copy) @@ -845,6 +845,8 @@ slsr_process_ref (gimple gs) int unsignedp, volatilep; double_int index; slsr_cand_t c; + unsigned HOST_WIDE_INT misalign; + unsigned align; if (gimple_vdef (gs)) ref_expr = gimple_assign_lhs (gs); @@ -857,6 +859,16 @@ slsr_process_ref (gimple gs) && DECL_BIT_FIELD (TREE_OPERAND (ref_expr, 1)))) return; + /* If this reference doesn't meet alignment restrictions, don't + make it a candidate. */ + get_object_alignment_1 (ref_expr, &align, &misalign); + + if (misalign != 0) + align = (misalign & -misalign); + + if (align < TYPE_ALIGN (TREE_TYPE (ref_expr))) + return; + base = get_inner_reference (ref_expr, &bitsize, &bitpos, &offset, &mode, &unsignedp, &volatilep, false); index = double_int::from_uhwi (bitpos); Thanks, Bill