public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/58041] Unaligned access to arrays in packed structure
Date: Fri, 02 Aug 2013 16:58:00 -0000 [thread overview]
Message-ID: <bug-58041-4-RzIo8B0Vhs@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58041-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58041
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|wschmidt at gcc dot gnu.org |jamborm at gcc dot gnu.org
--- Comment #24 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Created attachment 30594
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30594&action=edit
Proposed patch
(In reply to Bill Schmidt from comment #20)
> After thinking it over some more, I think you are right, Martin. We should
> go ahead with the optimization with the corrected alignment attached to the
> type. Please go ahead with your patch. I will run a round of regression
> testing on PowerPC (an architecture for which the generic test produces
> misaligned but legal memory references) as well.
>
> Sorry for going back and forth on this. I try to avoid wasting compile time
> on useless transformations, but in this case we will still see some benefit
> in some cases, and the code should be no worse than before when we don't.
>
No worries, I'm currently bootstrapping and testing the attached
patch. I'm bootstrapping on x86_64-linux and with bugs like this one,
any additional testing on other platforms is very welcome.
(In reply to Bill Schmidt from comment #21)
> My only comment on the patch would be to please add commentary indicating
> why the change is being made, and referencing this PR. Something along the
> lines of:
>
> /* Ensure the memory reference carries the minimum alignment
> requirement for the data type. Some targets (e.g., ARM)
> can't always handle an unaligned reference otherwise. See PR58041. */
>
> ...or something like that.
>
The alignment information should be there regardless of the target so
I just used the first sentence and the PR reference. I hope that is
enough. Thanks.
next prev parent reply other threads:[~2013-08-02 16:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 7:26 [Bug middle-end/58041] New: " bernd.edlinger at hotmail dot de
2013-08-01 7:31 ` [Bug middle-end/58041] " bernd.edlinger at hotmail dot de
2013-08-01 9:09 ` mikpe at it dot uu.se
2013-08-01 11:36 ` mikpe at it dot uu.se
2013-08-01 11:51 ` mikpe at it dot uu.se
2013-08-01 13:26 ` wschmidt at gcc dot gnu.org
2013-08-01 16:18 ` wschmidt at gcc dot gnu.org
2013-08-01 16:23 ` jamborm at gcc dot gnu.org
2013-08-01 16:48 ` jamborm at gcc dot gnu.org
2013-08-01 17:27 ` jamborm at gcc dot gnu.org
2013-08-01 17:49 ` wschmidt at gcc dot gnu.org
2013-08-01 17:54 ` wschmidt at gcc dot gnu.org
2013-08-01 18:17 ` bernd.edlinger at hotmail dot de
2013-08-01 18:29 ` wschmidt at gcc dot gnu.org
2013-08-01 18:32 ` wschmidt at gcc dot gnu.org
2013-08-01 19:09 ` bernd.edlinger at hotmail dot de
2013-08-01 19:20 ` wschmidt at gcc dot gnu.org
2013-08-01 19:36 ` mikpe at it dot uu.se
2013-08-01 23:06 ` jamborm at gcc dot gnu.org
2013-08-02 15:22 ` wschmidt at gcc dot gnu.org
2013-08-02 15:28 ` wschmidt at gcc dot gnu.org
2013-08-02 15:54 ` ebotcazou at gcc dot gnu.org
2013-08-02 16:06 ` wschmidt at gcc dot gnu.org
2013-08-02 16:58 ` jamborm at gcc dot gnu.org [this message]
2013-08-02 17:12 ` wschmidt at gcc dot gnu.org
2013-08-02 18:07 ` wschmidt at gcc dot gnu.org
2013-08-03 8:31 ` bernd.edlinger at hotmail dot de
2013-08-05 17:43 ` jamborm at gcc dot gnu.org
2013-08-06 11:59 ` jamborm at gcc dot gnu.org
2013-08-06 14:24 ` bernd.edlinger at hotmail dot de
2013-08-06 15:18 ` jamborm at gcc dot gnu.org
2013-08-06 15:19 ` jamborm at gcc dot gnu.org
2013-08-06 15:33 ` bernd.edlinger at hotmail dot de
2013-08-06 15:56 ` bernd.edlinger at hotmail dot de
2013-08-06 16:06 ` jamborm at gcc dot gnu.org
2013-08-06 16:12 ` bernd.edlinger at hotmail dot de
2013-08-06 16:36 ` bernd.edlinger at hotmail dot de
2013-08-06 16:59 ` jamborm at gcc dot gnu.org
2013-08-06 17:07 ` bernd.edlinger at hotmail dot de
2013-08-06 17:37 ` jamborm at gcc dot gnu.org
2013-08-06 18:19 ` wschmidt at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-58041-4-RzIo8B0Vhs@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).