[Bug c++/58080] New: internal compiler error, decltype in function declaration (for SFINAE purposes)

[Bug c++/58080] New: internal compiler error, decltype in function declaration (for SFINAE purposes)

[nickolay.merkin at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

            Bug ID: 58080
           Summary: internal compiler error, decltype in function
                    declaration (for SFINAE purposes)
           Product: gcc
           Version: 4.7.3
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nickolay.merkin at gmail dot com

Created attachment 30609
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30609&action=edit
preprocessed source code that leads to the ICE

Here is minimal example that reproduces the ICE:

g++ version 4.7.3 (Ubuntu/Linaro 4.7.3-2ubuntu1~12.04)
commandline: g++ std=c++11 x.cpp
(also crashes with std=gnu++11)

// /usr/lib/gcc/i686-linux-gnu/4.7/cc1plus -quiet -imultilib . -imultiarch
i386-linux-gnu -D_GNU_SOURCE x.cpp -quiet -dumpbase x.cpp -mtune=generic
-march=i686 -auxbase x -std=c++11 -fstack-protector -o - -frandom-seed=0
# 1 "x.cpp"
# 1 "<command-line>"
# 1 "x.cpp"
template<class A, class B>
struct Eval
{
 void foo(A a, B b) { bar(a,b, 0); }
 auto bar(A a, B b, decltype(a+b)* _) -> decltype(a+b) { return a+b; }
};

int main()
{
 Eval<int,void*> eiv; eiv.foo(0,0);
}

I intended to write a multimethod that does a+b for integral, pointer, string,
etc. types, -- and immediately met ICE.
Of course, operator+(void*,int) is not defined, but it is not a reason to
crash.
The compiler prepends the crash report with three warnings about VOID* in
arithmetic expression.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Note that strictly speaking arithmetic on a pointer to void would be even
invalid.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-08-04
           Assignee|unassigned at gcc dot gnu.org      |paolo.carlini at oracle dot com
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1
           Severity|major                       |normal

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[nickolay.merkin at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #2 from Nickolay Merkin <nickolay.merkin at gmail dot com> ---
(In reply to Paolo Carlini from comment #1)
> Note that strictly speaking arithmetic on a pointer to void would be even
> invalid.

Yes of course, and the compiler has notified that... and then it crashed.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
I meant something else: I meant that on a different compiler, your code could
be hardly rejected, you should not use arithmetic on void * in the first place.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[nickolay.merkin at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #4 from Nickolay Merkin <nickolay.merkin at gmail dot com> ---
(In reply to Paolo Carlini from comment #3)
> I meant something else: I meant that on a different compiler, your code
> could be hardly rejected, you should not use arithmetic on void * in the
> first place.

I understand that.
My multimethod is intended to take 'good' combinations from 'bad', so that
int+int or int+char* are good,
char*+char* is bad,
and int+void* should be bad, too.

Say,

template<class A, class B>
auto plus_impl(A a, B b) -> decltype(a+b) { return a+b; }
int plus_impl(...) { throw bad_operands(); }

template<class A, class B>
variant_type plus(A a, B b)
{ return variant_type(plus_impl(a,b)); }

To bypass the ICE, I'd like just to add overloads of plus_impl those receive
void* as left or right operand and throw the exception as well.
But this is a bypass.

Tomorrow I'll explore how VC2010 behaves, maybe it is common problem, and the
bypass is strongly required.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Current clang++, for example, simply errors out, no warning.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[evgeny.panasyuk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

Evgeny Panasyuk <evgeny.panasyuk at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |evgeny.panasyuk at gmail dot com

--- Comment #6 from Evgeny Panasyuk <evgeny.panasyuk at gmail dot com> ---
Several variations of original code shows differences in results of GCC 4.8.1
and Clang (3.4 trunk 184460):

Case 1: Both compile OK, but different overloads are selected
GCC:
http://coliru.stacked-crooked.com/view?id=58ca6a0268281fda26a36db4e5d50bbd-3ea7fded292aff0f460de2fb646b584a
Clang:
http://coliru.stacked-crooked.com/view?id=58ca6a0268281fda26a36db4e5d50bbd-80c199070668c72f0a5e12e38239d72b

Case 2: Clang compiles OK, without errors, while GCC shows "Internal compiler
error"
GCC:
http://coliru.stacked-crooked.com/view?id=7defec6f0288a8d72255a652e1baf439-3ea7fded292aff0f460de2fb646b584a
Clang:
http://coliru.stacked-crooked.com/view?id=7defec6f0288a8d72255a652e1baf439-80c199070668c72f0a5e12e38239d72b

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> ---
The ICE is of course wrong, I already sent a patch for it. If there are other
issues, let's handle one at a time, in different bugs, after having checked
that mainline GCC is still affected and that there are no dups in Bugzilla.
Thanks.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> ---
By the way, with my patch installed, all the new testcases seem fine,
consistent with clang.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Fixed for 4.9.0.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[nickolay.merkin at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #10 from Nickolay Merkin <nickolay.merkin at gmail dot com> ---
(In reply to Paolo Carlini from comment #9)
> Fixed for 4.9.0.
Thank you!

Will it be fixed for 4.7.3, or this version is frozen?

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|paolo.carlini at oracle dot com    |unassigned at gcc dot gnu.org

--- Comment #11 from Paolo Carlini <paolo.carlini at oracle dot com> ---
The issue isn't about entire branches frozen, the issue is that this is an ICE
after sensible diagnostics, which moreover isn't a regression. If you feel
strongly about backports to 4.7.x and 4.8.x, just send a message to the release
managers.

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[i.nixman at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #12 from niXman <i.nixman at gmail dot com> ---
(In reply to Paolo Carlini from comment #9)
> Fixed for 4.9.0.

Can you provide a commit number, please?

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #13 from Paolo Carlini <paolo.carlini at oracle dot com> ---
If you need help, luckily today Jason provided a nice HOWTO here (the only
difference is that you want trunk, not 4_8-branch):
http://gcc.gnu.org/ml/gcc-bugs/2013-08/msg00320.html

[Bug c++/58080] internal compiler error, decltype in function declaration (for SFINAE purposes)

[i.nixman at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58080

--- Comment #14 from niXman <i.nixman at gmail dot com> ---
(In reply to Paolo Carlini from comment #13)

http://gcc.gnu.org/viewcvs/gcc?view=revision&sortby=date&revision=201512

thank you