[Bug target/58115] New: testcase gcc.target/i386/intrinsics_4.c failure

[Bug target/58115] New: testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

            Bug ID: 58115
           Summary: testcase gcc.target/i386/intrinsics_4.c failure
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bernd.edlinger at hotmail dot de
            Target: i386-pc-linux-gnu
             Build: gcc-4.9-20130728

this test case fails on i686-pc-linux with internal error.

intrinsics_4.c: In function 'foo':
intrinsics_4.c:15:1: internal compiler error: Max. number of generated reload
insns per insn is achieved (90)

 }
 ^
0x849e4c3 lra_constraints(bool)
        ../../gcc-4.9-20130728/gcc/lra-constraints.c:3724
0x849136c lra(_IO_FILE*)
        ../../gcc-4.9-20130728/gcc/lra.c:2319
0x8456beb do_reload
        ../../gcc-4.9-20130728/gcc/ira.c:4689
0x8456beb rest_of_handle_reload
        ../../gcc-4.9-20130728/gcc/ira.c:4801
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

The crash happens only with this command line
"gcc -O2 -msse -mno-avx -S intrinsics_4.c"
but not with "-O1 -msse -mno-avx" or "-O2 -msse2 -mno-avx"

The problem seems to be triggered when the movv8sf_internal
is split up to 8 movsi_internal which leads to the crash in the lra.

The wrong decision is happening in expr.c in emit_move_insn:

#0  emit_move_multi_word(machine_mode, rtx_def*, rtx_def*) () at
../../gcc-4.9-20130728/gcc/expr.c:3344
#1  0x08332390 in emit_move_insn(rtx_def*, rtx_def*) () at
../../gcc-4.9-20130728/gcc/expr.c:3526
#2  0x08311cb1 in force_reg(machine_mode, rtx_def*) [clone .part.2] ()
#3  0x08833225 in ix86_fixup_binary_operands(rtx_code, machine_mode, rtx_def**)
() at ../../gcc-4.9-20130728/gcc/config/i386/i386.c:16729
#4  0x08833250 in ix86_fixup_binary_operands_no_copy(rtx_code, machine_mode,
rtx_def**) () at ../../gcc-4.9-20130728/gcc/config/i386/i386.c:16763
#5  0x088d3af0 in gen_andv8sf3(rtx_def*, rtx_def*, rtx_def*) ()
#6  0x081149db in ix86_expand_args_builtin(builtin_description const*,
tree_node*, rtx_def*) () at ../../gcc-4.9-20130728/gcc/config/i386/i386.c:30457
#7  0x0884b762 in ix86_expand_builtin(tree_node*, rtx_def*, rtx_def*,
machine_mode, int) () at ../../gcc-4.9-20130728/gcc/config/i386/i386.c:32769
#8  0x082367cc in expand_builtin(tree_node*, rtx_def*, rtx_def*, machine_mode,
int) () at ../../gcc-4.9-20130728/gcc/builtins.c:5823
#9  0x0832bd9d in expand_expr_real_1(tree_node*, rtx_def*, machine_mode,
expand_modifier, rtx_def**) () at ../../gcc-4.9-20130728/gcc/expr.c:10270
#10 0x0833953d in store_expr(tree_node*, rtx_def*, int, bool) () at
../../gcc-4.9-20130728/gcc/expr.c:5287
#11 0x0833bf96 in expand_assignment(tree_node*, tree_node*, bool) () at
../../gcc-4.9-20130728/gcc/expr.c:5073
#12 0x0825831c in expand_gimple_stmt(gimple_statement_d*) () at
../../gcc-4.9-20130728/gcc/cfgexpand.c:2178
#13 0x0825971c in expand_gimple_basic_block(basic_block_def*, bool) () at
../../gcc-4.9-20130728/gcc/cfgexpand.c:4204
#14 0x0825b458 in gimple_expand_cfg() () at
../../gcc-4.9-20130728/gcc/cfgexpand.c:4723
#15 0x084f09eb in execute_one_pass(opt_pass*) () at
../../gcc-4.9-20130728/gcc/passes.c:1965
#16 0x084f0e15 in execute_pass_list(opt_pass*) () at
../../gcc-4.9-20130728/gcc/passes.c:2017
#17 0x0827c09e in expand_function(cgraph_node*) () at
../../gcc-4.9-20130728/gcc/cgraphunit.c:1591
#18 0x0827df4d in compile() () at ../../gcc-4.9-20130728/gcc/cgraphunit.c:1695
#19 0x0827e59a in finalize_compilation_unit() () at
../../gcc-4.9-20130728/gcc/cgraphunit.c:2106
#20 0x08146075 in c_write_global_declarations() () at
../../gcc-4.9-20130728/gcc/c/c-decl.c:10125
#21 0x08595d5d in compile_file() ()
#22 0x08597d42 in toplev_main(int, char**) ()
#23 0x08127ebb in main () at ../../gcc-4.9-20130728/gcc/main.c:36

This is probably an error from the back-end optab_handler (?)
The failure started from 2013-06-23 and continues till today.

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #1 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
Hi Sriraman,

I'm putting you on CC since you are the author of that test case:
I am not sure if the test case should use -msse2 instead of -msse,
but running on an assertion is certainly to be avoided in any case.

Regards
Bernd.

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|i386-pc-linux-gnu           |i386-pc-linux-gnu,
                   |                            |i386-pc-solaris2.9
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-10-14
                 CC|                            |ro at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
Also on Solaris 9/x86.

  Rainer

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[tmsriram at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #3 from Sriraman Tallam <tmsriram at google dot com> ---
(In reply to Bernd Edlinger from comment #1)
> Hi Sriraman,
> 
> I'm putting you on CC since you are the author of that test case:
> I am not sure if the test case should use -msse2 instead of -msse,
> but running on an assertion is certainly to be avoided in any case.

I do not see why it *should* use msse2. Using msse2 however is perfectly fine
as it preserves the test case's intent.

Thanks
Sri

> 
> Regards
> Bernd.

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #4 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
(In reply to Sriraman Tallam from comment #3)
Hmm...

This bug seems to be connected to PR57756.
A lot of __attribute__((target(..))) get parsed,
before this error occurs. Some global data are completely
spoiled, which makes the wrong opcode disabled.

Using your patch for PR57756 seems to fixes this one too.
I just wonder why this does not happen on x86_64?

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #5 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Bernd Edlinger from comment #4)
> I just wonder why this does not happen on x86_64?

x86_64 enables SSE2 by default.
>From gcc-bugs-return-431683-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 14 19:46:25 2013
Return-Path: <gcc-bugs-return-431683-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 29937 invoked by alias); 14 Oct 2013 19:46:25 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 29863 invoked by uid 48); 14 Oct 2013 19:46:22 -0000
From: "paolo.carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/29040] missing access control checks in subclasses for nested types
Date: Mon, 14 Oct 2013 19:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.2.0
X-Bugzilla-Keywords: accepts-invalid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: paolo.carlini at oracle dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status assigned_to target_milestone
Message-ID: <bug-29040-4-copsTWOWkx@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-29040-4@http.gcc.gnu.org/bugzilla/>
References: <bug-29040-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg00827.txt.bz2
Content-length: 618

http://gcc.gnu.org/bugzilla/show_bug.cgi?id)040

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |paolo.carlini at oracle dot com
   Target Milestone|---                         |4.9.0

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
I have a draft patch which essentially adds the missing lookup to
cp_parser_elaborated_type_specifier

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #6 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
to reproduce this ICE under x64:

gcc -O2 -msse -mno-sse2 -mno-avx -S intrinsics_4.c

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #7 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
Created attachment 31136
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31136&action=edit
reduced test case

apparently this is not yet fixed...
reduced test case attached.

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #8 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
Created attachment 31137
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31137&action=edit
untested patch

targetm.set_current_function modifies this_fn_optabs->pat_enable[654]
to enable/disable CODE_FOR_movv8sf but afterwards the pointer
"this_fn_optabs" may get overwiritten with another value.
This leaves this_fn_optabs->pat_enable[654] (CODE_FOR_movv8sf) undefined.

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[edlinger at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #9 from edlinger at gcc dot gnu.org ---
Author: edlinger
Date: Mon Dec  2 18:00:47 2013
New Revision: 205593

URL: http://gcc.gnu.org/viewcvs?rev=205593&root=gcc&view=rev
Log:
2013-11-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        PR target/58115
        * function.c (invoke_set_current_function_hook): Call
        targetm.set_current_function after setting this_fn_optabs.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/function.c

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

Bernd Edlinger <bernd.edlinger at hotmail dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
patch applied

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[edlinger at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #11 from edlinger at gcc dot gnu.org ---
Author: edlinger
Date: Mon Jan  6 16:34:52 2014
New Revision: 206364

URL: http://gcc.gnu.org/viewcvs?rev=206364&root=gcc&view=rev
Log:
Reverted r205593
2013-12-02  Bernd Edlinger  <bernd.edlinger@hotmail.de>

    PR target/58115
    * function.c (invoke_set_current_function_hook): Call
    targetm.set_current_function after setting this_fn_optabs.

Modified:
    trunk/gcc/ChangeLog-2013
    trunk/gcc/function.c

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

Bernd Edlinger <bernd.edlinger at hotmail dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #12 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
Had to revert the fix,
because it broke the mips16 attribute.

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #13 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Author: rsandifo
Date: Tue Jan  7 15:26:41 2014
New Revision: 206394

URL: http://gcc.gnu.org/viewcvs?rev=206394&root=gcc&view=rev
Log:
gcc/
    PR target/58115
    * target-globals.c (save_target_globals): Remove this_fn_optab
    handling.
    * toplev.c: Include optabs.h.
    (target_reinit): Temporarily restore the global options if another
    set of options are in force.

gcc/testsuite/
    * gcc.target/i386/intrinsics_4.c (bar): New function.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/target-globals.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/intrinsics_4.c
    trunk/gcc/toplev.c

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Jan  9 18:25:19 2014
New Revision: 206478

URL: http://gcc.gnu.org/viewcvs?rev=206478&root=gcc&view=rev
Log:
    PR target/58115
    * tree-core.h (struct target_globals): New forward declaration.
    (struct tree_target_option): Add globals field.
    * tree.h (TREE_TARGET_GLOBALS): Define.
    (prepare_target_option_nodes_for_pch): New prototype.
    * target-globals.h (struct target_globals): Define even if
    !SWITCHABLE_TARGET.
    * tree.c (prepare_target_option_node_for_pch,
    prepare_target_option_nodes_for_pch): New functions.
    * config/i386/i386.h (SWITCHABLE_TARGET): Define.
    * config/i386/i386.c: Include target-globals.h.
    (ix86_set_current_function): Instead of doing target_reinit
    unconditionally, use save_target_globals_default_opts and
    restore_target_globals.
c-family/
    * c-pch.c (c_common_write_pch): Call
    prepare_target_option_nodes_for_pch.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-pch.c
    trunk/gcc/config/i386/i386.c
    trunk/gcc/config/i386/i386.h
    trunk/gcc/target-globals.h
    trunk/gcc/tree-core.h
    trunk/gcc/tree.c
    trunk/gcc/tree.h

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[dje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

--- Comment #15 from David Edelsohn <dje at gcc dot gnu.org> ---
Author: dje
Date: Sat Jan 11 18:57:56 2014
New Revision: 206554

URL: http://gcc.gnu.org/viewcvs?rev=206554&root=gcc&view=rev
Log:
        PR target/58115
        * config/rs6000/rs6000.h (SWITCHABLE_TARGET): Define.
        * config/rs6000/rs6000.c: Include target-globals.h.
        (rs6000_set_current_function): Instead of doing target_reinit
        unconditionally, use save_target_globals_default_opts and
        restore_target_globals.

        * config/rs6000/rs6000-builtin.def (mffs, mtfsf): Add builtins for
        FPSCR.
        * config/rs6000/rs6000.c (rs6000_expand_mtfsf_builtin): New.
        (rs6000_expand_builtin): Handle mffs and mtfsf.
        (rs6000_init_builtins): Define mffs and mtfsf.
        * config/rs6000/rs6000.md (UNSPECV_MFFS, UNSPECV_MTFSF): New.
        (rs6000_mffs): New pattern.
        (rs6000_mtfsf): New pattern.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000-builtin.def
    trunk/gcc/config/rs6000/rs6000.c
    trunk/gcc/config/rs6000/rs6000.h
    trunk/gcc/config/rs6000/rs6000.md

[Bug target/58115] testcase gcc.target/i386/intrinsics_4.c failure

[bernd.edlinger at hotmail dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58115

Bernd Edlinger <bernd.edlinger at hotmail dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
fixed on trunk.

Thanks!