[Bug fortran/58175] New: Incorrect warning message on scalar finalizor

[Bug fortran/58175] New: Incorrect warning message on scalar finalizor

[abensonca at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

            Bug ID: 58175
           Summary: Incorrect warning message on scalar finalizor
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: abensonca at gmail dot com

With gfortran 4.9.0 (r201776) the following causes an incorrect warning message
to be issued:

module ct
  type :: a
   contains
     final :: aD
  end type a
contains
  subroutine aD(self)
    type(a), intent(inout) :: self
  end subroutine aD
end module ct
program test
  use ct
end program test

$ gfortran -v
Using built-in specs.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/home/abenson/Galacticus/Tools/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-trunk/configure --prefix=/home/abenson/Galacticus/Tools
--enable-languages=c,c++,fortran --disable-multilib
--with-gmp=/home/abenson/Galacticus/Tools
Thread model: posix
gcc version 4.9.0 20130815 (experimental) (GCC) 

$ gfortran -c bug1.F90 -o bug1.o -Wall
bug1.F90:12.6:

  use ct
      1
Warning: Only array FINAL procedures declared for derived type 'a' defined at
(1), suggest also scalar one
bug1.F90:7.20:

  subroutine aD(self)
                    1
Warning: Unused dummy argument 'self' at (1)

Only a scalar finalizor is present, but the warning suggests that an array but
no scalar finalizor is present.

The warning is only issued if the "ct" module is USEd.

Adding an array finalizor or making the scalar finalizor ELEMENTAL does not
change the warning message.

[Bug fortran/58175] Incorrect warning message on scalar finalizor

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-08-16
                 CC|                            |burnus at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Untested patch.

(The second part just makes use of the following existing line:
  my_rank = (arg->as ? arg->as->rank : 0);  )

diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 067288d..28321bb 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -11124,6 +11124,9 @@ gfc_resolve_finalizers (gfc_symbol* derived)
       /* Skip this finalizer if we already resolved it.  */
       if (list->proc_tree)
        {
+          if (list->proc_tree->n.sym->formal->sym->as == NULL
+              || list->proc_tree->n.sym->formal->sym->as->rank == 0)
+           seen_scalar = true;
          prev_link = &(list->next);
          continue;
        }
@@ -11217,7 +11220,7 @@ gfc_resolve_finalizers (gfc_symbol* derived)
        }

        /* Is this the/a scalar finalizer procedure?  */
-       if (!arg->as || arg->as->rank == 0)
+       if (my_rank == 0)
          seen_scalar = true;

        /* Find the symtree for this procedure.  */

[Bug fortran/58175] [F03] Incorrect warning message on scalar finalizer

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic
                 CC|                            |janus at gcc dot gnu.org
            Summary|Incorrect warning message   |[F03] Incorrect warning
                   |on scalar finalizer         |message on scalar finalizer

--- Comment #2 from janus at gcc dot gnu.org ---
(In reply to Tobias Burnus from comment #1)
> Untested patch.

... indeed seems to fix the problem.

[Bug fortran/58175] [OOP] Incorrect warning message on scalar finalizer

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[F03] Incorrect warning     |[OOP] Incorrect warning
                   |message on scalar finalizer |message on scalar finalizer

--- Comment #3 from janus at gcc dot gnu.org ---
(In reply to Tobias Burnus from comment #1)
> Untested patch.

Any ambitions to commit this?

[Bug fortran/58175] [OOP] Incorrect warning message on scalar finalizer

[patnel97269-gfortran at yahoo dot fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

patnel97269-gfortran at yahoo dot fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patnel97269-gfortran@yahoo.
                   |                            |fr

--- Comment #4 from patnel97269-gfortran at yahoo dot fr ---
I still have this bug in 4.9.2 . Why not committing the patch ?

[Bug fortran/58175] [OOP] Incorrect warning message on scalar finalizer

[casey.webster at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

Casey Webster <casey.webster at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |casey.webster at gmail dot com

--- Comment #5 from Casey Webster <casey.webster at gmail dot com> ---
This bug still exists in fortran 5.1.0 (released version).  My testcase ended
up being a duplicate of the original post, so I won't repost that.

% gfortran -Wall -o final_bug_2 final_bug_2.f90
final_bug_2.f90:13:6:

   use A
      1
Warning: Only array FINAL procedures declared for derived type ‘typea’ defined
at (1), suggest also scalar one [-Wsurprising]

% gfortran -v
Using built-in specs.
COLLECT_GCC=/usr/x86_64-pc-linux-gnu/gcc-bin/5.1.0/gfortran
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/5.1.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /var/tmp/portage/sys-devel/gcc-5.1.0/work/gcc-5.1.0/configure
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/5.1.0
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/5.1.0/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/5.1.0
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/5.1.0/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/5.1.0/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/5.1.0/include/g++-v5
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/5.1.0/python
--enable-objc-gc --enable-languages=c,c++,java,go,objc,obj-c++,fortran
--enable-obsolete --enable-secureplt --disable-werror --with-system-zlib
--enable-nls --without-included-gettext --enable-checking=release
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo 5.1.0 p1.0,
pie-0.6.3' --enable-libstdcxx-time --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --enable-multilib
--with-multilib-list=m32,m64 --disable-altivec --disable-fixed-point
--enable-targets=all --enable-libgomp --disable-libmudflap --disable-libssp
--enable-libcilkrts --enable-lto --with-isl --disable-isl-version-check
--enable-libsanitizer
Thread model: posix
gcc version 5.1.0 (Gentoo 5.1.0 p1.0, pie-0.6.3)
>From gcc-bugs-return-487167-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun May 24 05:11:23 2015
Return-Path: <gcc-bugs-return-487167-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1800 invoked by alias); 24 May 2015 05:11:21 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1767 invoked by uid 48); 24 May 2015 05:11:15 -0000
From: "jamrial at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/66270] New: ICE: canonical types differ for identical types
Date: Sun, 24 May 2015 05:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jamrial at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone attachments.created
Message-ID: <bug-66270-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg02007.txt.bz2
Content-length: 2844

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66270

            Bug ID: 66270
           Summary: ICE: canonical types differ for identical types
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jamrial at gmail dot com
  Target Milestone: ---

Created attachment 35608
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35608&action=edit
Preprocessed source as generated by -freport-bug

GCC 6.0.0 svn 223625

In file included from Vec.h:3:0,
                 from Example.cc:8:
Vec8Float.h: In member function ‘avx::vec<float, 8ul>::Value& avx::vec<float,
8ul>::operator[](std::size_t)’:
Vec8Float.h:104:21: internal compiler error: canonical types differ for
identical types avx::vec<float, 8ul>::Value* {aka float*} and float*
     return ymm[index];
                     ^
0x72abbe comptypes(tree_node*, tree_node*, int)
        /home/jamrial/gcc-svn/gcc/cp/typeck.c:1423
0x745b4a ocp_convert(tree_node*, tree_node*, int, int, int)
        /home/jamrial/gcc-svn/gcc/cp/cvt.c:704
0x5ece73 convert_like_real
        /home/jamrial/gcc-svn/gcc/cp/call.c:6591
0x5f897b initialize_reference(tree_node*, tree_node*, int, int)
        /home/jamrial/gcc-svn/gcc/cp/call.c:9780
0x734c9c check_return_expr(tree_node*, bool*)
        /home/jamrial/gcc-svn/gcc/cp/typeck.c:8730
0x76fc6e finish_return_stmt(tree_node*)
        /home/jamrial/gcc-svn/gcc/cp/semantics.c:887
0x715a1e cp_parser_jump_statement
        /home/jamrial/gcc-svn/gcc/cp/parser.c:11064
0x715a1e cp_parser_statement
        /home/jamrial/gcc-svn/gcc/cp/parser.c:9707
0x715ff2 cp_parser_statement_seq_opt
        /home/jamrial/gcc-svn/gcc/cp/parser.c:10095
0x71614b cp_parser_compound_statement
        /home/jamrial/gcc-svn/gcc/cp/parser.c:10049
0x71637b cp_parser_function_body
        /home/jamrial/gcc-svn/gcc/cp/parser.c:19223
0x71637b cp_parser_ctor_initializer_opt_and_function_body
        /home/jamrial/gcc-svn/gcc/cp/parser.c:19259
0x717200 cp_parser_function_definition_after_declarator
        /home/jamrial/gcc-svn/gcc/cp/parser.c:23519
0x71a804 cp_parser_late_parsing_for_member
        /home/jamrial/gcc-svn/gcc/cp/parser.c:24202
0x6f58f9 cp_parser_class_specifier_1
        /home/jamrial/gcc-svn/gcc/cp/parser.c:20079
0x6f58f9 cp_parser_class_specifier
        /home/jamrial/gcc-svn/gcc/cp/parser.c:20105
0x6f58f9 cp_parser_type_specifier
        /home/jamrial/gcc-svn/gcc/cp/parser.c:14734
0x708bce cp_parser_decl_specifier_seq
        /home/jamrial/gcc-svn/gcc/cp/parser.c:11965
0x7181f8 cp_parser_single_declaration
        /home/jamrial/gcc-svn/gcc/cp/parser.c:23773
0x718f3d cp_parser_explicit_specialization
        /home/jamrial/gcc-svn/gcc/cp/parser.c:14630
>From gcc-bugs-return-487168-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun May 24 07:42:10 2015
Return-Path: <gcc-bugs-return-487168-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 40780 invoked by alias); 24 May 2015 07:42:08 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 40742 invoked by uid 48); 24 May 2015 07:42:03 -0000
From: "glisse at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/66270] [6 Regression] ICE: canonical types differ for identical types
Date: Sun, 24 May 2015 07:42:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: glisse at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on target_milestone short_desc everconfirmed
Message-ID: <bug-66270-4-zDSXkTSltJ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66270-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66270-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg02008.txt.bz2
Content-length: 886

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf270

Marc Glisse <glisse at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-05-24
   Target Milestone|---                         |6.0
            Summary|ICE: canonical types differ |[6 Regression] ICE:
                   |for identical types         |canonical types differ for
                   |                            |identical types
     Ever confirmed|0                           |1

--- Comment #1 from Marc Glisse <glisse at gcc dot gnu.org> ---
typedef float __m256 __attribute__ (( __vector_size__(32), __may_alias__ ));
struct A {
  __m256 ymm;
  const float &f() const {
        return ymm[1];
  }
};

[Bug fortran/58175] [OOP] Incorrect warning message on scalar finalizer

[abensonca at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

--- Comment #6 from Andrew Benson <abensonca at gmail dot com> ---
This problem still occurs in gcc 6.0.0. In a code which makes extensive use of
finalizors it results in many thousands of erroneous warning messages during
compile, which have to be filtered out to find the real warnings. Is there any
way I can help get the proposed patch committed (e.g. maybe testing it to
ensure it introduces no regressions)?

[Bug fortran/58175] [OOP] Incorrect warning message on scalar finalizer

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58175

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 66291 has been marked as a duplicate of this bug. ***