[Bug c++/58190] New: FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[Bug c++/58190] New: FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

            Bug ID: 58190
           Summary: FAIL: g++.dg/pr57878.C (test for excess errors) on
                    x86_64-apple-darwin10
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: iains at gcc dot gnu.org, vmakarov at redhat dot com
              Host: x86_64-apple-darwin10
            Target: x86_64-apple-darwin10
             Build: x86_64-apple-darwin10

The test FAIL: g++.dg/pr57878.C (introduced at r 201036) fails on
x86_64-apple-darwin10 with

/opt/gcc/work/gcc/testsuite/g++.dg/pr57878.C:27:53: error: 'operator new' takes
type 'size_t' ('long unsigned int') as first parameter [-fpermissive]
   inline void* operator new(std::size_t, void* __p) noexcept {

I get the error with older versions of g++, e.g., 4.8.1, and with -m32 and
-m64.

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Created attachment 30676
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30676&action=edit
Obvious patchlet

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-08-20
     Ever confirmed|0                           |1

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
I'm going to commit as obvious this patchlet. Could you please double check
that it works for you?

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Before committing anything, do you have any idea why the testcase isn't simply
skipped on darwin10? Because I just built mainline on a darwin12 machine and
the testcase is correctly skipped as UNSUPPORTED, thus doesn't FAIL (outside
the testsuite, it fails as you are reporting, but that doesn't really matter).
It seems very strange to me that on darwin10 the DejaGnu selectors on top of
the testcase don't work correctly. Is this a known, much more general issue?

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Paolo Carlini from comment #3)
> Before committing anything, do you have any idea why the testcase isn't
> simply skipped on darwin10? Because I just built mainline on a darwin12
> machine and the testcase is correctly skipped as UNSUPPORTED, thus doesn't
> FAIL (outside the testsuite, it fails as you are reporting, but that doesn't
> really matter). It seems very strange to me that on darwin10 the DejaGnu
> selectors on top of the testcase don't work correctly. Is this a known, much
> more general issue?

it fails for me on darwin12 for the "-m32" run (i.e. ilp32).
and shows unsupported for the m64 one.

We generally test on Darwin --target_board=unix\{-m32,-m64\}.

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Ok, that makes sense, it simply means that on darwin, at variance with Linux,
for -m32 a size_t is an unsigned long instead of an unsigned int, we can simply
apply the patchlet and close the issue.

Next time, please say more clearly in which *exact* condition the FAIL appears.

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

--- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Paolo Carlini from comment #5)
> Ok, that makes sense, it simply means that on darwin, at variance with
> Linux, for -m32 a size_t is an unsigned long instead of an unsigned int, we
> can simply apply the patchlet and close the issue.
> 
> Next time, please say more clearly in which *exact* condition the FAIL
> appears.

ack, the patchlet fixes it as expected.

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Done.

[Bug c++/58190] FAIL: g++.dg/pr57878.C (test for excess errors) on x86_64-apple-darwin10

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58190

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.0                       |4.8.2

--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Fixed for 4.8.2 too.