[Bug c++/58191] New: Can't use boost transform_iterator with _GLIBCXX_DEBUG

[Bug c++/58191] New: Can't use boost transform_iterator with _GLIBCXX_DEBUG

[woodroof at gmail dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 9113 bytes --]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

            Bug ID: 58191
           Summary: Can't use boost transform_iterator with _GLIBCXX_DEBUG
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: woodroof at gmail dot com

Given:
A simple code:

int calc_value(int original_value)
{
    return original_value % 3;
}

int main()
{
    std::vector<int> numbers;
    std::upper_bound(
        boost::make_transform_iterator(numbers.begin(), calc_value),
        boost::make_transform_iterator(numbers.end(), calc_value),
        1);
}

Gcc version: g++ (Ubuntu 4.8.1-2ubuntu1~13.04) 4.8.1
Additional command line params: -D_GLIBCXX_DEBUG

Result: Compilation error
In file included from /usr/include/c++/4.8/debug/debug.h:127:0,
                 from /usr/include/c++/4.8/bits/stl_iterator_base_funcs.h:65,
                 from /usr/include/c++/4.8/bits/stl_algobase.h:66,
                 from /usr/include/c++/4.8/vector:60,
                 from 1.cpp:1:
/usr/include/c++/4.8/debug/functions.h: In instantiation of ‘bool
__gnu_debug::__check_partitioned_upper(_ForwardIterator, _ForwardIterator,
const _Tp&) [with _ForwardIterator = boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default>; _Tp = int]’:
/usr/include/c++/4.8/bits/stl_algo.h:2506:358:   required from ‘_FIter
std::upper_bound(_FIter, _FIter, const _Tp&) [with _FIter =
boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default>; _Tp = int]’
1.cpp:16:4:   required from here
/usr/include/c++/4.8/debug/functions.h:428:42: error: no matching function for
call to ‘__check_partitioned_upper_aux(boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default>&, boost::transform_iterator<int
(*)(int), __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default>&, const int&,
std::iterator_traits<boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default> >::iterator_category)’
         std::__iterator_category(__first));
                                          ^
/usr/include/c++/4.8/debug/functions.h:428:42: note: candidates are:
/usr/include/c++/4.8/debug/functions.h:393:5: note: template<class
_ForwardIterator, class _Tp> bool
__gnu_debug::__check_partitioned_upper_aux(_ForwardIterator, _ForwardIterator,
const _Tp&, std::forward_iterator_tag)
     __check_partitioned_upper_aux(_ForwardIterator __first,
     ^
/usr/include/c++/4.8/debug/functions.h:393:5: note:   template argument
deduction/substitution failed:
/usr/include/c++/4.8/debug/functions.h:428:42: note:   cannot convert
‘std::__iterator_category<boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default> >((*(const
boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default>*)(& __first)))’ (type
‘std::iterator_traits<boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default> >::iterator_category {aka
boost::detail::iterator_category_with_traversal<std::input_iterator_tag,
boost::random_access_traversal_tag>}’) to type ‘std::forward_iterator_tag’
         std::__iterator_category(__first));
                                          ^
/usr/include/c++/4.8/debug/functions.h:412:5: note: template<class _Iterator,
class _Sequence, class _Tp> bool
__gnu_debug::__check_partitioned_upper_aux(const
__gnu_debug::_Safe_iterator<_Iterator, _Sequence>&, const
__gnu_debug::_Safe_iterator<_Iterator, _Sequence>&, const _Tp&,
std::random_access_iterator_tag)
     __check_partitioned_upper_aux(
     ^
/usr/include/c++/4.8/debug/functions.h:412:5: note:   template argument
deduction/substitution failed:
/usr/include/c++/4.8/debug/functions.h:428:42: note:  
‘boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default>’ is not derived from ‘const
__gnu_debug::_Safe_iterator<_Iterator, _Sequence>’
         std::__iterator_category(__first));
                                          ^
/usr/include/c++/4.8/debug/functions.h:498:5: note: template<class _Iterator,
class _Sequence, class _Tp, class _Pred> bool
__gnu_debug::__check_partitioned_upper_aux(const
__gnu_debug::_Safe_iterator<_Iterator, _Sequence>&, const
__gnu_debug::_Safe_iterator<_Iterator, _Sequence>&, const _Tp&, _Pred,
std::random_access_iterator_tag)
     __check_partitioned_upper_aux(
     ^
/usr/include/c++/4.8/debug/functions.h:498:5: note:   template argument
deduction/substitution failed:
/usr/include/c++/4.8/debug/functions.h:428:42: note:  
‘boost::transform_iterator<int (*)(int),
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*,
std::__cxx1998::vector<int, std::allocator<int> > >, std::__debug::vector<int>
>, boost::use_default, boost::use_default>’ is not derived from ‘const
__gnu_debug::_Safe_iterator<_Iterator, _Sequence>’
         std::__iterator_category(__first));
                                          ^
/usr/include/c++/4.8/debug/functions.h:477:5: note: template<class
_ForwardIterator, class _Tp, class _Pred> bool
__gnu_debug::__check_partitioned_upper_aux(_ForwardIterator, _ForwardIterator,
const _Tp&, _Pred, std::forward_iterator_tag)
     __check_partitioned_upper_aux(_ForwardIterator __first,
     ^
/usr/include/c++/4.8/debug/functions.h:477:5: note:   template argument
deduction/substitution failed:
/usr/include/c++/4.8/debug/functions.h:428:42: note:   candidate expects 5
arguments, 4 provided
         std::__iterator_category(__first));
                                          ^

gcc 4.7.3 works fine
>From gcc-bugs-return-428010-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 19 05:48:00 2013
Return-Path: <gcc-bugs-return-428010-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 20938 invoked by alias); 19 Aug 2013 05:48:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 20915 invoked by uid 48); 19 Aug 2013 05:47:58 -0000
From: "woodroof at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG
Date: Mon, 19 Aug 2013 05:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: woodroof at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-58191-4-lZwVBOxQSb@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-08/txt/msg00934.txt.bz2
Content-length: 239

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX191

--- Comment #1 from Danil Ilinykh <woodroof at gmail dot com> ---
Created attachment 30671
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id0671&actioníit
Preprocessed file archive

[Bug c++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

[Bug c++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fdumont at gcc dot gnu.org

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
With 100 KB of code to look at, this could be anything, could be front-end,
could be library, could well be boost.

Francois, did we change anything in the library for 4.8.x?

[Bug c++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[daniel.kruegler at googlemail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

--- Comment #3 from Daniel Krügler <daniel.kruegler at googlemail dot com> ---
First, this issue should be categorized as belonging to the component
"libstdc++", not to "c++".

Second, the defect report is invalid, because std::upper_bound requires a
minimum iterator category of "forward iterator", but boost::transform_iterator
with a function object that returns a value (not a real reference) has an
iterator category "input iterator", which is correct, since forward iterators
are required to return a real reference for operator*.
>From gcc-bugs-return-428020-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 19 09:36:16 2013
Return-Path: <gcc-bugs-return-428020-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6280 invoked by alias); 19 Aug 2013 09:36:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6250 invoked by uid 48); 19 Aug 2013 09:36:15 -0000
From: "paolo.carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG
Date: Mon, 19 Aug 2013 09:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: paolo.carlini at oracle dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-58191-4-L4VZDYLmPH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-08/txt/msg00944.txt.bz2
Content-length: 474

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX191

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Oh well, thanks Daniel for helping on this.

[Bug c++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[daniel.kruegler at googlemail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

--- Comment #5 from Daniel Krügler <daniel.kruegler at googlemail dot com> ---
(In reply to Paolo Carlini from comment #2)
> Francois, did we change anything in the library for 4.8.x?

I think that Francois added more iterator concept checking and this one looks
correct. Unfortunately I would say, this is correct, because the standard says
so, but from a practical point of view, std::upper_bound "just works" for any
forward traversal iterator and it does not require that the return type of
operator* *really* is a reference type. We also cannot blame boost here,
because it is not their fault that the standard requires for forward iterators
to have a real reference return type for iterator dereference. My
recommendation to the issue reporter would be to provide a function object that
returns a real reference. This can be easily done by a unary functor adaptor
such as the following one:

template<class UnaryFunction, class ArgumentType>
struct LValueUnaryFunctionAdaptor
{
  typedef typename std::result_of<const UnaryFunction(ArgumentType)>::type
value_type;
  LValueUnaryFunctionAdaptor(UnaryFunction func) : func(func) {}
  typedef const value_type& result_type;
  result_type operator()(ArgumentType arg) const
  {
    return res = func(arg);
  }
private:
  UnaryFunction func;
  mutable value_type res;
};

template<class ArgumentType, class UnaryFunction>
inline
LValueUnaryFunctionAdaptor<UnaryFunction, ArgumentType>
make_LValueUnaryFunction(UnaryFunction func)
{
  return LValueUnaryFunctionAdaptor<UnaryFunction, ArgumentType>(func);
}

So instead of

calc_value

he could use

make_LValueUnaryFunction<int>(calc_value)

This trick doesn't make the transform_iterator fully conforming, but it should
convince the compile-time test machinery.
>From gcc-bugs-return-428023-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 19 09:51:24 2013
Return-Path: <gcc-bugs-return-428023-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21220 invoked by alias); 19 Aug 2013 09:51:24 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21192 invoked by uid 48); 19 Aug 2013 09:51:23 -0000
From: "woodroof at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG
Date: Mon, 19 Aug 2013 09:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: woodroof at gmail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58191-4-0b3g2XCxGX@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-08/txt/msg00947.txt.bz2
Content-length: 129

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX191

--- Comment #6 from Danil Ilinykh <woodroof at gmail dot com> ---
Thank you!

[Bug libstdc++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c++                         |libstdc++

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Daniel Krügler from comment #5)
> (In reply to Paolo Carlini from comment #2)
> > Francois, did we change anything in the library for 4.8.x?
> 
> I think that Francois added more iterator concept checking and this one
> looks correct.

I think the change in behaviour is a consequence of
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53263#c11

Potentially we could disable the partitioning checks when input iterators are
used (unless _GLIBCXX_DEBUG_PEDANTIC is defined) or explicitly check for input
iterators and give a better diagnostic.
>From gcc-bugs-return-428027-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 19 10:16:14 2013
Return-Path: <gcc-bugs-return-428027-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 11797 invoked by alias); 19 Aug 2013 10:16:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 11760 invoked by uid 48); 19 Aug 2013 10:16:12 -0000
From: "tkoenig at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/58100] Spurious "DO loop at (1) will be executed zero times" warning
Date: Mon, 19 Aug 2013 10:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tkoenig at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58100-4-IfqyG7Nqxa@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58100-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58100-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-08/txt/msg00951.txt.bz2
Content-length: 281

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX100

--- Comment #4 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
In principle, we could also introduce a

!GCC$ NOWARN

directive, which could suppress all warnings on the following statement.

I'm not volunteering, though :-)

[Bug libstdc++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Thanks everybody. Lower priority wrt regressions, I agree we could do even
better here, just bailing out for input iterators would be Ok with me too
(wouldn't be the first time we do that), but anything that suits you and our
debug-mode expert Francois is basically Ok with me. Thanks again.

[Bug libstdc++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[fdumont at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

--- Comment #9 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Fri Aug 30 20:16:03 2013
New Revision: 202119

URL: http://gcc.gnu.org/viewcvs?rev=202119&root=gcc&view=rev
Log:
2013-08-30  François Dumont  <fdumont@gcc.gnu.org>

    PR libstdc++/58191
    * include/debug/macros.h (__glibcxx_check_partitioned_lower): Add
    __gnu_debug::__base calls on iterators passed to internal debug
    check.
    (__glibcxx_check_partitioned_lower_pred): Likewise.
    (__glibcxx_check_partitioned_upper): Likewise.
    (__glibcxx_check_partitioned_upper_pred): Likewise.
    (__glibcxx_check_sorted): Likewise.
    (__glibcxx_check_sorted_pred): Likewise.
    (__glibcxx_check_sorted_set): Likewise.
    (__glibcxx_check_sorted_set_pred): Likewise.
    * include/debug/functions.h (__check_partitioned_lower):
    Remove code to detect safe iterators.
    (__check_partitioned_upper): Likewise.
    (__check_sorted): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/debug/functions.h
    trunk/libstdc++-v3/include/debug/macros.h
>From gcc-bugs-return-428732-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Aug 30 20:53:01 2013
Return-Path: <gcc-bugs-return-428732-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22036 invoked by alias); 30 Aug 2013 20:53:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21995 invoked by uid 48); 30 Aug 2013 20:52:59 -0000
From: "ebotcazou at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/58278] visibility bug from #26905 still happens with the sparc64 backend
Date: Fri, 30 Aug 2013 20:53:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ebotcazou at gcc dot gnu.org
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58278-4-wktn2OJuZl@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58278-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58278-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-08/txt/msg01656.txt.bz2
Content-length: 777

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX278

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> Compare with this on amd64:
>
>  > c++ -o plain.s -S conftest.cc
>  > c++ -o shared.s -fPIC -shared -S conftest.cc
>  > diff -u plain.s shared.s
> --- plain.s     2013-08-30 21:46:18.000000000 +0200
> +++ shared.s    2013-08-30 21:46:25.000000000 +0200
> @@ -10,7 +10,7 @@
>         movq    %rsp, %rbp
>         .cfi_offset 6, -16
>         .cfi_def_cfa_register 6
> -       call    _ZN10TestStruct4InitEv
> +       call    _ZN10TestStruct4InitEv@PLT
>         popq    %rbp
>         .cfi_def_cfa 7, 8
>         ret
>
> while on sparc (and sparc64) there is no difference.

So what?  What happens if conftest.cc doesn't fiddle with visibility at all?

[Bug libstdc++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2013-08-30
         Resolution|INVALID                     |---
     Ever confirmed|0                           |1
           Severity|normal                      |enhancement

--- Comment #10 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Let's have this open as <enhancement>, already implemented for 4.9.0.

[Bug libstdc++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG

[fdumont at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

--- Comment #11 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Wed Oct 16 20:09:18 2013
New Revision: 203719

URL: http://gcc.gnu.org/viewcvs?rev=203719&root=gcc&view=rev
Log:
2013-10-16  François Dumont  <fdumont@gcc.gnu.org>

    PR libstdc++/58191
    * include/debug/macros.h (__glibcxx_check_partitioned_lower): Add
    __gnu_debug::__base calls on iterators passed to internal debug
    check.
    (__glibcxx_check_partitioned_lower_pred): Likewise.
    (__glibcxx_check_partitioned_upper): Likewise.
    (__glibcxx_check_partitioned_upper_pred): Likewise.
    * include/debug/functions.h (__check_partitioned_lower):
    Remove code to detect safe iterators.
    (__check_partitioned_upper): Likewise.

Modified:
    branches/gcc-4_8-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_8-branch/libstdc++-v3/include/debug/functions.h
    branches/gcc-4_8-branch/libstdc++-v3/include/debug/macros.h
>From gcc-bugs-return-431980-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 16 20:18:51 2013
Return-Path: <gcc-bugs-return-431980-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 590 invoked by alias); 16 Oct 2013 20:18:50 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 566 invoked by uid 48); 16 Oct 2013 20:18:47 -0000
From: "daniel.kruegler at googlemail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/58743] [C++11] parameter packs not expanded with '...'
Date: Wed, 16 Oct 2013 20:18:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: daniel.kruegler at googlemail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-58743-4-1pNzRX7rKw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58743-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58743-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg01124.txt.bz2
Content-length: 892

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58743

Daniel Krügler <daniel.kruegler at googlemail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.kruegler@googlemail.
                   |                            |com

--- Comment #2 from Daniel Krügler <daniel.kruegler at googlemail dot com> ---
(In reply to Paolo Carlini from comment #1)
Indeed the code is invalid, 14.8.1 p7 clarifies that in a note:

"Because the explicit template argument list follows the function template
name, and because conversion member function templates and constructor member
function templates are called without using a function name, there is no way to
provide an explicit template argument list for these function templates."
>From gcc-bugs-return-431979-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 16 20:18:41 2013
Return-Path: <gcc-bugs-return-431979-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32298 invoked by alias); 16 Oct 2013 20:18:40 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32261 invoked by uid 48); 16 Oct 2013 20:18:36 -0000
From: "fdumont at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/58191] Can't use boost transform_iterator with _GLIBCXX_DEBUG
Date: Wed, 16 Oct 2013 20:18:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: fdumont at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: fdumont at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution assigned_to target_milestone
Message-ID: <bug-58191-4-8IX4mlDCrC@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58191-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg01123.txt.bz2
Content-length: 599

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58191

François Dumont <fdumont at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |fdumont at gcc dot gnu.org
   Target Milestone|---                         |4.8.3

--- Comment #12 from François Dumont <fdumont at gcc dot gnu.org> ---
Fixed for 4.8.3 version.
>From gcc-bugs-return-431981-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 16 20:41:14 2013
Return-Path: <gcc-bugs-return-431981-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18316 invoked by alias); 16 Oct 2013 20:41:13 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18270 invoked by uid 48); 16 Oct 2013 20:41:09 -0000
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/58750] Wrong code with realloc on assignment and array constructors with numeric type conversion
Date: Wed, 16 Oct 2013 20:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: burnus at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: keywords short_desc
Message-ID: <bug-58750-4-MXTmgx4gNz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58750-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58750-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg01125.txt.bz2
Content-length: 1359

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX750

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
            Summary|Allocate-on-assignment      |Wrong code with realloc on
                   |statement determines        |assignment and array
                   |incorrect SIZE(other_array) |constructors with numeric
                   |for certain KINDs           |type conversion

--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Interestingly, it fails for:
            powers = [ ( 0, i=1, size(primes))]
but it works for
            powers = [ ( 0_i8, i=1, size(primes))]

Thus, the type conversion during assignement causes the problem. Looking at the
dump, one sees that the array size is taken from the LHS - which is wrong.

It must be some interaction between array assignment with type conversion and
array constructors.

 * * *

(In reply to Dominique d'Humieres from comment #6)
> The test works for me with gfortran 4.7.3:
> [Book15] f90/bug% gfortran-fsf-4.7 pr58750_1.f90

I believe that it has to do with the random memory. At least I get valgrind
failures for all my versions, some fail and some work with GCC 4.7 (or 4.9).