[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[gdr at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #1 from Gabriel Dos Reis <gdr at gcc dot gnu.org> ---
Here is the definition of pretty_printer::~pretty_printer ()
at the location indicated:

pretty_printer::~pretty_printer ()
{
  buffer->~output_buffer ();
  XDELETE (buffer);
}


The macro XDELETE is defined in include/libiberty.h

as:

    #define XDELETE(P)              free ((void*) ℗)


So, I do not see use of any 'operator delete' from
that code.

Is someone trying to #define XDELETE to something else?

-- Gaby
>From gcc-bugs-return-428366-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Aug 25 17:22:23 2013
Return-Path: <gcc-bugs-return-428366-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23635 invoked by alias); 25 Aug 2013 17:22:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23590 invoked by uid 48); 25 Aug 2013 17:22:20 -0000
From: "gdr at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'
Date: Sun, 25 Aug 2013 17:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ada
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gdr at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58239-4-acKJa2AgXS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58239-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58239-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-08/txt/msg01290.txt.bz2
Content-length: 375

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX239

--- Comment #2 from Gabriel Dos Reis <gdr at gcc dot gnu.org> ---
OK, I see the emitted reference to 'operator delete', and I suspect I
have an idea of why the compiler generated this reference even though
it isn't used anywhere in the input source code.

Why are we linking gnatlink with xgcc and not with xg++ -nostdc++?

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Gabriel Dos Reis from comment #2)
> OK, I see the emitted reference to 'operator delete', and I suspect I
> have an idea of why the compiler generated this reference even though
> it isn't used anywhere in the input source code.

It is due to virtual deconstructors and in-charge vs out-of-charge
deconstructors happening.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-08-25
                 CC|                            |ebotcazou at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> OK, I see the emitted reference to 'operator delete', and I suspect I
> have an idea of why the compiler generated this reference even though
> it isn't used anywhere in the input source code.
> 
> Why are we linking gnatlink with xgcc and not with xg++ -nostdc++?

Because we haven't had a real need up to now, IOW we always managed to massage
things so as to avoid the dependency.  Maybe it's the end of the road...

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[gdr at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #6 from Gabriel Dos Reis <gdr at gcc dot gnu.org> ---
(In reply to Eric Botcazou from comment #4)
> > OK, I see the emitted reference to 'operator delete', and I suspect I
> > have an idea of why the compiler generated this reference even though
> > it isn't used anywhere in the input source code.
> > 
> > Why are we linking gnatlink with xgcc and not with xg++ -nostdc++?
> 
> Because we haven't had a real need up to now, IOW we always managed to
> massage things so as to avoid the dependency.  Maybe it's the end of the
> road...

Well, that was a latent bug in the existing code base.  The Ada front-end
(more specifically gnatmake, gnatlink and consorts) linked against
"common" files from GCC source code, most of which are compiled or are
C++ source files.  It should have linked with xg++.  I have a patch right
out of the door while typing this message.  I hope you get a chance to
review and comment it.  I only changed the parts that I empirically
determined to be in trouble.  I welcome your input as someone who has
a broader view to see whether they are other executables that need
to be linked with xg++.

-- Gaby

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[gdr at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #7 from Gabriel Dos Reis <gdr at gcc dot gnu.org> ---
(In reply to Eric Botcazou from comment #4)
> > OK, I see the emitted reference to 'operator delete', and I suspect I
> > have an idea of why the compiler generated this reference even though
> > it isn't used anywhere in the input source code.
> > 
> > Why are we linking gnatlink with xgcc and not with xg++ -nostdc++?
> 
> Because we haven't had a real need up to now, IOW we always managed to
> massage things so as to avoid the dependency.  Maybe it's the end of the
> road...

One more thing: Ada was already using -static-libstdc++ to build those tools.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu.org

--- Comment #8 from Iain Sandoe <iains at gcc dot gnu.org> ---
note that the patch at:

http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01460.html

is not quite enough to fix this on Darwin - since we use :

 %{static|static-libgcc|static-libstdc++:%:replace-outfile(-lstdc++
libstdc++.a%s)}

to implement -static-libstadc++.

The relevant dir needs to be added as "-B" for this to work - unfortunately,
I'm not able to look at this right now..

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[gdr at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #9 from Gabriel Dos Reis <gdr at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #8)
> note that the patch at:
> 
> http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01460.html
> 
> is not quite enough to fix this on Darwin - since we use :
> 
>  %{static|static-libgcc|static-libstdc++:%:replace-outfile(-lstdc++
> libstdc++.a%s)}
> 
> to implement -static-libstadc++.
> 
> The relevant dir needs to be added as "-B" for this to work - unfortunately,
> I'm not able to look at this right now..

-static-libstdc++ was already being used before this patch.  So, the "-B"
directories where already there.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #10 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Gabriel Dos Reis from comment #9)
> (In reply to Iain Sandoe from comment #8)
> > note that the patch at:
> > 
> > http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01460.html
> > 
> > is not quite enough to fix this on Darwin - since we use :
> > 
> >  %{static|static-libgcc|static-libstdc++:%:replace-outfile(-lstdc++
> > libstdc++.a%s)}
> > 
> > to implement -static-libstadc++.
> > 
> > The relevant dir needs to be added as "-B" for this to work - unfortunately,
> > I'm not able to look at this right now..
> 
> -static-libstdc++ was already being used before this patch.  So, the "-B"
> directories where already there.

"grep -R -static-libstdc++ gcc/ada" suggests that -static-libstdc++ only
appears in a Changelog entry.

also the gcc driver silently ignores -static-libstdc++.

certainly, the -B options are passed when other gcc components are built (or it
would fail to bootstrap on Darwin). 

However, your current patch fails with:
ld: file not found: libstdc++.a

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #11 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> "grep -R -static-libstdc++ gcc/ada" suggests that -static-libstdc++ only
> appears in a Changelog entry.
> 
> also the gcc driver silently ignores -static-libstdc++.
> 
> certainly, the -B options are passed when other gcc components are built (or
> it would fail to bootstrap on Darwin). 

-static-libstdc++ comes from the compiler via a Makefile variable, not from the
gnattools.  We probably miss another variable to get the -B options.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[gdr at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #12 from Gabriel Dos Reis <gdr at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #10)

> also the gcc driver silently ignores -static-libstdc++.

Isn't this the problem?

> certainly, the -B options are passed when other gcc components are built (or
> it would fail to bootstrap on Darwin). 

The Makefiles in gcc/ pass down those options in variables.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |ebotcazou at gcc dot gnu.org

--- Comment #13 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Created attachment 30734
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30734&action=edit
Tentative fix

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30734|0                           |1
        is obsolete|                            |

--- Comment #14 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 30737
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30737&action=edit
tentative fix V1

thanks Eric,

As I was trying to say in earlier comments (and failing to be clear, I
suppose), Darwin needs the library dirs as "-B" in addition to "-L", because we
have to use spec substitution to access static libs.

The "-B" have always been missing - and the fact that the gcc driver was
invoked with "-static-libstdc++" would not show this up, since that
option/driver combination does not cause any libraries to be added to the link
line.

Anyway, the revised patch includes -B where you've added the -L.

With this (and a fix for pr58269), x86_64-darwin12 bootstraps and completes the
ada and gnat test-suites with no new fails.

I am bootstrapping x86_64-darwin10 (slower machine) and will try a darwin12 X
linux later (and powerpc-darwin9 maybe overnight).

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #15 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> As I was trying to say in earlier comments (and failing to be clear, I
> suppose), Darwin needs the library dirs as "-B" in addition to "-L", because
> we have to use spec substitution to access static libs.
> 
> The "-B" have always been missing - and the fact that the gcc driver was
> invoked with "-static-libstdc++" would not show this up, since that
> option/driver combination does not cause any libraries to be added to the
> link line.
> 
> Anyway, the revised patch includes -B where you've added the -L.

My bad, and the -B's are also present in the CXX variable of the gcc/ Makefile,
from which I cooked up the new variable...  Thanks for fixing it!

> With this (and a fix for pr58269), x86_64-darwin12 bootstraps and completes
> the ada and gnat test-suites with no new fails.

That's great, thanks again.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #16 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The patch in comment #14 allows to bootstrap x86_64-apple-darwin10 with Ada.
The only failures are for gnat.dg/specs/linker_alias.ads (see
http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00996.html).

Thanks for the patch.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #17 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Sun Sep  1 16:51:41 2013
New Revision: 202150

URL: http://gcc.gnu.org/viewcvs?rev=202150&root=gcc&view=rev
Log:
    PR ada/58239
gnattools/
    * Makefile.in (CXX_LFLAGS): New.
    (TOOLS_FLAGS_TO_PASS_NATIVE): Pass CXX and CXX_LFLAGS.
    (TOOLS_FLAGS_TO_PASS_RE): Likewise.
    (TOOLS_FLAGS_TO_PASS_CROSS): Pass CXX.
gcc/ada/
    * gcc-interface/Makefile.in (GCC_LINK_FLAGS): Add -static-libstdc++.
    (GCC_LINK): Use CXX instead of CC.
    * gcc-interface/Make-lang.in (CXX_LFLAGS): New.
    (ADA_TOOLS_FLAGS_TO_PASS): Pass CXX, and CXX_LFLAGS for native.

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/Make-lang.in
    trunk/gcc/ada/gcc-interface/Makefile.in
    trunk/gnattools/ChangeLog
    trunk/gnattools/Makefile.in

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #18 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Presumably fixed.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[laguest at archeia dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

Luke A. Guest <laguest at archeia dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laguest at archeia dot com

--- Comment #19 from Luke A. Guest <laguest at archeia dot com> ---
I think this fix has been reverted somewhere in source as I've just got trunk
from SVN and have had to patch by hand.

[Bug ada/58239] [4.9 regression] pretty-print.c:789: undefined reference to `operator delete(void*)'

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58239

--- Comment #20 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> I think this fix has been reverted somewhere in source as I've just got
> trunk from SVN and have had to patch by hand.

It's very easy to check, the patch is linked from comment #17...