[Bug middle-end/58245] -fstack-protector[-all] does not protect functions that call noreturn functions

["timo.teras at iki dot fi" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58245

--- Comment #5 from Timo Teräs <timo.teras at iki dot fi> ---
I have the same issue and confirm this issue. Any ideas how to fix it properly?
>From gcc-bugs-return-430903-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 01 14:49:43 2013
Return-Path: <gcc-bugs-return-430903-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32184 invoked by alias); 1 Oct 2013 14:49:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32146 invoked by uid 55); 1 Oct 2013 14:49:40 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/57298] GOMP_CPU_AFFINITY will not work when system has >1024 cores
Date: Tue, 01 Oct 2013 14:49:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libgomp
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-57298-4-JpQ1gaxqMo@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-57298-4@http.gcc.gnu.org/bugzilla/>
References: <bug-57298-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg00047.txt.bz2
Content-length: 1950

http://gcc.gnu.org/bugzilla/show_bug.cgi?idW298

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Tue Oct  1 14:49:36 2013
New Revision: 203064

URL: http://gcc.gnu.org/viewcvs?rev 3064&root=gcc&view=rev
Log:
    PR libgomp/57298
    * config/linux/proc.c (gomp_cpuset_size, gomp_cpusetp): New variables.
    (gomp_cpuset_popcount): Use CPU_COUNT_S if available, or CPU_COUNT if
    gomp_cpuset_size is sizeof (cpu_set_t).  Use gomp_cpuset_size instead
    of sizeof (cpu_set_t) to determine number of iterations.
    (gomp_init_num_threads): Initialize gomp_cpuset_size and gomp_cpusetp
    here, use gomp_cpusetp instead of &cpuset and pass gomp_cpuset_size
    instead of sizeof (cpu_set_t) to pthread_getaffinity_np.
    (get_num_procs): Don't call pthread_getaffinity_np if gomp_cpusetp
    is NULL.  Use gomp_cpusetp instead of &cpuset and pass gomp_cpuset_size
    instead of sizeof (cpu_set_t) to pthread_getaffinity_np.
    * config/linux/proc.h (gomp_cpuset_popcount): Add attribute_hidden.
    (gomp_cpuset_size, gomp_cpusetp): Declare.
    * config/linux/affinity.c (CPU_ISSET_S, CPU_ZERO_S, CPU_SET_S): Define
    if CPU_ALLOC_SIZE isn't defined.
    (gomp_init_affinity): Don't call pthread_getaffinity_np here, instead
    use gomp_cpusetp computed by gomp_init_num_threads.  Use CPU_*_S
    variants of macros with gomp_cpuset_size as set size, for cpusetnew
    use alloca for it if CPU_ALLOC_SIZE is defined, otherwise local
    fixed size variable.
    (gomp_init_thread_affinity): Use CPU_*_S variants of macros with
    gomp_cpuset_size as set size, for cpuset use alloca for it if
    CPU_ALLOC_SIZE is defined, otherwise local fixed size variable.

Modified:
    branches/gomp-4_0-branch/libgomp/ChangeLog.gomp
    branches/gomp-4_0-branch/libgomp/config/linux/affinity.c
    branches/gomp-4_0-branch/libgomp/config/linux/proc.c
    branches/gomp-4_0-branch/libgomp/config/linux/proc.h