[Bug target/58269] [4.9 Regression] ICE when building libobjc on x86_64-apple-darwin* after revision 201915

["iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58269

--- Comment #14 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #13)
> > Yes, confirmed that on x86_64-linux r202286 is the culprit.
> 
> See pr58139 comments #6 to #11.

> @@ -34466,7 +34467,7 @@ ix86_hard_regno_mode_ok (int regno, enum
>  
>        /* OImode move is available only when AVX is enabled.  */
>        return ((TARGET_AVX && mode == OImode)
> -	      || VALID_AVX256_REG_MODE (mode)
> +	      || (TARGET_AVX && VALID_AVX256_REG_MODE (mode))
>  	      || VALID_SSE_REG_MODE (mode)
>  	      || VALID_SSE2_REG_MODE (mode)
>  	      || VALID_MMX_REG_MODE (mode)
> 

assuming that the patch above is applied to deal with pr58139,

Are you saying that:
-  if (TARGET_MACHO)
-    {
-      if (SSE_REGNO_P (regno) && TARGET_SSE)
-        return true;
-    }
-  else
-    {
-      if (TARGET_SSE && SSE_REGNO_P (regno)
-          && (regno < FIRST_SSE_REG + SSE_REGPARM_MAX))
-        return true;
-    }
+  if (TARGET_SSE && SSE_REGNO_P (regno)
+      && (regno < FIRST_SSE_REG + SSE_REGPARM_MAX))
+    return true;

gives a compare fail for you?
>From gcc-bugs-return-429132-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 06 13:02:22 2013
Return-Path: <gcc-bugs-return-429132-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7381 invoked by alias); 6 Sep 2013 13:02:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7327 invoked by uid 48); 6 Sep 2013 13:02:18 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/58269] [4.9 Regression] ICE when building libobjc on x86_64-apple-darwin*  after revision 201915
Date: Fri, 06 Sep 2013 13:02:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58269-4-qixsrFxwNG@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58269-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58269-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-09/txt/msg00372.txt.bz2
Content-length: 1203

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX269

--- Comment #15 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
(In reply to Iain Sandoe from comment #14)
> assuming that the patch above is applied to deal with pr58139,

Indeed!

> Are you saying that:
> -  if (TARGET_MACHO)
> -    {
> -      if (SSE_REGNO_P (regno) && TARGET_SSE)
> -        return true;
> -    }
> -  else
> -    {
> -      if (TARGET_SSE && SSE_REGNO_P (regno)
> -          && (regno < FIRST_SSE_REG + SSE_REGPARM_MAX))
> -        return true;
> -    }
> +  if (TARGET_SSE && SSE_REGNO_P (regno)
> +      && (regno < FIRST_SSE_REG + SSE_REGPARM_MAX))
> +    return true;
> gives a compare fail for you?

No: I did not test it although the initial fix worked for me). The comparison
failures occur with r202318 and the patch for pr58139 only. These failures are
fixed by the patch

--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -5708,7 +5708,8 @@ ix86_function_arg_regno_p (int regno)

   if (TARGET_MACHO)
     {
-      if (SSE_REGNO_P (regno) && TARGET_SSE)
+      if (SSE_REGNO_P (regno) && TARGET_SSE
+         && ! EXT_REX_SSE_REGNO_P (regno))
         return true;
     }
   else

from comment #6.