public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "yufeng at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/58298] [4.9 regression] ICE in mentions_vars_p_field_decl, at lto/lto.c:1392
Date: Fri, 06 Sep 2013 16:55:00 -0000	[thread overview]
Message-ID: <bug-58298-4-iz5i7naGMQ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58298-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58298

Yufeng Zhang <yufeng at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yufeng at gcc dot gnu.org

--- Comment #3 from Yufeng Zhang <yufeng at gcc dot gnu.org> ---
I briefly saw the issue on aarch64 and arm, but I think it has been fixed by
the following commit:

commit 8d4e699477b53778f0e933cb77d71e28a1e70536
Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Mon Sep 2 14:45:06 2013 +0000

        * lto.c (mentions_vars_p_field_decl, lto_fixup_prevailing_decls):
        DECL_FIELD_OFFSET can contain an reference to variable.


    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@202174
138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/lto/ChangeLog b/gcc/lto/ChangeLog
index cf31c21..fe8e463 100644
--- a/gcc/lto/ChangeLog
+++ b/gcc/lto/ChangeLog
@@ -1,5 +1,10 @@
 2013-08-31  Jan Hubicka  <jh@suse.cz>

+       * lto.c (mentions_vars_p_field_decl, lto_fixup_prevailing_decls): 
+       DECL_FIELD_OFFSET can contain an reference to variable.
+
+2013-08-31  Jan Hubicka  <jh@suse.cz>
+
        * lto.c (tree_with_vars): Turn into vector.
        (MAYBE_REMEMBER_WITH_VARS): Change to...
        (CHECK_VAR): ... this one.
diff --git a/gcc/lto/lto.c b/gcc/lto/lto.c
index 1d1350b..0cea778 100644
--- a/gcc/lto/lto.c
+++ b/gcc/lto/lto.c
@@ -1389,7 +1389,7 @@ mentions_vars_p_field_decl (tree t)
 {
   if (mentions_vars_p_decl_common (t))
     return true;
-  CHECK_NO_VAR (DECL_FIELD_OFFSET (t));
+  CHECK_VAR (DECL_FIELD_OFFSET (t));
   CHECK_NO_VAR (DECL_BIT_FIELD_TYPE (t));
   CHECK_NO_VAR (DECL_QUALIFIER (t));
   CHECK_NO_VAR (DECL_FIELD_BIT_OFFSET (t));
@@ -3207,7 +3207,7 @@ lto_fixup_prevailing_decls (tree t)
        LTO_SET_PREVAIL (DECL_FUNCTION_PERSONALITY (t));
       if (CODE_CONTAINS_STRUCT (code, TS_FIELD_DECL))
        {
-         LTO_NO_PREVAIL (DECL_FIELD_OFFSET (t));
+         LTO_SET_PREVAIL (DECL_FIELD_OFFSET (t));
          LTO_NO_PREVAIL (DECL_BIT_FIELD_TYPE (t));
          LTO_NO_PREVAIL (DECL_QUALIFIER (t));
          LTO_NO_PREVAIL (DECL_FIELD_BIT_OFFSET (t));


  parent reply	other threads:[~2013-09-06 16:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02 14:09 [Bug lto/58298] New: " schwab@linux-m68k.org
2013-09-02 14:10 ` [Bug lto/58298] " schwab@linux-m68k.org
2013-09-02 14:32 ` izamyatin at gmail dot com
2013-09-03  8:28 ` bernd.edlinger at hotmail dot de
2013-09-06 16:55 ` yufeng at gcc dot gnu.org [this message]
2013-10-30 13:36 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-58298-4-iz5i7naGMQ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).