public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/58387] [4.9 Regression] wrong code at -Os and above on x86_64-linux-gnu (both 32-bit and 64-bit modes)
Date: Fri, 13 Sep 2013 06:02:00 -0000	[thread overview]
Message-ID: <bug-58387-4-EuimhElg2m@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58387-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58387

--- Comment #11 from Jeffrey A. Law <law at redhat dot com> ---
I know what's happening here.  It's obscure and quite nasty.

We have a jump threading opportunity which requires threading through a joiner
block.  The jump thread leaving one edge of the joiner eventually reaches the
same block as the joiner's other outgoing edge.

This is all fine and good as the threading code knows the conditions under
which it's still safe to thread that jump.  Specifically it has to look at the
PHI arguments for the two key edges and verify for each PHI that the values
associated with the two key edges are the same.  This condition is in place to
make the SSA graph updates easier to deal with.

At the time we discover and register the jump thread the condition holds and
we're good to go.  However a short time later we discover that we can propagate
a constant to one of those PHI arguments and do so.  Now the condition we
needed for updating the SSA graph was broken.  We update the SSA graph
incorrectly.

I'm going to have to review the SSA graph updating code a bit tomorrow AM.  In
the mean time I'm going to revert the patch.


  parent reply	other threads:[~2013-09-13  6:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 23:10 [Bug middle-end/58387] New: " su at cs dot ucdavis.edu
2013-09-11  5:17 ` [Bug middle-end/58387] " jakub at gcc dot gnu.org
2013-09-11  5:22 ` su at cs dot ucdavis.edu
2013-09-11  6:13 ` jakub at gcc dot gnu.org
2013-09-11  7:10 ` su at cs dot ucdavis.edu
2013-09-11 15:04 ` su at cs dot ucdavis.edu
2013-09-11 16:50 ` [Bug middle-end/58387] [4.9 Regression] " hjl.tools at gmail dot com
2013-09-12 21:19 ` hjl.tools at gmail dot com
2013-09-12 21:29 ` law at redhat dot com
2013-09-13  3:35 ` law at redhat dot com
2013-09-13  6:02 ` law at redhat dot com [this message]
2013-09-13  7:10 ` su at cs dot ucdavis.edu
2013-09-13 11:10 ` markus at trippelsdorf dot de
2013-09-13 15:28 ` law at redhat dot com
2013-09-13 15:48 ` su at cs dot ucdavis.edu
2013-09-13 16:02 ` law at redhat dot com
2013-09-13 16:25 ` joseph at codesourcery dot com
2013-09-13 16:33 ` law at redhat dot com
2013-09-13 17:31 ` glisse at gcc dot gnu.org
2013-09-13 18:00 ` law at redhat dot com
2013-09-13 19:18 ` glisse at gcc dot gnu.org
2013-09-17 18:39 ` law at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-58387-4-EuimhElg2m@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).